Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138991/?format=api
{ "id": 138991, "url": "http://patches.dpdk.org/api/patches/138991/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240330030429.4630-12-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240330030429.4630-12-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240330030429.4630-12-stephen@networkplumber.org", "date": "2024-03-30T03:00:54", "name": "[v19,11/15] log: add hook for printing log messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9814372372b970051bd81b7e3ed555056397ae8f", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240330030429.4630-12-stephen@networkplumber.org/mbox/", "series": [ { "id": 31647, "url": "http://patches.dpdk.org/api/series/31647/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31647", "date": "2024-03-30T03:00:44", "name": "Logging unification and improvements", "version": 19, "mbox": "http://patches.dpdk.org/series/31647/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138991/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138991/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5827D43D8B;\n\tSat, 30 Mar 2024 04:05:58 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5B8FD42D26;\n\tSat, 30 Mar 2024 04:05:01 +0100 (CET)", "from mail-pf1-f174.google.com (mail-pf1-f174.google.com\n [209.85.210.174])\n by mails.dpdk.org (Postfix) with ESMTP id 0783F406B6\n for <dev@dpdk.org>; Sat, 30 Mar 2024 04:04:50 +0100 (CET)", "by mail-pf1-f174.google.com with SMTP id\n d2e1a72fcca58-6e6ee9e3cffso1729428b3a.1\n for <dev@dpdk.org>; Fri, 29 Mar 2024 20:04:49 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n o3-20020a056a00214300b006e6288ef4besm3655486pfk.54.2024.03.29.20.04.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 29 Mar 2024 20:04:48 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711767889;\n x=1712372689; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ef+4W+K/w1vN13UT87NF7vTe2NZwGZarLjZdNpClf5Y=;\n b=0TIGlq6g7ASPUA+IeFOhu+aAHiiHBcmftlpAts1rZj1y8o9fLAvOdK5ni0lI74piKz\n 7NjzvqnfK4q8ha3eLxYpI9SPQ222C5kXwEw97hCUXTvi5/EwB0mZKv2pjPgXJHK4gS+M\n 8GxVdenLSEzIVvA11xSUJQSK7JcwO9SgCKdPEyiP7XWMMOFaO6XyezX7VXFUtNJXbdCl\n AuaSBSwKE1hdcNw2tUpZENwwLQPjLZZLRCkQCX8faAplUe8RhOqMAMMbqHO5xnUeKVV7\n buiqqe8/1Lsrb0KJRxDbwSIgmKm53sORyWKgDIG+8BGPdVe/EjkSiqCm2+hjVBHEuRz3\n qExg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711767889; x=1712372689;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=ef+4W+K/w1vN13UT87NF7vTe2NZwGZarLjZdNpClf5Y=;\n b=MepygEvmmJBwxRdzXTuDoKGRZPPou6liEoE8jsbx0X11NeOgL4xRmJT0PbTRiA90yz\n eBke3OjH/unP41bCwpZtRF6y5vAXURPyIT+1/vLH//KvbXOQWVYEa5bcqNL/J9DRtkwg\n FxQZnZH2maEgrGgk7RVTiHXTJ3MrJwbQ+AnCfo3Ol93WKtlFrvrc94EB/KMVAQ4J89lS\n dZz8pl2aQVr4EYf1Kqa2xO2Hx1Zzm9g0nrQsdN/c5d34zWy3keXhNbzJq6r/R02ZvCwl\n e34s+qDt5zuyqx1xLym/QaVBvaqS2kdNAEGnbfokBGzg2ObuzRFr/u39aqUSiNAPVm5o\n K2RA==", "X-Gm-Message-State": "AOJu0YxFFZYtK1nYUtT/30QxrFwRFAK95tqDbJQOnBpIWZ+7LDu+LaTc\n o8ipkUgAFODwBn3rXMtpBzx2LMI8jOcTjRWJhKpJJiNt0iXHDhCUrVPjE3hp3p/0CQUY6ACTb4R\n 5", "X-Google-Smtp-Source": "\n AGHT+IHvcCxK3i9OotumUVWSTQWkFaBLLvmxDuhFYGOrrodDuJoTvXhEBxBcefucFqNHK6aHVPzPRg==", "X-Received": "by 2002:a05:6a00:1994:b0:6ea:f43b:b961 with SMTP id\n d20-20020a056a00199400b006eaf43bb961mr1705048pfl.6.1711767889246;\n Fri, 29 Mar 2024 20:04:49 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v19 11/15] log: add hook for printing log messages", "Date": "Fri, 29 Mar 2024 20:00:54 -0700", "Message-ID": "<20240330030429.4630-12-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240330030429.4630-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240330030429.4630-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This is useful for when decorating log output for console\nor journal. Provide basic version in this patch.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/log/log.c | 14 +++++++++++++-\n lib/log/log_private.h | 11 +++++++++++\n 2 files changed, 24 insertions(+), 1 deletion(-)\n create mode 100644 lib/log/log_private.h", "diff": "diff --git a/lib/log/log.c b/lib/log/log.c\nindex 3fe86ddcd7..71b00528d0 100644\n--- a/lib/log/log.c\n+++ b/lib/log/log.c\n@@ -18,6 +18,7 @@\n #include <rte_per_lcore.h>\n \n #include \"log_internal.h\"\n+#include \"log_private.h\"\n \n #ifdef RTE_EXEC_ENV_WINDOWS\n #define strdup _strdup\n@@ -28,16 +29,19 @@ struct rte_log_dynamic_type {\n \tuint32_t loglevel;\n };\n \n+\n /** The rte_log structure. */\n static struct rte_logs {\n \tuint32_t type; /**< Bitfield with enabled logs. */\n \tuint32_t level; /**< Log level. */\n \tFILE *file; /**< Output file set by rte_openlog_stream, or NULL. */\n+\tlog_print_t print_func;\n \tsize_t dynamic_types_len;\n \tstruct rte_log_dynamic_type *dynamic_types;\n } rte_logs = {\n \t.type = UINT32_MAX,\n \t.level = RTE_LOG_DEBUG,\n+\t.print_func = log_print,\n };\n \n struct rte_eal_opt_loglevel {\n@@ -74,6 +78,7 @@ int\n rte_openlog_stream(FILE *f)\n {\n \trte_logs.file = f;\n+\trte_logs.print_func = log_print;\n \treturn 0;\n }\n \n@@ -470,7 +475,7 @@ rte_vlog(uint32_t level, uint32_t logtype, const char *format, va_list ap)\n \tRTE_PER_LCORE(log_cur_msg).loglevel = level;\n \tRTE_PER_LCORE(log_cur_msg).logtype = logtype;\n \n-\tret = vfprintf(f, format, ap);\n+\tret = (*rte_logs.print_func)(f, level, format, ap);\n \tfflush(f);\n \treturn ret;\n }\n@@ -499,6 +504,13 @@ eal_log_syslog(const char *mode __rte_unused)\n \treturn -1;\n }\n \n+/* default log print function */\n+int\n+log_print(FILE *f, uint32_t level __rte_unused, const char *format, va_list ap)\n+{\n+\treturn vfprintf(f, format, ap);\n+}\n+\n /*\n * Called by rte_eal_init\n */\ndiff --git a/lib/log/log_private.h b/lib/log/log_private.h\nnew file mode 100644\nindex 0000000000..afd833c3bd\n--- /dev/null\n+++ b/lib/log/log_private.h\n@@ -0,0 +1,11 @@\n+/* SPDX-License-Identifier: BSD-3-Clause */\n+\n+#ifndef LOG_PRIVATE_H\n+#define LOG_PRIVATE_H\n+\n+typedef int (*log_print_t)(FILE *f, uint32_t level, const char *fmt, va_list ap);\n+\n+__rte_format_printf(3, 0)\n+int log_print(FILE *f, uint32_t level, const char *format, va_list ap);\n+\n+#endif /* LOG_PRIVATE_H */\n", "prefixes": [ "v19", "11/15" ] }