Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138971/?format=api
{ "id": 138971, "url": "http://patches.dpdk.org/api/patches/138971/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240328235156.5768-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240328235156.5768-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240328235156.5768-7-stephen@networkplumber.org", "date": "2024-03-28T23:49:36", "name": "[v18,06/15] eal: do not duplicate rte_init_alert() messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "581209bb7009c758808b66b67d5fb90b4f3e9948", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240328235156.5768-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 31646, "url": "http://patches.dpdk.org/api/series/31646/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31646", "date": "2024-03-28T23:49:30", "name": "Logging unification and improvements", "version": 18, "mbox": "http://patches.dpdk.org/series/31646/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138971/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138971/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 49DB243D73;\n\tFri, 29 Mar 2024 00:52:51 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1F964427E5;\n\tFri, 29 Mar 2024 00:52:21 +0100 (CET)", "from mail-oa1-f53.google.com (mail-oa1-f53.google.com\n [209.85.160.53]) by mails.dpdk.org (Postfix) with ESMTP id 59B8F4114B\n for <dev@dpdk.org>; Fri, 29 Mar 2024 00:52:12 +0100 (CET)", "by mail-oa1-f53.google.com with SMTP id\n 586e51a60fabf-222b6a05bb1so965779fac.3\n for <dev@dpdk.org>; Thu, 28 Mar 2024 16:52:12 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n g21-20020a631115000000b005df58c83e89sm1875650pgl.84.2024.03.28.16.52.10\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 28 Mar 2024 16:52:11 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711669931;\n x=1712274731; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=jpuKRgSOIbpBBbsAGPHwAR/lg4j9u3JMjpynNGAPSTY=;\n b=HlQUSSo4tv6XoGEVSjN63GGzlO+Uj6NmxQYMTkD++ze+IFSjBXYdlq5SIDnPixQ07O\n Rn1z2NnSeYHfuW/0QkJIgCBsbgP7Xc33+aAr3Ca2S6a/HPt8eVEbu+ULmxbMf4ZpaxdW\n 32GAhO84mH0gAuD/Why8iZUSCbJMU6WFMyZAdo1bEdAwyvTvScS5ahwlfFFmpCUqJy0L\n tEFrwJqU6+CPSRCndjK8PJ4VpUkrpDXLW2XgmKLqDGn4KrZvD1xgM/Edxp4C/WfNDx7/\n N23hYPn3eIHmAZd/FYYsZzaJK3A3h6P78/s1fwgXgyHw5cC/eCC0aHQWBpg39DdJ4tAW\n tRYA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711669931; x=1712274731;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=jpuKRgSOIbpBBbsAGPHwAR/lg4j9u3JMjpynNGAPSTY=;\n b=iuFnh9Tg2NGBIJ+M3A39JbU0e95Q8KQjsovBIkWRjAReBKUk1AFBu4yHI/fNN7Vnea\n n8rC6k4uJgqkJSY5JZDWWywQL7NLHXTmO4earvLvMszpJtxwP2JA0VHMcILSxEkXgJ+j\n s7w1nof84nRlzRvkQwGFuaQkIJJ6EIQ2MqT5UJfk7yaGpFBidTiTxFVHBQQWsBEEbKMA\n 6O80z5ecTYMfc7hNBbNpf4TrI0ry17zyvXDON6WYEk3VKXdzLqupMorr0Wt04A+wsKq4\n E2trhT6zFLRdb0Wh3a60LCaRpIgsmCQWB9w7+On0qlEh6/UifppDQ4M5j1e/zxvV1UN3\n nwAA==", "X-Gm-Message-State": "AOJu0YyXp/cGlfHqmdyOFTdLhJToGptfshh/E6HxAIO7otRvGjfkz9VH\n RuZ2tOLypKyPQr83oP3mXwuONNCtcLki9MkSKmeL0XYMyrN0IWuUpz8vFgci3p9ixX1IBmnyXnQ\n e", "X-Google-Smtp-Source": "\n AGHT+IFm94rrjJdgAuSaaQcLuozuN40YAHnteQ6tNVeZihoZRhAS/SlRim+iFqFHVyekdePZ2fC9Tg==", "X-Received": "by 2002:a05:6870:c34f:b0:229:c1d4:83bf with SMTP id\n e15-20020a056870c34f00b00229c1d483bfmr685678oak.8.1711669931561;\n Thu, 28 Mar 2024 16:52:11 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v18 06/15] eal: do not duplicate rte_init_alert() messages", "Date": "Thu, 28 Mar 2024 16:49:36 -0700", "Message-ID": "<20240328235156.5768-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240328235156.5768-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240328235156.5768-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The message already goes through logging, and does not need\nto be printed on stderr. Message level should be ALERT\nto match function name.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/eal/freebsd/eal.c | 3 +--\n lib/eal/linux/eal.c | 3 +--\n 2 files changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex 9825bcea0b..17b56f38aa 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -529,8 +529,7 @@ rte_eal_iopl_init(void)\n \n static void rte_eal_init_alert(const char *msg)\n {\n-\tfprintf(stderr, \"EAL: FATAL: %s\\n\", msg);\n-\tEAL_LOG(ERR, \"%s\", msg);\n+\tEAL_LOG(ALERT, \"%s\", msg);\n }\n \n /* Launch threads, called at application init(). */\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex bffeb1f34e..23dc26b124 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void)\n \n static void rte_eal_init_alert(const char *msg)\n {\n-\tfprintf(stderr, \"EAL: FATAL: %s\\n\", msg);\n-\tEAL_LOG(ERR, \"%s\", msg);\n+\tEAL_LOG(ALERT, \"%s\", msg);\n }\n \n /*\n", "prefixes": [ "v18", "06/15" ] }