Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138957/?format=api
{ "id": 138957, "url": "http://patches.dpdk.org/api/patches/138957/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240328134925.1150-2-shaibran@amazon.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240328134925.1150-2-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240328134925.1150-2-shaibran@amazon.com", "date": "2024-03-28T13:49:25", "name": "[1/1] net/ena: fix metrics excessive memory consumption", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "513b25a8879a22e5d5c5c65bd5ee25fe48d44e5e", "submitter": { "id": 2930, "url": "http://patches.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240328134925.1150-2-shaibran@amazon.com/mbox/", "series": [ { "id": 31638, "url": "http://patches.dpdk.org/api/series/31638/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31638", "date": "2024-03-28T13:49:24", "name": "net/ena/base bug fix for 23.11 stable only", "version": 1, "mbox": "http://patches.dpdk.org/series/31638/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138957/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/138957/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 65C0343D6C;\n\tThu, 28 Mar 2024 14:49:45 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 52BC341144;\n\tThu, 28 Mar 2024 14:49:44 +0100 (CET)", "from smtp-fw-52004.amazon.com (smtp-fw-52004.amazon.com\n [52.119.213.154])\n by mails.dpdk.org (Postfix) with ESMTP id 06EC340FDE;\n Thu, 28 Mar 2024 14:49:42 +0100 (CET)", "from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO\n smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.43.8.2])\n by smtp-border-fw-52004.iad7.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2024 13:49:39 +0000", "from EX19MTAEUB002.ant.amazon.com [10.0.43.254:50833]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.40.37:2525]\n with esmtp (Farcaster)\n id 784c0c00-8ae7-437f-99f3-fb263e6d0a58;\n Thu, 28 Mar 2024 13:49:37 +0000 (UTC)", "from EX19D007EUA001.ant.amazon.com (10.252.50.133) by\n EX19MTAEUB002.ant.amazon.com (10.252.51.59) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Thu, 28 Mar 2024 13:49:37 +0000", "from EX19MTAUWC001.ant.amazon.com (10.250.64.145) by\n EX19D007EUA001.ant.amazon.com (10.252.50.133) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Thu, 28 Mar 2024 13:49:36 +0000", "from HFA15-CG15235BS.amazon.com (10.85.143.172) by\n mail-relay.amazon.com (10.250.64.145) with Microsoft SMTP Server id\n 15.2.1258.28 via Frontend Transport; Thu, 28 Mar 2024 13:49:34 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1711633783; x=1743169783;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=/22v47v434gCF1t4riF1UHRFc2F3R8yO+C1AAKS+wNA=;\n b=vpsICdItLovRyN8Z0Z5WL+kltiNEwPTYT/tzxkYE91azHgd6ZaP+1/9h\n smTrz8E3H9BkWkhWzfXg7OeneosLnVQ+XTA8E1YbyZwDK2n3uZQ3tAstt\n +BR7NNk3AbjjdcEDz1KrvbrT+yVJwfydu0VtqF4pwjIz/AsyFQKeEqT5e 4=;", "X-IronPort-AV": "E=Sophos;i=\"6.07,162,1708387200\"; d=\"scan'208\";a=\"195061742\"", "X-Farcaster-Flow-ID": "784c0c00-8ae7-437f-99f3-fb263e6d0a58", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>, <bluca@debian.org>,\n <christian.ehrhardt@canonical.com>, <xuemingl@nvidia.com>,\n <ktraynor@redhat.com>", "CC": "<stable@dpdk.org>, <dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>", "Subject": "[PATCH 1/1] net/ena: fix metrics excessive memory consumption", "Date": "Thu, 28 Mar 2024 15:49:25 +0200", "Message-ID": "<20240328134925.1150-2-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240328134925.1150-1-shaibran@amazon.com>", "References": "<20240328134925.1150-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\nThe driver accidentally allocates a huge memory\nbuffer for the customer metrics because it uses\nan uninitialized variable for the buffer length.\nThis can lead to excessive memory footprint for\nthe driver which can even fail to initialize in\ncase of insufficient memory.\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\nFixes: f73f53f7dc7a (\"net/ena: upgrade HAL\")\nBugzilla ID: 14001\n---\n drivers/net/ena/base/ena_com.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c\nindex 6953a1fa33..8ae7dcf48e 100644\n--- a/drivers/net/ena/base/ena_com.c\n+++ b/drivers/net/ena/base/ena_com.c\n@@ -3134,16 +3134,18 @@ int ena_com_allocate_debug_area(struct ena_com_dev *ena_dev,\n int ena_com_allocate_customer_metrics_buffer(struct ena_com_dev *ena_dev)\n {\n \tstruct ena_customer_metrics *customer_metrics = &ena_dev->customer_metrics;\n+\tcustomer_metrics->buffer_len = ENA_CUSTOMER_METRICS_BUFFER_SIZE;\n+\tcustomer_metrics->buffer_virt_addr = NULL;\n \n \tENA_MEM_ALLOC_COHERENT(ena_dev->dmadev,\n \t\t\t customer_metrics->buffer_len,\n \t\t\t customer_metrics->buffer_virt_addr,\n \t\t\t customer_metrics->buffer_dma_addr,\n \t\t\t customer_metrics->buffer_dma_handle);\n-\tif (unlikely(customer_metrics->buffer_virt_addr == NULL))\n+\tif (unlikely(customer_metrics->buffer_virt_addr == NULL)) {\n+\t\tcustomer_metrics->buffer_len = 0;\n \t\treturn ENA_COM_NO_MEM;\n-\n-\tcustomer_metrics->buffer_len = ENA_CUSTOMER_METRICS_BUFFER_SIZE;\n+\t}\n \n \treturn 0;\n }\n", "prefixes": [ "1/1" ] }