Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138955/?format=api
{ "id": 138955, "url": "http://patches.dpdk.org/api/patches/138955/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240328130813.3696005-2-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240328130813.3696005-2-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240328130813.3696005-2-maxime.coquelin@redhat.com", "date": "2024-03-28T13:08:10", "name": "[v2,1/4] net/virtio-user: rename queue iterator", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e1eb1d79544afcfee1ac4c0784279c9f83d75f0e", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240328130813.3696005-2-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 31637, "url": "http://patches.dpdk.org/api/series/31637/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31637", "date": "2024-03-28T13:08:09", "name": "Virtio-user queues setup fixes", "version": 2, "mbox": "http://patches.dpdk.org/series/31637/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138955/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138955/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D7BAF43D6C;\n\tThu, 28 Mar 2024 14:08:52 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0E794427D7;\n\tThu, 28 Mar 2024 14:08:36 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id DFF0341144\n for <dev@dpdk.org>; Thu, 28 Mar 2024 14:08:34 +0100 (CET)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-60-1a_JOoEQPTWgaJHKe-NsMg-1; Thu, 28 Mar 2024 09:08:31 -0400", "from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com\n [10.11.54.10])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B616B80FAE4;\n Thu, 28 Mar 2024 13:08:23 +0000 (UTC)", "from max-p1.redhat.com (unknown [10.39.208.26])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 0455A492BD0;\n Thu, 28 Mar 2024 13:08:21 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1711631314;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=tlkgagNfOx55GYlEWV5qajJcL6HD3V1SKEah2NHAuGg=;\n b=XOuBBWRn0xjS6n65XduocbLt/1PCqWzt728jfb7vo/B4i5VDiHGHNQHTVbqHqIKE7KSHqY\n WYlH3Elr3n6aOTzPJJH+h70froPzeIXwypJEpxwgD7uDsR/z459pyyBnsl3fo/dy/K2vQ1\n UPhKeA1IVLnUjjwGseLhgSJ7VVhtKAk=", "X-MC-Unique": "1a_JOoEQPTWgaJHKe-NsMg-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org,\n\tdavid.marchand@redhat.com,\n\tchenbox@nvidia.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH v2 1/4] net/virtio-user: rename queue iterator", "Date": "Thu, 28 Mar 2024 14:08:10 +0100", "Message-ID": "<20240328130813.3696005-2-maxime.coquelin@redhat.com>", "In-Reply-To": "<20240328130813.3696005-1-maxime.coquelin@redhat.com>", "References": "<20240328130813.3696005-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.10", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This is a preliminary rework to prepare for iterating\nover queues for non-setup operations.\n\nAlso, remove the error log that does not provide much\ninformation given the callbacks already provide one.\n\nAcked-by: David Marchand <david.marchand@redhat.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 13 +++++--------\n 1 file changed, 5 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 4fdfe70e7c..c3d44880f5 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -129,7 +129,7 @@ virtio_user_kick_queue(struct virtio_user_dev *dev, uint32_t queue_sel)\n }\n \n static int\n-virtio_user_queue_setup(struct virtio_user_dev *dev,\n+virtio_user_foreach_queue(struct virtio_user_dev *dev,\n \t\t\tint (*fn)(struct virtio_user_dev *, uint32_t))\n {\n \tuint32_t i, nr_vq;\n@@ -138,12 +138,9 @@ virtio_user_queue_setup(struct virtio_user_dev *dev,\n \tif (dev->hw_cvq)\n \t\tnr_vq++;\n \n-\tfor (i = 0; i < nr_vq; i++) {\n-\t\tif (fn(dev, i) < 0) {\n-\t\t\tPMD_DRV_LOG(ERR, \"(%s) setup VQ %u failed\", dev->path, i);\n+\tfor (i = 0; i < nr_vq; i++)\n+\t\tif (fn(dev, i) < 0)\n \t\t\treturn -1;\n-\t\t}\n-\t}\n \n \treturn 0;\n }\n@@ -157,7 +154,7 @@ virtio_user_dev_set_features(struct virtio_user_dev *dev)\n \tpthread_mutex_lock(&dev->mutex);\n \n \t/* Step 0: tell vhost to create queues */\n-\tif (virtio_user_queue_setup(dev, virtio_user_create_queue) < 0)\n+\tif (virtio_user_foreach_queue(dev, virtio_user_create_queue) < 0)\n \t\tgoto error;\n \n \tfeatures = dev->features;\n@@ -205,7 +202,7 @@ virtio_user_start_device(struct virtio_user_dev *dev)\n \t\tgoto error;\n \n \t/* Step 3: kick queues */\n-\tret = virtio_user_queue_setup(dev, virtio_user_kick_queue);\n+\tret = virtio_user_foreach_queue(dev, virtio_user_kick_queue);\n \tif (ret < 0)\n \t\tgoto error;\n \n", "prefixes": [ "v2", "1/4" ] }