Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138947/?format=api
{ "id": 138947, "url": "http://patches.dpdk.org/api/patches/138947/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240327233001.83505-12-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240327233001.83505-12-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240327233001.83505-12-stephen@networkplumber.org", "date": "2024-03-27T23:28:34", "name": "[v17,11/15] log: add hook for printing log messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b0dac51056037de6cb9b6c1c1e99531e4abef1e9", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240327233001.83505-12-stephen@networkplumber.org/mbox/", "series": [ { "id": 31635, "url": "http://patches.dpdk.org/api/series/31635/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31635", "date": "2024-03-27T23:28:23", "name": "Logging unification and improvements", "version": 17, "mbox": "http://patches.dpdk.org/series/31635/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138947/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138947/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 475B343D5B;\n\tThu, 28 Mar 2024 00:31:23 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E19D042D8C;\n\tThu, 28 Mar 2024 00:30:29 +0100 (CET)", "from mail-pg1-f178.google.com (mail-pg1-f178.google.com\n [209.85.215.178])\n by mails.dpdk.org (Postfix) with ESMTP id 5031A427DF\n for <dev@dpdk.org>; Thu, 28 Mar 2024 00:30:21 +0100 (CET)", "by mail-pg1-f178.google.com with SMTP id\n 41be03b00d2f7-5d42e7ab8a9so216016a12.3\n for <dev@dpdk.org>; Wed, 27 Mar 2024 16:30:21 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n n15-20020a170902e54f00b001e0fdc6e4ebsm80772plf.175.2024.03.27.16.30.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 27 Mar 2024 16:30:20 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711582220;\n x=1712187020; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zu4Y35qfKTRMkWDem+dq2ZFz0NT/aAm4UNjlX7qaan4=;\n b=LykAprlzC2mqe+P5k2QToJ9gepY1jqqzMHFXDfWK8gn40Wb75EVv3Q4wT0ICSejsnC\n oNN3nxezzWOmLJaTPVRE4A+cENm/bz9SKQX7gqzRz7Af39JZHmGbrVUekwO9uIGBX0+g\n 4o7I3yXUATpXVVgzL2FcgKprXgGgryEA7Ylq3v6Zf+l7Gg4nryXNPKTa4i4v9Z2qWs41\n /ZB6+zSlKAt7gnly7lgVEicOSL08MRgHOguRuzIa7SN68Uszz6SP5+1RS8Z6/0qZJ+3B\n MQz5if7k9INtpXcxcSZ+P3bO7pZh6ESMr51Z00CFrKnzwzL6ZnWCm/GDf+I5Lt+FBhdS\n D6gA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711582220; x=1712187020;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=zu4Y35qfKTRMkWDem+dq2ZFz0NT/aAm4UNjlX7qaan4=;\n b=LQngUFPg+ucX1+3f68D42nTUjhMkKJJZQ1vJmAzgwNcv3g7Oi1tl/CN76khC/qRxY+\n BkL521VdWJCAcS/x9pY/paBtOc1AsmNI+OkNfXATzUMGlfnuCLSniPnNgSLNsM5hwVYE\n odchwaWiE+2pO6biGg9075Nl6j0aelmvNCfV9iFUExoOC46gY6OF2aSIiONTLHLNSLFj\n FHCoEn1RAFmQdPBGFLS3XlLeKUwL5oXaRVkcjbZMlTvykDoxlk/Haj0AT8mV4m7SLS83\n 75BRxE0nAFNRAM/6Sfcs37Z2h7Jv+wVUmBozF5LzLm8NmoBwRtoAJPIHJM3hYacuWkij\n dnWg==", "X-Gm-Message-State": "AOJu0YyIS9tA8qkOJ2gn05c4SqT5NYeEe5GmpdLdBvd52khZPqqCRGaD\n /qxyEPXFF+skz69ZF3hoNrA3jYokcRbqor/lseGeuu8yEW49OArR2xmHj2tr1IdXlvUTKir+NwN\n j", "X-Google-Smtp-Source": "\n AGHT+IG7vD0pIVqBn0UhBgwWi1/nmWO6ctlzwGMlrhdoZfxSggvDQ56Rx4MEp/zSasAVx8Ln/X46Og==", "X-Received": "by 2002:a05:6a20:c702:b0:1a3:3c5f:2ebd with SMTP id\n hi2-20020a056a20c70200b001a33c5f2ebdmr1830831pzb.59.1711582220528;\n Wed, 27 Mar 2024 16:30:20 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v17 11/15] log: add hook for printing log messages", "Date": "Wed, 27 Mar 2024 16:28:34 -0700", "Message-ID": "<20240327233001.83505-12-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240327233001.83505-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240327233001.83505-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This is useful for when decorating log output for console\nor journal. Provide basic version in this patch.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/log/log.c | 17 ++++++++++++++++-\n 1 file changed, 16 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/log/log.c b/lib/log/log.c\nindex f597da2e39..acd4c320b6 100644\n--- a/lib/log/log.c\n+++ b/lib/log/log.c\n@@ -26,16 +26,21 @@ struct rte_log_dynamic_type {\n \tuint32_t loglevel;\n };\n \n+typedef int (*log_print_t)(FILE *f, uint32_t level, const char *fmt, va_list ap);\n+static int log_print(FILE *f, uint32_t level, const char *format, va_list ap);\n+\n /** The rte_log structure. */\n static struct rte_logs {\n \tuint32_t type; /**< Bitfield with enabled logs. */\n \tuint32_t level; /**< Log level. */\n \tFILE *file; /**< Output file set by rte_openlog_stream, or NULL. */\n+\tlog_print_t print_func;\n \tsize_t dynamic_types_len;\n \tstruct rte_log_dynamic_type *dynamic_types;\n } rte_logs = {\n \t.type = UINT32_MAX,\n \t.level = RTE_LOG_DEBUG,\n+\t.print_func = log_print,\n };\n \n struct rte_eal_opt_loglevel {\n@@ -78,6 +83,7 @@ rte_openlog_stream(FILE *f)\n \t\tfclose(rte_logs.file);\n \n \trte_logs.file = f;\n+\trte_logs.print_func = log_print;\n \treturn 0;\n }\n \n@@ -484,7 +490,7 @@ rte_vlog(uint32_t level, uint32_t logtype, const char *format, va_list ap)\n \tRTE_PER_LCORE(log_cur_msg).loglevel = level;\n \tRTE_PER_LCORE(log_cur_msg).logtype = logtype;\n \n-\tret = vfprintf(f, format, ap);\n+\tret = (*rte_logs.print_func)(f, level, format, ap);\n \tfflush(f);\n \treturn ret;\n }\n@@ -513,6 +519,15 @@ eal_log_syslog(const char *mode __rte_unused)\n \treturn -1;\n }\n \n+/* default log print function */\n+__rte_format_printf(3, 0)\n+static int\n+log_print(FILE *f, uint32_t level __rte_unused,\n+\t const char *format, va_list ap)\n+{\n+\treturn vfprintf(f, format, ap);\n+}\n+\n /*\n * Called by rte_eal_init\n */\n", "prefixes": [ "v17", "11/15" ] }