Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138943/?format=api
{ "id": 138943, "url": "http://patches.dpdk.org/api/patches/138943/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240327233001.83505-8-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240327233001.83505-8-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240327233001.83505-8-stephen@networkplumber.org", "date": "2024-03-27T23:28:30", "name": "[v17,07/15] eal: change rte_exit() output to match rte_log()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fbc4ae53bc33cc48298d44fab2e03865203ac018", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240327233001.83505-8-stephen@networkplumber.org/mbox/", "series": [ { "id": 31635, "url": "http://patches.dpdk.org/api/series/31635/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31635", "date": "2024-03-27T23:28:23", "name": "Logging unification and improvements", "version": 17, "mbox": "http://patches.dpdk.org/series/31635/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138943/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138943/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7142843D5B;\n\tThu, 28 Mar 2024 00:30:58 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EE43B42D6A;\n\tThu, 28 Mar 2024 00:30:24 +0100 (CET)", "from mail-pl1-f181.google.com (mail-pl1-f181.google.com\n [209.85.214.181])\n by mails.dpdk.org (Postfix) with ESMTP id D3643410E6\n for <dev@dpdk.org>; Thu, 28 Mar 2024 00:30:17 +0100 (CET)", "by mail-pl1-f181.google.com with SMTP id\n d9443c01a7336-1e0d82c529fso3705055ad.2\n for <dev@dpdk.org>; Wed, 27 Mar 2024 16:30:17 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n n15-20020a170902e54f00b001e0fdc6e4ebsm80772plf.175.2024.03.27.16.30.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 27 Mar 2024 16:30:16 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711582217;\n x=1712187017; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=z1Ss/Jo5pzxKGB7DFQyYr6zCqpXokQnGKUO4mVGS4XE=;\n b=mUx/umw1WlMHQUSNFOA0WOK/h8SqrhyWxfDhLLHNiJLBIvl8jCYpcvZFJe1vt5BfWZ\n G2qSUHM0ANLNlOXUPeWz7oFe/yt0MqLMMFt1WtQa8FU/1kg26x6cQOPllv9vuB1KfrG0\n Pk/Ad9V5ObJOrv8fSG8+rIA/gdqMr2Oob0jqNdYfJN8OCZUhnRSLdyq+kJwLK+O+Jqv5\n xXX27zb/I1H7UflwjT+/xWh66nMY8N7EpybYeg1nU+9pIIrE4QxpIzonEzV7kqXfu4LJ\n wiuuX/FJXNoa3TLnSnw9FOFIUm/e9D+z4vMKNRWEe1I4kJ4ORuMwvoo2Wym+4KDIjqIC\n bMMA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711582217; x=1712187017;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=z1Ss/Jo5pzxKGB7DFQyYr6zCqpXokQnGKUO4mVGS4XE=;\n b=jQvcowQyWb6Vi7uQxXb1z+LJjhb8LCxiNTIfJlb1YRqyYSurbRb653vPX5l8Y3tVRn\n feJgdAcDr8J1TaZrKht0s8NZW1cXDMD3t7VMECp/uWpq1YcthX0Y6iFxNFISjv1jOMUq\n kQwQznYg1PqdH5kyp8tJzLkAJOEQPykXfAlDw5IfUKHlq8kiU4xIfsjxBetnJ5DWjM35\n bHzidyZUKOA3sX5+ySxyLUjhyOxN1WIl9sfc63SYezId3XN4d2hq6D+V18Z3N3Fq7Plm\n l/2hHWHpsae3CEsJmmipCqCU7KLX9jZ+mJBRtpJWm0H3LpT99Kg9ylwOsZpH17ha/tCE\n NY2g==", "X-Gm-Message-State": "AOJu0YwApM8Lw5APJkNJMHeYKdezcIBzdO/RqAuLhXe3YZKbAkRKjRcv\n HY4IrDxEVRcaXmVTFOECi+EeOSh1TjYhfSx0RlEKx1sXIOHA+Mg9tKL1p8myMRXLy5CRKEjpZt5\n 4", "X-Google-Smtp-Source": "\n AGHT+IFc1oAxb9dwsdg7Jxp4wRT5zcgPmCkqeTZFZe0KPSKa5Awobim3LfSpHzgJ5q4JhG4D6BHORg==", "X-Received": "by 2002:a17:903:2406:b0:1dd:7da:e0a9 with SMTP id\n e6-20020a170903240600b001dd07dae0a9mr1457487plo.69.1711582217031;\n Wed, 27 Mar 2024 16:30:17 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v17 07/15] eal: change rte_exit() output to match rte_log()", "Date": "Wed, 27 Mar 2024 16:28:30 -0700", "Message-ID": "<20240327233001.83505-8-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240327233001.83505-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240327233001.83505-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The rte_exit() output format confuses the timestamp and coloring\noptions. Change it to use be a single line with proper prefix.\n\nBefore:\n[ 0.006481] EAL: Error - exiting with code: 1\n Cause: [ 0.006489] Cannot init EAL: Permission denied\n\nAfter:\n[ 0.006238] EAL: Error - exiting with code: 1\n[ 0.006250] EAL: Cause - Cannot init EAL: Permission denied\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/common/eal_common_debug.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_debug.c b/lib/eal/common/eal_common_debug.c\nindex 3e77995896..ad2be63cbb 100644\n--- a/lib/eal/common/eal_common_debug.c\n+++ b/lib/eal/common/eal_common_debug.c\n@@ -34,17 +34,18 @@ void\n rte_exit(int exit_code, const char *format, ...)\n {\n \tva_list ap;\n+\tchar msg[256];\n \n \tif (exit_code != 0)\n-\t\tRTE_LOG(CRIT, EAL, \"Error - exiting with code: %d\\n\"\n-\t\t\t\t\" Cause: \", exit_code);\n+\t\tEAL_LOG(CRIT, \"Error - exiting with code: %d\", exit_code);\n \n \tva_start(ap, format);\n-\trte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap);\n+\tvsnprintf(msg, sizeof(msg), format, ap);\n \tva_end(ap);\n \n+\trte_log(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, \"EAL: Cause - %s\", msg);\n+\n \tif (rte_eal_cleanup() != 0 && rte_errno != EALREADY)\n-\t\tEAL_LOG(CRIT,\n-\t\t\t\"EAL could not release all resources\");\n+\t\tEAL_LOG(CRIT, \"EAL could not release all resources\");\n \texit(exit_code);\n }\n", "prefixes": [ "v17", "07/15" ] }