Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138935/?format=api
{ "id": 138935, "url": "http://patches.dpdk.org/api/patches/138935/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1711580958-20808-12-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1711580958-20808-12-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1711580958-20808-12-git-send-email-roretzla@linux.microsoft.com", "date": "2024-03-27T23:09:14", "name": "[v2,11/15] net/mlx5: pack structures when building with MSVC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "cb4cb55b7fbfd221e86f53d504a04d1a7e319fab", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1711580958-20808-12-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31634, "url": "http://patches.dpdk.org/api/series/31634/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31634", "date": "2024-03-27T23:09:03", "name": "fix packing of structs when building with MSVC", "version": 2, "mbox": "http://patches.dpdk.org/series/31634/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138935/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138935/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DAD9243D5B;\n\tThu, 28 Mar 2024 00:10:42 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 74C0D42DB4;\n\tThu, 28 Mar 2024 00:09:41 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 57B5F410FC\n for <dev@dpdk.org>; Thu, 28 Mar 2024 00:09:21 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id CC62C20E6ACA; Wed, 27 Mar 2024 16:09:19 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com CC62C20E6ACA", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1711580959;\n bh=b8K15zDL4DfHaMM+UJbBWd+7iLlta4TID5ATz0iGua8=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=gXM5mG74bxE7swZQJTigxJeIZknm9VwKxgFXd/gAtF96xkNq9NmbSgZQ7ngWLVsVb\n Y++LjbODu8NDX3tost6UYGAnhbNadsVFGjfFxfRhDBjBrmtTT+N5dond4FY3gxxyru\n nwEbeJvHRDpLN/zjqI/xml6Il/L88ZQk15ZTE/H0=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Akhil Goyal <gakhil@marvell.com>, Aman Singh <aman.deep.singh@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Byron Marohn <byron.marohn@intel.com>, Conor Walsh <conor.walsh@intel.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n David Hunt <david.hunt@intel.com>, Jerin Jacob <jerinj@marvell.com>,\n Jingjing Wu <jingjing.wu@intel.com>,\n Kirill Rybalchenko <kirill.rybalchenko@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Radu Nicolau <radu.nicolau@intel.com>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Vamsi Attunuru <vattunuru@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>,\n Yuying Zhang <yuying.zhang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v2 11/15] net/mlx5: pack structures when building with MSVC", "Date": "Wed, 27 Mar 2024 16:09:14 -0700", "Message-Id": "<1711580958-20808-12-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1711580958-20808-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com>\n <1711580958-20808-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing\nwhen building with MSVC.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n drivers/net/mlx5/hws/mlx5dr.h | 1 +\n drivers/net/mlx5/mlx5.h | 1 +\n drivers/net/mlx5/mlx5_flow.h | 5 +++++\n drivers/net/mlx5/mlx5_hws_cnt.h | 1 +\n drivers/net/mlx5/mlx5_utils.h | 4 ++++\n 5 files changed, 12 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/hws/mlx5dr.h b/drivers/net/mlx5/hws/mlx5dr.h\nindex 80e118a..cd5bb05 100644\n--- a/drivers/net/mlx5/hws/mlx5dr.h\n+++ b/drivers/net/mlx5/hws/mlx5dr.h\n@@ -300,6 +300,7 @@ struct mlx5dr_action_dest_attr {\n \t};\n };\n \n+__rte_msvc_pack\n struct mlx5dr_crc_encap_entropy_hash_fields {\n \tunion mlx5dr_crc_encap_entropy_hash_ip_field dst;\n \tunion mlx5dr_crc_encap_entropy_hash_ip_field src;\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex 0091a24..6228ee8 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -221,6 +221,7 @@ struct mlx5_dev_spawn_data {\n }\n \n /** Data associated with socket messages. */\n+__rte_msvc_pack\n struct mlx5_flow_dump_req {\n \tuint32_t port_id; /**< There are plans in DPDK to extend port_id. */\n \tuint64_t flow_id;\ndiff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h\nindex 0065727..da0f8b7 100644\n--- a/drivers/net/mlx5/mlx5_flow.h\n+++ b/drivers/net/mlx5/mlx5_flow.h\n@@ -658,6 +658,7 @@ struct mlx5_flow_dv_tag_resource {\n };\n \n /* Modify resource structure */\n+__rte_msvc_pack\n struct mlx5_flow_dv_modify_hdr_resource {\n \tstruct mlx5_list_entry entry;\n \tvoid *action; /**< Modify header action object. */\n@@ -812,6 +813,7 @@ struct mlx5_flow_dv_dest_array_resource {\n \n \n /** Device flow handle structure for DV mode only. */\n+__rte_msvc_pack\n struct mlx5_flow_handle_dv {\n \t/* Flow DV api: */\n \tstruct mlx5_flow_dv_matcher *matcher; /**< Cache to matcher. */\n@@ -830,6 +832,7 @@ struct mlx5_flow_handle_dv {\n } __rte_packed;\n \n /** Device flow handle structure: used both for creating & destroying. */\n+__rte_msvc_pack\n struct mlx5_flow_handle {\n \tSILIST_ENTRY(uint32_t)next;\n \tstruct mlx5_vf_vlan vf_vlan; /**< Structure for VF VLAN workaround. */\n@@ -1231,6 +1234,7 @@ struct mlx5_flow_attr {\n };\n \n /* Flow structure. */\n+__rte_msvc_pack\n struct rte_flow {\n \tuint32_t dev_handles;\n \t/**< Device flow handles that are part of the flow. */\n@@ -1304,6 +1308,7 @@ enum {\n #endif\n \n /** HWS flow struct. */\n+__rte_msvc_pack\n struct rte_flow_hw {\n \t/** The table flow allcated from. */\n \tstruct rte_flow_template_table *table;\ndiff --git a/drivers/net/mlx5/mlx5_hws_cnt.h b/drivers/net/mlx5/mlx5_hws_cnt.h\nindex e005960..1f53a1a 100644\n--- a/drivers/net/mlx5/mlx5_hws_cnt.h\n+++ b/drivers/net/mlx5/mlx5_hws_cnt.h\n@@ -133,6 +133,7 @@ enum {\n };\n \n /* HWS counter age parameter. */\n+__rte_msvc_pack\n struct mlx5_hws_age_param {\n \tuint32_t timeout; /* Aging timeout in seconds (atomically accessed). */\n \tuint32_t sec_since_last_hit;\ndiff --git a/drivers/net/mlx5/mlx5_utils.h b/drivers/net/mlx5/mlx5_utils.h\nindex f3c0d76..cf80e5e 100644\n--- a/drivers/net/mlx5/mlx5_utils.h\n+++ b/drivers/net/mlx5/mlx5_utils.h\n@@ -118,6 +118,7 @@ struct mlx5_l3t_level_tbl {\n };\n \n /* L3 word entry table data structure. */\n+__rte_msvc_pack\n struct mlx5_l3t_entry_word {\n \tuint32_t idx; /* Table index. */\n \tuint64_t ref_cnt; /* Table ref_cnt. */\n@@ -128,6 +129,7 @@ struct mlx5_l3t_entry_word {\n } __rte_packed;\n \n /* L3 double word entry table data structure. */\n+__rte_msvc_pack\n struct mlx5_l3t_entry_dword {\n \tuint32_t idx; /* Table index. */\n \tuint64_t ref_cnt; /* Table ref_cnt. */\n@@ -138,6 +140,7 @@ struct mlx5_l3t_entry_dword {\n } __rte_packed;\n \n /* L3 quad word entry table data structure. */\n+__rte_msvc_pack\n struct mlx5_l3t_entry_qword {\n \tuint32_t idx; /* Table index. */\n \tuint64_t ref_cnt; /* Table ref_cnt. */\n@@ -148,6 +151,7 @@ struct mlx5_l3t_entry_qword {\n } __rte_packed;\n \n /* L3 pointer entry table data structure. */\n+__rte_msvc_pack\n struct mlx5_l3t_entry_ptr {\n \tuint32_t idx; /* Table index. */\n \tuint64_t ref_cnt; /* Table ref_cnt. */\n", "prefixes": [ "v2", "11/15" ] }