Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138933/?format=api
{ "id": 138933, "url": "http://patches.dpdk.org/api/patches/138933/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1711580958-20808-10-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1711580958-20808-10-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1711580958-20808-10-git-send-email-roretzla@linux.microsoft.com", "date": "2024-03-27T23:09:12", "name": "[v2,09/15] net/iavf: pack structures when building with MSVC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7fd1fa51fc6d963b51674f011f53e35f5a65f2de", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1711580958-20808-10-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31634, "url": "http://patches.dpdk.org/api/series/31634/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31634", "date": "2024-03-27T23:09:03", "name": "fix packing of structs when building with MSVC", "version": 2, "mbox": "http://patches.dpdk.org/series/31634/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138933/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138933/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5D51643D5B;\n\tThu, 28 Mar 2024 00:10:32 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DEC3542DA3;\n\tThu, 28 Mar 2024 00:09:38 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 3D205410EA\n for <dev@dpdk.org>; Thu, 28 Mar 2024 00:09:21 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id ADFBE20E695F; Wed, 27 Mar 2024 16:09:19 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com ADFBE20E695F", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1711580959;\n bh=1H9Z4GJTk+mQFUXDeRVs2qv3Nnpyn89EB1Wy+4ojCo0=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=F8rZKY0jKxZld+Yp3OJS3ehfm0kKC2UZ516N4wXmlM7MuySeZqsHg9VMU51oHFp2S\n eHcr/IEZRI5V4VamzMTu/FKkhTwI63EeBgkVJrZd5e7xhJcOdCdTPFJ6eACsZFSdmX\n 1JxbMHVsC7DNh+X8yWbB4fU65i575jIMSZshoG6g=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Akhil Goyal <gakhil@marvell.com>, Aman Singh <aman.deep.singh@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Byron Marohn <byron.marohn@intel.com>, Conor Walsh <conor.walsh@intel.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n David Hunt <david.hunt@intel.com>, Jerin Jacob <jerinj@marvell.com>,\n Jingjing Wu <jingjing.wu@intel.com>,\n Kirill Rybalchenko <kirill.rybalchenko@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Radu Nicolau <radu.nicolau@intel.com>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Vamsi Attunuru <vattunuru@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>,\n Yuying Zhang <yuying.zhang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v2 09/15] net/iavf: pack structures when building with MSVC", "Date": "Wed, 27 Mar 2024 16:09:12 -0700", "Message-Id": "<1711580958-20808-10-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1711580958-20808-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com>\n <1711580958-20808-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing\nwhen building with MSVC.\n\nRemove __rte_packed where it appears natural alignment without\npacking would produce the same layout or the struct is internal.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n drivers/net/iavf/iavf_ipsec_crypto.h | 4 +++-\n drivers/net/iavf/iavf_rxtx.c | 2 +-\n 2 files changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ipsec_crypto.h b/drivers/net/iavf/iavf_ipsec_crypto.h\nindex 49f9202..0637ce2 100644\n--- a/drivers/net/iavf/iavf_ipsec_crypto.h\n+++ b/drivers/net/iavf/iavf_ipsec_crypto.h\n@@ -11,12 +11,14 @@\n \n \n \n+__rte_msvc_pack\n struct iavf_tx_ipsec_desc {\n \tunion {\n \t\tstruct {\n \t\t\t__le64 qw0;\n \t\t\t__le64 qw1;\n \t\t};\n+\t\t__rte_msvc_pack\n \t\tstruct {\n \t\t\t__le16 l4payload_length;\n \t\t\t__le32 esn;\n@@ -97,7 +99,7 @@ struct iavf_ipsec_crypto_pkt_metadata {\n \tuint8_t next_proto;\t\t/* Next Protocol (8b/1B) */\n \n \tuint32_t esn;\t\t /* Extended Sequence Number (32b/4B) */\n-} __rte_packed;\n+};\n \n /**\n * Inline IPsec Crypto offload is supported\ndiff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c\nindex 0a5246d..61309c3 100644\n--- a/drivers/net/iavf/iavf_rxtx.c\n+++ b/drivers/net/iavf/iavf_rxtx.c\n@@ -53,7 +53,7 @@\n struct simple_gre_hdr {\n \tuint16_t flags;\n \tuint16_t proto;\n-} __rte_packed;\n+};\n \n /* structure that caches offload info for the current packet */\n struct offload_info {\n", "prefixes": [ "v2", "09/15" ] }