Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138925/?format=api
{ "id": 138925, "url": "http://patches.dpdk.org/api/patches/138925/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1711580958-20808-5-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1711580958-20808-5-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1711580958-20808-5-git-send-email-roretzla@linux.microsoft.com", "date": "2024-03-27T23:09:07", "name": "[v2,04/15] common/iavf: pack structures when building with MSVC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "92aaa0bc76c7381b8cb10ac71f1c1c4aa3bd4489", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1711580958-20808-5-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31634, "url": "http://patches.dpdk.org/api/series/31634/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31634", "date": "2024-03-27T23:09:03", "name": "fix packing of structs when building with MSVC", "version": 2, "mbox": "http://patches.dpdk.org/series/31634/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138925/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138925/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 600DA43D5B;\n\tThu, 28 Mar 2024 00:09:43 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0AD8E41151;\n\tThu, 28 Mar 2024 00:09:26 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 3FAFF40EE3\n for <dev@dpdk.org>; Thu, 28 Mar 2024 00:09:20 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 62AC120E6940; Wed, 27 Mar 2024 16:09:19 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 62AC120E6940", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1711580959;\n bh=vlaWpD6eQhjJAAAnq4XOEGcsLTHA5jfWElbk++Td5tg=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=grEIZCFvp8nTL2hhDis8H8U0SQYXMXoS8vly8RqzpiyEq9JoeULtI35pwKVkAi7Ow\n OB1XWFWiGcRlGM6IfO1NP3unsGM8duMemFG4DCAf7kZzCcWQUUc2KN0h68vobJXwEQ\n yWGdXRMuAiOk8oQOJeEX5Q2+k6Z+z7onqPgrUyIw=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Akhil Goyal <gakhil@marvell.com>, Aman Singh <aman.deep.singh@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Byron Marohn <byron.marohn@intel.com>, Conor Walsh <conor.walsh@intel.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n David Hunt <david.hunt@intel.com>, Jerin Jacob <jerinj@marvell.com>,\n Jingjing Wu <jingjing.wu@intel.com>,\n Kirill Rybalchenko <kirill.rybalchenko@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Radu Nicolau <radu.nicolau@intel.com>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Vamsi Attunuru <vattunuru@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>,\n Yuying Zhang <yuying.zhang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v2 04/15] common/iavf: pack structures when building with MSVC", "Date": "Wed, 27 Mar 2024 16:09:07 -0700", "Message-Id": "<1711580958-20808-5-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1711580958-20808-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com>\n <1711580958-20808-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing\nwhen building with MSVC.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n drivers/common/iavf/iavf_osdep.h | 2 ++\n drivers/common/iavf/virtchnl_inline_ipsec.h | 11 +++++++++++\n 2 files changed, 13 insertions(+)", "diff": "diff --git a/drivers/common/iavf/iavf_osdep.h b/drivers/common/iavf/iavf_osdep.h\nindex 263d924..1fb057c 100644\n--- a/drivers/common/iavf/iavf_osdep.h\n+++ b/drivers/common/iavf/iavf_osdep.h\n@@ -158,6 +158,7 @@\n } while (0)\n \n /* memory allocation tracking */\n+__rte_msvc_pack\n struct iavf_dma_mem {\n \tvoid *va;\n \tu64 pa;\n@@ -165,6 +166,7 @@ struct iavf_dma_mem {\n \tconst void *zone;\n } __rte_packed;\n \n+__rte_msvc_pack\n struct iavf_virt_mem {\n \tvoid *va;\n \tu32 size;\ndiff --git a/drivers/common/iavf/virtchnl_inline_ipsec.h b/drivers/common/iavf/virtchnl_inline_ipsec.h\nindex 2f4bf15..feb0f44 100644\n--- a/drivers/common/iavf/virtchnl_inline_ipsec.h\n+++ b/drivers/common/iavf/virtchnl_inline_ipsec.h\n@@ -109,6 +109,7 @@ enum inline_ipsec_ops {\n };\n \n /* Not all valid, if certain field is invalid, set 1 for all bits */\n+__rte_msvc_pack\n struct virtchnl_algo_cap {\n \tu32 algo_type;\n \n@@ -132,6 +133,7 @@ struct virtchnl_algo_cap {\n } __rte_packed;\n \n /* vf record the capability of crypto from the virtchnl */\n+__rte_msvc_pack\n struct virtchnl_sym_crypto_cap {\n \tu8 crypto_type;\n \tu8 algo_cap_num;\n@@ -142,6 +144,7 @@ struct virtchnl_sym_crypto_cap {\n * VF pass virtchnl_ipsec_cap to PF\n * and PF return capability of ipsec from virtchnl.\n */\n+__rte_msvc_pack\n struct virtchnl_ipsec_cap {\n \t/* max number of SA per VF */\n \tu16 max_sa_num;\n@@ -172,6 +175,7 @@ struct virtchnl_ipsec_cap {\n } __rte_packed;\n \n /* configuration of crypto function */\n+__rte_msvc_pack\n struct virtchnl_ipsec_crypto_cfg_item {\n \tu8 crypto_type;\n \n@@ -203,6 +207,7 @@ struct virtchnl_ipsec_sym_crypto_cfg {\n * PF create SA as configuration and PF driver will return\n * an unique index (sa_idx) for the created SA.\n */\n+__rte_msvc_pack\n struct virtchnl_ipsec_sa_cfg {\n \t/* IPsec SA Protocol - AH/ESP */\n \tu8 virtchnl_protocol_type;\n@@ -298,6 +303,7 @@ struct virtchnl_ipsec_sa_cfg {\n * VF send configuration of index of SA to PF\n * PF will update SA according to configuration\n */\n+__rte_msvc_pack\n struct virtchnl_ipsec_sa_update {\n \tu32 sa_index; /* SA to update */\n \tu32 esn_hi; /* high 32 bits of esn */\n@@ -310,6 +316,7 @@ struct virtchnl_ipsec_sa_update {\n * flag bitmap indicate all SA or just selected SA will\n * be destroyed\n */\n+__rte_msvc_pack\n struct virtchnl_ipsec_sa_destroy {\n \t/* All zero bitmap indicates all SA will be destroyed.\n \t * Non-zero bitmap indicates the selected SA in\n@@ -325,6 +332,7 @@ struct virtchnl_ipsec_sa_destroy {\n * VF send this SA configuration to PF using virtchnl;\n * PF read SA and will return configuration for the created SA.\n */\n+__rte_msvc_pack\n struct virtchnl_ipsec_sa_read {\n \t/* SA valid - invalid/valid */\n \tu8 valid;\n@@ -431,6 +439,7 @@ struct virtchnl_ipsec_sa_read {\n #define VIRTCHNL_IPSEC_INBOUND_SPD_TBL_IPV6\t(1)\n \n /* Add allowlist entry in IES */\n+__rte_msvc_pack\n struct virtchnl_ipsec_sp_cfg {\n \tu32 spi;\n \tu32 dip[4];\n@@ -459,6 +468,7 @@ struct virtchnl_ipsec_sp_cfg {\n \n \n /* Delete allowlist entry in IES */\n+__rte_msvc_pack\n struct virtchnl_ipsec_sp_destroy {\n \t/* 0 for IPv4 table, 1 for IPv6 table. */\n \tu8 table_id;\n@@ -494,6 +504,7 @@ struct virtchnl_ipsec_resp {\n };\n \n /* Internal message descriptor for VF <-> IPsec communication */\n+__rte_msvc_pack\n struct inline_ipsec_msg {\n \tu16 ipsec_opcode;\n \tu16 req_id;\n", "prefixes": [ "v2", "04/15" ] }