Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138876/?format=api
{ "id": 138876, "url": "http://patches.dpdk.org/api/patches/138876/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1711569406-7750-4-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1711569406-7750-4-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1711569406-7750-4-git-send-email-roretzla@linux.microsoft.com", "date": "2024-03-27T19:56:45", "name": "[v8,3/4] security: remove rte marker fields", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c97a40e8863ad00ee70adca89d85cdab42505aaf", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1711569406-7750-4-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31632, "url": "http://patches.dpdk.org/api/series/31632/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31632", "date": "2024-03-27T19:56:43", "name": "remove use of RTE_MARKER fields in libraries", "version": 8, "mbox": "http://patches.dpdk.org/series/31632/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138876/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138876/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6900743D0E;\n\tWed, 27 Mar 2024 20:57:11 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 00DC642686;\n\tWed, 27 Mar 2024 20:56:55 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 49E8C410E3\n for <dev@dpdk.org>; Wed, 27 Mar 2024 20:56:49 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 48E8D20E61C0; Wed, 27 Mar 2024 12:56:48 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 48E8D20E61C0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1711569408;\n bh=uCtPz4kTjzN8zkGzGj/Q8xFul4bjpLiRgiWXEWoAEAY=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=PpO6BnOQMdmqoyHF4JGLxex0lGKBT7Z53HqgNEYlesOCID3bdjmfGBoQ4lktF4KY3\n Mjl1mCZlay+GbBrDcMW+NNRmyWhkyvISjzdgKC/VUYfCAaxhpry8mA0ctlUQgXpzdC\n RVj5XDEh7txNSuj+TU2Y14wPlQKjIV61sqKOUBic=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Andrew Boyer <andrew.boyer@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chenbo Xia <chenbox@nvidia.com>, Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n Hyong Youb Kim <hyonkim@cisco.com>, Jerin Jacob <jerinj@marvell.com>,\n Jie Hai <haijie1@huawei.com>, Jingjing Wu <jingjing.wu@intel.com>,\n John Daley <johndale@cisco.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>, Ori Kam <orika@nvidia.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Satha Rao <skoteshwar@marvell.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v8 3/4] security: remove rte marker fields", "Date": "Wed, 27 Mar 2024 12:56:45 -0700", "Message-Id": "<1711569406-7750-4-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1711569406-7750-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com>\n <1711569406-7750-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove\nRTE_MARKER fields from rte_mbuf struct.\n\nMaintain alignment of fields after removed cacheline1 marker by placing\nC11 alignas(RTE_CACHE_LINE_MIN_SIZE).\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nReviewed-by: Morten Brørup <mb@smartsharesystems.com>\n---\n doc/guides/rel_notes/release_24_03.rst | 3 +++\n lib/security/rte_security_driver.h | 5 +++--\n 2 files changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst\nindex a82bb4f..83ceea7 100644\n--- a/doc/guides/rel_notes/release_24_03.rst\n+++ b/doc/guides/rel_notes/release_24_03.rst\n@@ -219,6 +219,9 @@ Removed Items\n * mbuf: ``RTE_MARKER`` fields ``cacheline0`` and ``cacheline1``\n have been removed from ``struct rte_mbuf``.\n \n+* security: ``RTE_MARKER`` fields ``cacheline0`` and ``cacheline1``\n+ have been removed from ``struct rte_security_session``.\n+\n API Changes\n -----------\n \ndiff --git a/lib/security/rte_security_driver.h b/lib/security/rte_security_driver.h\nindex 09829ab..18a1e3c 100644\n--- a/lib/security/rte_security_driver.h\n+++ b/lib/security/rte_security_driver.h\n@@ -12,6 +12,8 @@\n * RTE Security Common Definitions\n */\n \n+#include <stdalign.h>\n+\n #ifdef __cplusplus\n extern \"C\" {\n #endif\n@@ -24,7 +26,6 @@\n * Security session to be used by library for internal usage\n */\n struct rte_security_session {\n-\tRTE_MARKER cacheline0;\n \tuint64_t opaque_data;\n \t/**< Opaque user defined data */\n \tuint64_t fast_mdata;\n@@ -32,7 +33,7 @@ struct rte_security_session {\n \trte_iova_t driver_priv_data_iova;\n \t/**< session private data IOVA address */\n \n-\talignas(RTE_CACHE_LINE_MIN_SIZE) RTE_MARKER cacheline1;\n+\talignas(RTE_CACHE_LINE_MIN_SIZE)\n \tuint8_t driver_priv_data[];\n \t/**< Private session material, variable size (depends on driver) */\n };\n", "prefixes": [ "v8", "3/4" ] }