Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138867/?format=api
http://patches.dpdk.org/api/patches/138867/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240327164726.68732-12-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240327164726.68732-12-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240327164726.68732-12-stephen@networkplumber.org", "date": "2024-03-27T16:45:29", "name": "[v16,11/15] log: add hook for printing log messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b0dac51056037de6cb9b6c1c1e99531e4abef1e9", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240327164726.68732-12-stephen@networkplumber.org/mbox/", "series": [ { "id": 31630, "url": "http://patches.dpdk.org/api/series/31630/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31630", "date": "2024-03-27T16:45:18", "name": "Logging unification and improvements", "version": 16, "mbox": "http://patches.dpdk.org/series/31630/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138867/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138867/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B8F1443D55;\n\tWed, 27 Mar 2024 17:48:56 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6BE7442DB1;\n\tWed, 27 Mar 2024 17:47:53 +0100 (CET)", "from mail-oa1-f43.google.com (mail-oa1-f43.google.com\n [209.85.160.43]) by mails.dpdk.org (Postfix) with ESMTP id 9AED7402A3\n for <dev@dpdk.org>; Wed, 27 Mar 2024 17:47:45 +0100 (CET)", "by mail-oa1-f43.google.com with SMTP id\n 586e51a60fabf-221e6bf537dso43410fac.1\n for <dev@dpdk.org>; Wed, 27 Mar 2024 09:47:45 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n a33-20020a056a0011e100b006e580678dfbsm5160873pfu.193.2024.03.27.09.47.44\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 27 Mar 2024 09:47:44 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711558065;\n x=1712162865; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zu4Y35qfKTRMkWDem+dq2ZFz0NT/aAm4UNjlX7qaan4=;\n b=hhEZrQqff+DqeHzMEIDJ7i2X7+Y6T1XoV12RpizGFDqKM/F+AVFhNF9/YmypapTmKg\n 9ZDCmlSM5mAreTMbb9EjpKDr/pfIV6VQgZNsbEJfhmgDjA88HVtI70hbQMwvGIV1kji2\n fSROAfAVgNgr5P2PtPpEFxP0mjkAZXGtE4yYTUfBJKTndh1nmTo47t4WgQoAlm6i1qmW\n E6QXM35XnQoMl2ZMmcRC/NFdgGFes/gWnz3thT1zhBlSqxcFndBeGHhX3+BUvz8v++Br\n HMMWpIi4X95J+UVY9tOmgaZ/yqerAEIylsmvBm52R/uWcBeMyr8MCSnbFPUiZEUNqI3r\n iV0A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711558065; x=1712162865;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=zu4Y35qfKTRMkWDem+dq2ZFz0NT/aAm4UNjlX7qaan4=;\n b=RycrDwhRZhjbwUF/Qrx1UQnxIPQ17WU/YFGDgtxMirg8Ix8O5L+5jx84hDAl6WqRze\n amdCFr3BP6/OVS+gKAfoFkq4sbr1BhVe0XfI46oSwK9nv9uwqs5YRFduia6UIZ5fH2Xr\n ugyhI6gARWuZ3pResyCYWhLeuOaLVnDsJt10FeH00Xp4pi0gpl0SdPJmXFgRSwMrseuM\n XCQOKUjRI44lixfZeMdnf2w0LrQG3Q7HmtoUAbEL5Qt4dEqcKg0fLFESWKv3g68jc6E1\n +sAZsZnx+oUriyEp9qJFGmVGQ5aD2HFoX7kfLW0zKVFB6dp5ziZ3wk3D8eyXsEfhznP/\n Hd2w==", "X-Gm-Message-State": "AOJu0YzqGDili440b+tw3lSgpvyQYjXftdkq5eqzI9PYlJUavsO344Nk\n c3Wjb5s8CMnMjfxgwW1O0x6CkVLHgod1ZbMa5BZrJl2FHYL4zaFkIPxcoaOnU0Gksqr13JaVxZm\n n", "X-Google-Smtp-Source": "\n AGHT+IF0GzXSD6Ugt4/Wv5LoLl+XYFF1ongDJv5ErEnyoi1mlOHATwalW8cCmK2dmtJrTssdr+TpTQ==", "X-Received": "by 2002:a05:6870:c14c:b0:22a:80e5:ccbe with SMTP id\n g12-20020a056870c14c00b0022a80e5ccbemr233672oad.20.1711558064843;\n Wed, 27 Mar 2024 09:47:44 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v16 11/15] log: add hook for printing log messages", "Date": "Wed, 27 Mar 2024 09:45:29 -0700", "Message-ID": "<20240327164726.68732-12-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240327164726.68732-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240327164726.68732-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This is useful for when decorating log output for console\nor journal. Provide basic version in this patch.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/log/log.c | 17 ++++++++++++++++-\n 1 file changed, 16 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/log/log.c b/lib/log/log.c\nindex f597da2e39..acd4c320b6 100644\n--- a/lib/log/log.c\n+++ b/lib/log/log.c\n@@ -26,16 +26,21 @@ struct rte_log_dynamic_type {\n \tuint32_t loglevel;\n };\n \n+typedef int (*log_print_t)(FILE *f, uint32_t level, const char *fmt, va_list ap);\n+static int log_print(FILE *f, uint32_t level, const char *format, va_list ap);\n+\n /** The rte_log structure. */\n static struct rte_logs {\n \tuint32_t type; /**< Bitfield with enabled logs. */\n \tuint32_t level; /**< Log level. */\n \tFILE *file; /**< Output file set by rte_openlog_stream, or NULL. */\n+\tlog_print_t print_func;\n \tsize_t dynamic_types_len;\n \tstruct rte_log_dynamic_type *dynamic_types;\n } rte_logs = {\n \t.type = UINT32_MAX,\n \t.level = RTE_LOG_DEBUG,\n+\t.print_func = log_print,\n };\n \n struct rte_eal_opt_loglevel {\n@@ -78,6 +83,7 @@ rte_openlog_stream(FILE *f)\n \t\tfclose(rte_logs.file);\n \n \trte_logs.file = f;\n+\trte_logs.print_func = log_print;\n \treturn 0;\n }\n \n@@ -484,7 +490,7 @@ rte_vlog(uint32_t level, uint32_t logtype, const char *format, va_list ap)\n \tRTE_PER_LCORE(log_cur_msg).loglevel = level;\n \tRTE_PER_LCORE(log_cur_msg).logtype = logtype;\n \n-\tret = vfprintf(f, format, ap);\n+\tret = (*rte_logs.print_func)(f, level, format, ap);\n \tfflush(f);\n \treturn ret;\n }\n@@ -513,6 +519,15 @@ eal_log_syslog(const char *mode __rte_unused)\n \treturn -1;\n }\n \n+/* default log print function */\n+__rte_format_printf(3, 0)\n+static int\n+log_print(FILE *f, uint32_t level __rte_unused,\n+\t const char *format, va_list ap)\n+{\n+\treturn vfprintf(f, format, ap);\n+}\n+\n /*\n * Called by rte_eal_init\n */\n", "prefixes": [ "v16", "11/15" ] }{ "id": 138867, "url": "