Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138860/?format=api
{ "id": 138860, "url": "http://patches.dpdk.org/api/patches/138860/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240327164726.68732-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240327164726.68732-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240327164726.68732-5-stephen@networkplumber.org", "date": "2024-03-27T16:45:22", "name": "[v16,04/15] windows: common wrapper for vasprintf and asprintf", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "582ccd4ba5558a6005de0f30c96883cf48708a3a", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240327164726.68732-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 31630, "url": "http://patches.dpdk.org/api/series/31630/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31630", "date": "2024-03-27T16:45:18", "name": "Logging unification and improvements", "version": 16, "mbox": "http://patches.dpdk.org/series/31630/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138860/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/138860/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A04EE43D55;\n\tWed, 27 Mar 2024 17:48:06 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E99A34114B;\n\tWed, 27 Mar 2024 17:47:42 +0100 (CET)", "from mail-pf1-f176.google.com (mail-pf1-f176.google.com\n [209.85.210.176])\n by mails.dpdk.org (Postfix) with ESMTP id EFEFF410D5\n for <dev@dpdk.org>; Wed, 27 Mar 2024 17:47:39 +0100 (CET)", "by mail-pf1-f176.google.com with SMTP id\n d2e1a72fcca58-6ea80de0e97so52378b3a.2\n for <dev@dpdk.org>; Wed, 27 Mar 2024 09:47:39 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n a33-20020a056a0011e100b006e580678dfbsm5160873pfu.193.2024.03.27.09.47.38\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 27 Mar 2024 09:47:38 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711558059;\n x=1712162859; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Ujp+cIa113EpqJ3VrSeEX0YvuuF9LLXucC0i8pzL9Vs=;\n b=o2hH8Jpmqoitb3GoF78wZcE38RVqltwytpZQhokHt1TwJd/RzB/pVHLdlH/K0bKXOw\n 8oPYaekNkOeEdlOAF/0Q0NwOEO5Hz2mUcpXhvTvGbX18wkVr7Go5jqaJzDVPy6OFxMjN\n 38o9efj0ltjwZ4x++xMIJIw3hVXNe20c7f5XqBDvY1Pj0OJjpDowzsfwOgFUoNF0QhXg\n ReadU/iMV1p8XbXW1ORBFPyhXwPjDNM6moWs4PSThScWxUcbmlJ0Kaw5t/K/qD+j84eV\n 7lidsquJ9LRpMMXuVY2VEgBfKIS194L+cWp6phDj09AKS5gFDpv3/94/wfvxTq6L4wpc\n eGlQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711558059; x=1712162859;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=Ujp+cIa113EpqJ3VrSeEX0YvuuF9LLXucC0i8pzL9Vs=;\n b=qkuyDi078Q+YsDUnjqYiv59Qo2ycpq3rtBTu9v6Gv1/Sr5En6hyfSPD4bUh6+dkxqV\n qcOqvMV/iTuIwNSwggcFSI2E3qetFWV62fuYnU/rOStoFaLJK8ZgoafKRRzs8IbNzaKM\n BEJ2XFEs0p6RY/zXSiWtC8RJ4yphHclb16ToMTB3sr5ECmi4cJFgZzDOw3+EYAU92JdY\n pLgs/lmqQ7xe3KKfg0mZfFH0fwUgTqGewIfahZ5fsdVsvtdotT/M1Mxdb/RBaaiOxnYG\n 8JzZG7zDsNAdhh7uz9OmaQm+B5gpDlQpjts61zZ33kGJkqNHRmwE0/hb3w1cFvtqyIjs\n 0xgw==", "X-Gm-Message-State": "AOJu0Yy1xpZQ/y+u1M7tYznvnYmn36wJLMICAj1g7G8xWXVKAva29VQ3\n GlruOBnbNK1/8dDuQwS9/s8XaShm4tda3+wV4hZlIVxmWaujS09UWnJ4Dh9rn2iYMq2VAkdS1k3\n N", "X-Google-Smtp-Source": "\n AGHT+IH3ywjcNskXFfCUSiu9E5T7BrQMdbE2Y148/sU55WV58bRUcNjm1TywIkeoUzCJyOwXAEkknQ==", "X-Received": "by 2002:a05:6a20:d39a:b0:1a3:6bb1:ad22 with SMTP id\n iq26-20020a056a20d39a00b001a36bb1ad22mr614271pzb.23.1711558059085;\n Wed, 27 Mar 2024 09:47:39 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Chenbo Xia <chenbox@nvidia.com>, Nipun Gupta <nipun.gupta@amd.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n David Marchand <david.marchand@redhat.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Nick Connolly <nick.connolly@mayadata.io>, Khoa To <khot@microsoft.com>,\n Ranjit Menon <ranjit.menon@intel.com>", "Subject": "[PATCH v16 04/15] windows: common wrapper for vasprintf and asprintf", "Date": "Wed, 27 Mar 2024 09:45:22 -0700", "Message-ID": "<20240327164726.68732-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240327164726.68732-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240327164726.68732-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace the windows version of asprintf() that was only usable\nin eal. With a more generic one that supports both vasprintf()\nand asprintf(). This also eliminates duplicate code.\n\nFixes: 8f4de2dba9b9 (\"bus/pci: fill bus specific information\")\nFixes: 9ec521006db0 (\"eal/windows: hide asprintf shim\")\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/bus/pci/pci_common.c | 32 ------------------\n lib/eal/common/eal_private.h | 10 ------\n lib/eal/windows/eal.c | 28 ----------------\n lib/eal/windows/include/rte_os_shim.h | 48 +++++++++++++++++++++++++++\n 4 files changed, 48 insertions(+), 70 deletions(-)", "diff": "diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c\nindex 889a48d2af..80691c75a3 100644\n--- a/drivers/bus/pci/pci_common.c\n+++ b/drivers/bus/pci/pci_common.c\n@@ -45,38 +45,6 @@ const char *rte_pci_get_sysfs_path(void)\n \treturn path;\n }\n \n-#ifdef RTE_EXEC_ENV_WINDOWS\n-#define asprintf pci_asprintf\n-\n-static int\n-__rte_format_printf(2, 3)\n-pci_asprintf(char **buffer, const char *format, ...)\n-{\n-\tint size, ret;\n-\tva_list arg;\n-\n-\tva_start(arg, format);\n-\tsize = vsnprintf(NULL, 0, format, arg);\n-\tva_end(arg);\n-\tif (size < 0)\n-\t\treturn -1;\n-\tsize++;\n-\n-\t*buffer = malloc(size);\n-\tif (*buffer == NULL)\n-\t\treturn -1;\n-\n-\tva_start(arg, format);\n-\tret = vsnprintf(*buffer, size, format, arg);\n-\tva_end(arg);\n-\tif (ret != size - 1) {\n-\t\tfree(*buffer);\n-\t\treturn -1;\n-\t}\n-\treturn ret;\n-}\n-#endif /* RTE_EXEC_ENV_WINDOWS */\n-\n static struct rte_devargs *\n pci_devargs_lookup(const struct rte_pci_addr *pci_addr)\n {\ndiff --git a/lib/eal/common/eal_private.h b/lib/eal/common/eal_private.h\nindex 71523cfdb8..da8d77a134 100644\n--- a/lib/eal/common/eal_private.h\n+++ b/lib/eal/common/eal_private.h\n@@ -737,16 +737,6 @@ void __rte_thread_init(unsigned int lcore_id, rte_cpuset_t *cpuset);\n */\n void __rte_thread_uninit(void);\n \n-/**\n- * asprintf(3) replacement for Windows.\n- */\n-#ifdef RTE_EXEC_ENV_WINDOWS\n-__rte_format_printf(2, 3)\n-int eal_asprintf(char **buffer, const char *format, ...);\n-\n-#define asprintf(buffer, format, ...) \\\n-\t\teal_asprintf(buffer, format, ##__VA_ARGS__)\n-#endif\n \n #define EAL_LOG(level, ...) \\\n \tRTE_LOG_LINE(level, EAL, \"\" __VA_ARGS__)\ndiff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c\nindex 52f0e7462d..8ca00c0f95 100644\n--- a/lib/eal/windows/eal.c\n+++ b/lib/eal/windows/eal.c\n@@ -503,34 +503,6 @@ rte_eal_init(int argc, char **argv)\n \treturn fctret;\n }\n \n-/* Don't use MinGW asprintf() to have identical code with all toolchains. */\n-int\n-eal_asprintf(char **buffer, const char *format, ...)\n-{\n-\tint size, ret;\n-\tva_list arg;\n-\n-\tva_start(arg, format);\n-\tsize = vsnprintf(NULL, 0, format, arg);\n-\tva_end(arg);\n-\tif (size < 0)\n-\t\treturn -1;\n-\tsize++;\n-\n-\t*buffer = malloc(size);\n-\tif (*buffer == NULL)\n-\t\treturn -1;\n-\n-\tva_start(arg, format);\n-\tret = vsnprintf(*buffer, size, format, arg);\n-\tva_end(arg);\n-\tif (ret != size - 1) {\n-\t\tfree(*buffer);\n-\t\treturn -1;\n-\t}\n-\treturn ret;\n-}\n-\n int\n rte_vfio_container_dma_map(__rte_unused int container_fd,\n \t\t\t__rte_unused uint64_t vaddr,\ndiff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include/rte_os_shim.h\nindex e9741a9df2..65153fdb38 100644\n--- a/lib/eal/windows/include/rte_os_shim.h\n+++ b/lib/eal/windows/include/rte_os_shim.h\n@@ -3,6 +3,7 @@\n #ifndef _RTE_OS_SHIM_\n #define _RTE_OS_SHIM_\n \n+#include <stdio.h>\n #include <time.h>\n \n #include <rte_os.h>\n@@ -120,4 +121,51 @@ rte_localtime_r(const time_t *timer, struct tm *buf)\n }\n #define localtime_r(timer, buf) rte_localtime_r(timer, buf)\n \n+/* print to allocated string */\n+__rte_format_printf(2, 0)\n+static inline int\n+rte_vasprintf(char **strp, const char *fmt, va_list ap)\n+{\n+\tchar *str;\n+\tint len, ret;\n+\n+\t*strp = NULL;\n+\n+\t/* determine size of buffer needed */\n+\tlen = _vscprintf(fmt, ap);\n+\tif (len < 0)\n+\t\treturn -1;\n+\n+\tlen += 1;\t/* for nul termination */\n+\tstr = malloc(len);\n+\tif (str == NULL)\n+\t\treturn -1;\n+\n+\tret = vsnprintf(str, len, fmt, ap);\n+\tif (ret < 0) {\n+\t\tfree(str);\n+\t\treturn -1;\n+\t} else {\n+\t\t*strp = str;\n+\t\treturn ret;\n+\t}\n+}\n+#define vasprintf(strp, fmt, ap) rte_vasprintf(strp, fmt, ap)\n+\n+__rte_format_printf(2, 3)\n+static inline int\n+rte_asprintf(char **strp, const char *fmt, ...)\n+{\n+\tint ret;\n+\n+\tva_list ap;\n+\n+\tva_start(ap, fmt);\n+\tret = rte_vasprintf(strp, fmt, ap);\n+\tva_end(ap);\n+\n+\treturn ret;\n+}\n+\n+#define asprintf(strp, fmt, ...) rte_asprintf(strp, fmt, __VA_ARGS__)\n #endif /* _RTE_OS_SHIM_ */\n", "prefixes": [ "v16", "04/15" ] }