Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138822/?format=api
{ "id": 138822, "url": "http://patches.dpdk.org/api/patches/138822/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240326173552.97249-12-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240326173552.97249-12-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240326173552.97249-12-stephen@networkplumber.org", "date": "2024-03-26T17:34:31", "name": "[v14,11/15] log: add hook for printing log messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b0dac51056037de6cb9b6c1c1e99531e4abef1e9", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240326173552.97249-12-stephen@networkplumber.org/mbox/", "series": [ { "id": 31621, "url": "http://patches.dpdk.org/api/series/31621/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31621", "date": "2024-03-26T17:34:20", "name": "Logging unification and improvments", "version": 14, "mbox": "http://patches.dpdk.org/series/31621/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138822/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138822/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3AC1143D5A;\n\tTue, 26 Mar 2024 18:37:31 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E26C140EF0;\n\tTue, 26 Mar 2024 18:36:21 +0100 (CET)", "from mail-pf1-f182.google.com (mail-pf1-f182.google.com\n [209.85.210.182])\n by mails.dpdk.org (Postfix) with ESMTP id 5795A410FA\n for <dev@dpdk.org>; Tue, 26 Mar 2024 18:36:14 +0100 (CET)", "by mail-pf1-f182.google.com with SMTP id\n d2e1a72fcca58-6ea8a0d1a05so22295b3a.1\n for <dev@dpdk.org>; Tue, 26 Mar 2024 10:36:14 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n u6-20020aa78386000000b006e58da8bb6asm6205546pfm.132.2024.03.26.10.36.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 26 Mar 2024 10:36:13 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711474573;\n x=1712079373; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zu4Y35qfKTRMkWDem+dq2ZFz0NT/aAm4UNjlX7qaan4=;\n b=EAtBlHcl5jikUNLB/Ftkk0xJ2EMYsX/E0EVeYH55RWz8a2PQgM6Dg4lMBX6K1GERAR\n mLOEexidU728BDw7vLN8RbbASTPCivELn+pSKV5esjjf7oebsTjrk40hPYAyeVM+8oIE\n i23Mrk2pq7PzWqg8AtHuK86JLfqRW68RelXQwcUhHv+E2ggouIpwIMvocaQOybGimJwh\n LXC7Skqjl24y6PuIWCaJGEqzDT+q6v+jKgi5LrQ2XrxTFBukqTeHAhkt9rYx2mgy7WH8\n 3kfyhghZtuA6uF+NFqf2ICL3LyIXg/rb8uo1uyIUOjxWvTAiIG8AVRi1e4AvHUPWk4Y0\n /nLw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711474573; x=1712079373;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=zu4Y35qfKTRMkWDem+dq2ZFz0NT/aAm4UNjlX7qaan4=;\n b=MD4McT//4zcRuvbwBkH6ejkxsBm/FwbrCWKO5yC0FJ9a+KYrPtgwdPg67XGCOuY8GA\n MdEM+RfwXz2jYEoNP5wtCQNTQC9Z+jWFmI7g1SwGIt8nFS+2hQaenL9MrK/rBuMMCls/\n a4Gr+PPnnp9wLeGW/XZKgQ0hKMUONgpvgzw47IxJvSWmKoEFW2EBE5HPePc9SF29Pe+n\n l9If5Jphv/FHPap/86L1T8MSMESQI1MXUXr0aX+4OoqixxMCToy4eYHS3GqOwRFGrqhb\n uzgeUTIEzumh+5Sel3lu4KysvdV28UfoKzP323JpoEk3cEBjyU0Ho5nY5I0u0M+3TQdp\n O99w==", "X-Gm-Message-State": "AOJu0Yy5srJ2TKh/xOdfJF3vl8ScC2zS4Q3xnSjnyWNeNTJG92xRLWvM\n FXAI5/QmXxL/310EnJZ0QNYLb8rgFfuRG2HGawV1jlJfpsOFEVU263+Z6qnINI4gzSuSRg1rdAY\n t", "X-Google-Smtp-Source": "\n AGHT+IE8J4mG7B921OgI7lWLAVJ3CoCrvwnpEr9KdR9s3S+nJtr6NxtPiN70XCSRtUInTmc7+BFwHQ==", "X-Received": "by 2002:a05:6a00:1ad3:b0:6ea:9a10:b74c with SMTP id\n f19-20020a056a001ad300b006ea9a10b74cmr2913550pfv.16.1711474573495;\n Tue, 26 Mar 2024 10:36:13 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v14 11/15] log: add hook for printing log messages", "Date": "Tue, 26 Mar 2024 10:34:31 -0700", "Message-ID": "<20240326173552.97249-12-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240326173552.97249-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240326173552.97249-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This is useful for when decorating log output for console\nor journal. Provide basic version in this patch.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/log/log.c | 17 ++++++++++++++++-\n 1 file changed, 16 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/log/log.c b/lib/log/log.c\nindex f597da2e39..acd4c320b6 100644\n--- a/lib/log/log.c\n+++ b/lib/log/log.c\n@@ -26,16 +26,21 @@ struct rte_log_dynamic_type {\n \tuint32_t loglevel;\n };\n \n+typedef int (*log_print_t)(FILE *f, uint32_t level, const char *fmt, va_list ap);\n+static int log_print(FILE *f, uint32_t level, const char *format, va_list ap);\n+\n /** The rte_log structure. */\n static struct rte_logs {\n \tuint32_t type; /**< Bitfield with enabled logs. */\n \tuint32_t level; /**< Log level. */\n \tFILE *file; /**< Output file set by rte_openlog_stream, or NULL. */\n+\tlog_print_t print_func;\n \tsize_t dynamic_types_len;\n \tstruct rte_log_dynamic_type *dynamic_types;\n } rte_logs = {\n \t.type = UINT32_MAX,\n \t.level = RTE_LOG_DEBUG,\n+\t.print_func = log_print,\n };\n \n struct rte_eal_opt_loglevel {\n@@ -78,6 +83,7 @@ rte_openlog_stream(FILE *f)\n \t\tfclose(rte_logs.file);\n \n \trte_logs.file = f;\n+\trte_logs.print_func = log_print;\n \treturn 0;\n }\n \n@@ -484,7 +490,7 @@ rte_vlog(uint32_t level, uint32_t logtype, const char *format, va_list ap)\n \tRTE_PER_LCORE(log_cur_msg).loglevel = level;\n \tRTE_PER_LCORE(log_cur_msg).logtype = logtype;\n \n-\tret = vfprintf(f, format, ap);\n+\tret = (*rte_logs.print_func)(f, level, format, ap);\n \tfflush(f);\n \treturn ret;\n }\n@@ -513,6 +519,15 @@ eal_log_syslog(const char *mode __rte_unused)\n \treturn -1;\n }\n \n+/* default log print function */\n+__rte_format_printf(3, 0)\n+static int\n+log_print(FILE *f, uint32_t level __rte_unused,\n+\t const char *format, va_list ap)\n+{\n+\treturn vfprintf(f, format, ap);\n+}\n+\n /*\n * Called by rte_eal_init\n */\n", "prefixes": [ "v14", "11/15" ] }