Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 138820,
    "url": "http://patches.dpdk.org/api/patches/138820/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240326173552.97249-10-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20240326173552.97249-10-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20240326173552.97249-10-stephen@networkplumber.org",
    "date": "2024-03-26T17:34:29",
    "name": "[v14,09/15] eal: initialize log before everything else",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "1b71602c4edddcf91cddd3109ff100ff04263eb3",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240326173552.97249-10-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 31621,
            "url": "http://patches.dpdk.org/api/series/31621/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31621",
            "date": "2024-03-26T17:34:20",
            "name": "Logging unification and improvments",
            "version": 14,
            "mbox": "http://patches.dpdk.org/series/31621/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/138820/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/138820/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C04D443D5A;\n\tTue, 26 Mar 2024 18:37:13 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 89A50427D9;\n\tTue, 26 Mar 2024 18:36:19 +0100 (CET)",
            "from mail-pf1-f179.google.com (mail-pf1-f179.google.com\n [209.85.210.179])\n by mails.dpdk.org (Postfix) with ESMTP id AE75A410E6\n for <dev@dpdk.org>; Tue, 26 Mar 2024 18:36:12 +0100 (CET)",
            "by mail-pf1-f179.google.com with SMTP id\n d2e1a72fcca58-6e6bee809b8so4949858b3a.1\n for <dev@dpdk.org>; Tue, 26 Mar 2024 10:36:12 -0700 (PDT)",
            "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n u6-20020aa78386000000b006e58da8bb6asm6205546pfm.132.2024.03.26.10.36.10\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 26 Mar 2024 10:36:11 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711474572;\n x=1712079372; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=lymWiavwrFvAchUcPNDs8TtaMkMHgQ+bVt4jwb/wnmA=;\n b=BtWqlpFx+JAoYPyV1EjooHQzEj3MrtB7zaqbKm7ZLHNRPgF+/ij95ooCsx8n256zKL\n oQGrIV5CdG8FT+FdhN5an7RFCN0P4zJFkaoVZNPCifaDYqgSiKvA4wzpa2BPVdhi+sjp\n tSC3DfyFPePOJ2N3HQ948+JBgd8cdxuKeQkw8pfOFhxN6ySgPLyVFmkPOpmrJTVu/ZsD\n LG7oDqT7iQTGvZQYWsEqJlowK/knsuQoMrk88A8TlnQ03DeYIyGJaI83CTnuLW9FwJMl\n Rl5m4xxHu7z9JwCRl7QSVTRs4eJ2V20Sx8ndaA3+W6G2XE2YxR2GbPEn23RbllzexfuE\n oEqg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711474572; x=1712079372;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=lymWiavwrFvAchUcPNDs8TtaMkMHgQ+bVt4jwb/wnmA=;\n b=k0le57DmrIhfOkZ3mYJyy9xf6ZjvcIk4xV0LcoYvwUY2qUxMz0beYu4naUvnS12XUG\n D2DpeSj9rf/m6OrC9Ywq2NWgqBjZURXy9ByjX9hd/JerfyWc2Uw7SjA7ZhqOR/e5WY6v\n 2fpH2vaptXvuNDkX4qnpdDXzL/BvGpP0ZP4qPeZE1oepqBZPQaxJDKAp0QIcKSbU2ibd\n EP/yb9ojdBIff7i8XddiiRLoo0rvokoP7t86gPFpJntgzHNfm0s6pVEwA1+EzY2EKl5g\n i+OM9F58ap4qhs0u5jPp4rorqzDkytX1RI2WemlxhvOJFZAccdTssInjrBmxVLDndyTT\n +Fsw==",
        "X-Gm-Message-State": "AOJu0YzY9s8ZXJ4KTxEPI1AwrQanqretsqDYwrVu1donLULmdkoPvLQH\n s7cRIEO+clJKDAjknbDOtHeum0eFik9zOQj4vumWBONj8UxoSt48wVGvoxKkKnBpnDE9vFw8m9f\n J",
        "X-Google-Smtp-Source": "\n AGHT+IFoy9gBhLc7gX83Pl6lBBD0Ssn+v1YpjuYt4Qin4+A70s2c8qKB47XTWj4C8Xpm1UtoBQSX4g==",
        "X-Received": "by 2002:a05:6a00:4b54:b0:6e6:8c8b:a45b with SMTP id\n kr20-20020a056a004b5400b006e68c8ba45bmr424416pfb.18.1711474571845;\n Tue, 26 Mar 2024 10:36:11 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>",
        "Subject": "[PATCH v14 09/15] eal: initialize log before everything else",
        "Date": "Tue, 26 Mar 2024 10:34:29 -0700",
        "Message-ID": "<20240326173552.97249-10-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.43.0",
        "In-Reply-To": "<20240326173552.97249-1-stephen@networkplumber.org>",
        "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240326173552.97249-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "In order for all log messages (including CPU mismatch) to\ncome out through the logging library, it must be initialized\nas early in rte_eal_init() as possible on all platforms.\n\nWhere it was done before was likely historical based on\nthe support of non-OS isolated CPU's which required a shared\nmemory buffer; that support was dropped before DPDK was\npublicly released.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/freebsd/eal.c  | 12 +++++++++---\n lib/eal/linux/eal.c    | 19 +++++++++----------\n lib/eal/windows/eal.c  |  8 ++++++--\n lib/log/log_freebsd.c  |  3 +--\n lib/log/log_internal.h |  2 +-\n lib/log/log_linux.c    | 14 ++++++--------\n lib/log/log_windows.c  |  4 +---\n 7 files changed, 33 insertions(+), 29 deletions(-)",
    "diff": "diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex 6552f9c138..55ff27a4da 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -52,6 +52,7 @@\n #include \"eal_options.h\"\n #include \"eal_memcfg.h\"\n #include \"eal_trace.h\"\n+#include \"log_internal.h\"\n \n #define MEMSIZE_IF_NO_HUGE_PAGE (64ULL * 1024ULL * 1024ULL)\n \n@@ -546,6 +547,14 @@ rte_eal_init(int argc, char **argv)\n \tbool has_phys_addr;\n \tenum rte_iova_mode iova_mode;\n \n+\t/* setup log as early as possible */\n+\tif (eal_log_level_parse(argc, argv) < 0) {\n+\t\trte_eal_init_alert(\"invalid log arguments.\");\n+\t\trte_errno = EINVAL;\n+\t\treturn -1;\n+\t}\n+\teal_log_init(getprogname());\n+\n \t/* checks if the machine is adequate */\n \tif (!rte_cpu_is_supported()) {\n \t\trte_eal_init_alert(\"unsupported cpu type.\");\n@@ -565,9 +574,6 @@ rte_eal_init(int argc, char **argv)\n \t/* clone argv to report out later in telemetry */\n \teal_save_args(argc, argv);\n \n-\t/* set log level as early as possible */\n-\teal_log_level_parse(argc, argv);\n-\n \tif (rte_eal_cpu_init() < 0) {\n \t\trte_eal_init_alert(\"Cannot detect lcores.\");\n \t\trte_errno = ENOTSUP;\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex 3d0c34063e..b9a0fb1742 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -936,6 +936,15 @@ rte_eal_init(int argc, char **argv)\n \tstruct internal_config *internal_conf =\n \t\teal_get_internal_configuration();\n \n+\t/* setup log as early as possible */\n+\tif (eal_log_level_parse(argc, argv) < 0) {\n+\t\trte_eal_init_alert(\"invalid log arguments.\");\n+\t\trte_errno = EINVAL;\n+\t\treturn -1;\n+\t}\n+\n+\teal_log_init(program_invocation_short_name);\n+\n \t/* checks if the machine is adequate */\n \tif (!rte_cpu_is_supported()) {\n \t\trte_eal_init_alert(\"unsupported cpu type.\");\n@@ -952,9 +961,6 @@ rte_eal_init(int argc, char **argv)\n \n \teal_reset_internal_config(internal_conf);\n \n-\t/* set log level as early as possible */\n-\teal_log_level_parse(argc, argv);\n-\n \t/* clone argv to report out later in telemetry */\n \teal_save_args(argc, argv);\n \n@@ -1106,13 +1112,6 @@ rte_eal_init(int argc, char **argv)\n #endif\n \t}\n \n-\tif (eal_log_init(program_invocation_short_name) < 0) {\n-\t\trte_eal_init_alert(\"Cannot init logging.\");\n-\t\trte_errno = ENOMEM;\n-\t\trte_atomic_store_explicit(&run_once, 0, rte_memory_order_relaxed);\n-\t\treturn -1;\n-\t}\n-\n #ifdef VFIO_PRESENT\n \tif (rte_eal_vfio_setup() < 0) {\n \t\trte_eal_init_alert(\"Cannot init VFIO\");\ndiff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c\nindex 14e498a643..e59aba954e 100644\n--- a/lib/eal/windows/eal.c\n+++ b/lib/eal/windows/eal.c\n@@ -250,9 +250,13 @@ rte_eal_init(int argc, char **argv)\n \tchar cpuset[RTE_CPU_AFFINITY_STR_LEN];\n \tchar thread_name[RTE_THREAD_NAME_SIZE];\n \n-\teal_log_init(NULL);\n+\tif (eal_log_level_parse(argc, argv) < 0) {\n+\t\trte_eal_init_alert(\"invalid log arguments.\");\n+\t\trte_errno = EINVAL;\n+\t\treturn -1;\n+\t}\n \n-\teal_log_level_parse(argc, argv);\n+\teal_log_init(NULL);\n \n \tif (eal_create_cpu_map() < 0) {\n \t\trte_eal_init_alert(\"Cannot discover CPU and NUMA.\");\ndiff --git a/lib/log/log_freebsd.c b/lib/log/log_freebsd.c\nindex 953e371bee..33a0925c43 100644\n--- a/lib/log/log_freebsd.c\n+++ b/lib/log/log_freebsd.c\n@@ -5,8 +5,7 @@\n #include <rte_common.h>\n #include \"log_internal.h\"\n \n-int\n+void\n eal_log_init(__rte_unused const char *id)\n {\n-\treturn 0;\n }\ndiff --git a/lib/log/log_internal.h b/lib/log/log_internal.h\nindex cb15cdff08..d5fabd7ef7 100644\n--- a/lib/log/log_internal.h\n+++ b/lib/log/log_internal.h\n@@ -14,7 +14,7 @@\n  * Initialize the default log stream.\n  */\n __rte_internal\n-int eal_log_init(const char *id);\n+void eal_log_init(const char *id);\n \n /*\n  * Determine where log data is written when no call to rte_openlog_stream.\ndiff --git a/lib/log/log_linux.c b/lib/log/log_linux.c\nindex 47aa074da2..6d7dc8f3ab 100644\n--- a/lib/log/log_linux.c\n+++ b/lib/log/log_linux.c\n@@ -87,18 +87,16 @@ static cookie_io_functions_t console_log_func = {\n  * set the log to default function, called during eal init process,\n  * once memzones are available.\n  */\n-int\n+void\n eal_log_init(const char *id)\n {\n \tFILE *log_stream;\n \n-\tlog_stream = fopencookie(NULL, \"w+\", console_log_func);\n-\tif (log_stream == NULL)\n-\t\treturn -1;\n-\n \topenlog(id, LOG_NDELAY | LOG_PID, log_facility);\n \n-\teal_log_set_default(log_stream);\n-\n-\treturn 0;\n+\tlog_stream = fopencookie(NULL, \"w+\", console_log_func);\n+\tif (log_stream != NULL)\n+\t\teal_log_set_default(log_stream);\n+\telse\n+\t\teal_log_set_default(stderr);\n }\ndiff --git a/lib/log/log_windows.c b/lib/log/log_windows.c\nindex a3a756351d..d7c30e4cfa 100644\n--- a/lib/log/log_windows.c\n+++ b/lib/log/log_windows.c\n@@ -13,12 +13,10 @@ eal_log_syslog(const char *name __rte_unused)\n }\n \n /* set the log to default function, called during eal init process. */\n-int\n+void\n eal_log_init(__rte_unused const char *id)\n {\n \trte_openlog_stream(stderr);\n \n \teal_log_set_default(stderr);\n-\n-\treturn 0;\n }\n",
    "prefixes": [
        "v14",
        "09/15"
    ]
}