Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138804/?format=api
{ "id": 138804, "url": "http://patches.dpdk.org/api/patches/138804/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240326125554.138840-9-sivaprasad.tummala@amd.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240326125554.138840-9-sivaprasad.tummala@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240326125554.138840-9-sivaprasad.tummala@amd.com", "date": "2024-03-26T12:55:47", "name": "[v7,08/14] examples/ipsec-secgw: fix lcore ID restriction", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "03523c788868832263bbedc3b8211b39354c50af", "submitter": { "id": 2510, "url": "http://patches.dpdk.org/api/people/2510/?format=api", "name": "Sivaprasad Tummala", "email": "Sivaprasad.Tummala@amd.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240326125554.138840-9-sivaprasad.tummala@amd.com/mbox/", "series": [ { "id": 31619, "url": "http://patches.dpdk.org/api/series/31619/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31619", "date": "2024-03-26T12:55:39", "name": "fix lcore ID restriction", "version": 7, "mbox": "http://patches.dpdk.org/series/31619/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138804/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138804/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 482FA43D51;\n\tTue, 26 Mar 2024 13:57:26 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0E73341141;\n\tTue, 26 Mar 2024 13:57:10 +0100 (CET)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2075.outbound.protection.outlook.com [40.107.237.75])\n by mails.dpdk.org (Postfix) with ESMTP id 7348F40E09;\n Tue, 26 Mar 2024 13:57:06 +0100 (CET)", "from DM6PR18CA0016.namprd18.prod.outlook.com (2603:10b6:5:15b::29)\n by MN2PR12MB4421.namprd12.prod.outlook.com (2603:10b6:208:26c::10) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.33; Tue, 26 Mar\n 2024 12:57:03 +0000", "from DS2PEPF00003445.namprd04.prod.outlook.com\n (2603:10b6:5:15b:cafe::47) by DM6PR18CA0016.outlook.office365.com\n (2603:10b6:5:15b::29) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.13 via Frontend\n Transport; Tue, 26 Mar 2024 12:57:03 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n DS2PEPF00003445.mail.protection.outlook.com (10.167.17.72) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7409.10 via Frontend Transport; Tue, 26 Mar 2024 12:57:02 +0000", "from ubuntu2004.linuxvmimages.local (10.180.168.240) by\n SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.35; Tue, 26 Mar 2024 07:56:54 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=cik1mL3gIi+3oHw4Yz7RTzeim/bJnyttcpV4KhhCvQA62K4dM/6qoC6F0veja3pPbKAvzIDpAtlrrIHPDnlEAYI+lREoUjy/ngLZfqy6lRZm8zt8AsgqKzV/SEwnmBR4Tyk8y63cmSM54eLLd3GrlT6FhhXGBG9G4I+EOi6mzGjlvBlE/Tiall4Pozp9NX+3b7CdFojoLzMah0jzOhd7slGOSx6Xwimd+W4DGOz7M3VuoFOY/viB7IM5adTsHg0mYFsWVnGOgapBR0hBXYkFmS7Qq0egyRnIVBYeGHn6WFDXBaVESpLMOlVgSrzWuUScorDDhQuGZeQoUOyUv5v1jw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=c5Wyvs3nPPdiKXM5ZKWrwKAz1v4DyHuQWWoGAeE6Ssk=;\n b=X/RzWNazpxg2pe39K6d2k7klt9Dj56mFBRfgh7SW4GD0OwVS46kXx1267gUD7caSYdW75pWvBZk4HhUo5wj99fb8iT22SeI5sjYiixD6cJ6AqiSRX3AKVFjhw91JiKpOmY/cKaSnpc7sVTvxGf5NiYNiHsvJPCOkzMTXcXKWaCZHVer8UR2EDzcHLAqg/nCjWgWaSWnD3SFIOeHOjt9LaoANPy/io4q7+f6uiqZ6XOyNp1Axg0Y3b6/KVK8XYT2GoJQR7myopDbzDPb+4WwOqmhbPW56BsBedcWUoGb485ORh9i0CSoO7D+xXQcAyxKLLHj5dz2vsf1m8cNTZRsY9Q==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=c5Wyvs3nPPdiKXM5ZKWrwKAz1v4DyHuQWWoGAeE6Ssk=;\n b=hE7lJCWwhml1Tf8yvbJ7cn7a1Snho7k/olV1F7EGJ/xNF1eFqDzwuIUyIirqbMN/OzNicL1loZm8VMNviXbt5dxFLkDQ4Erc/8+Ag6wor8P68lz8DrLAA3KpKn7tWTWxenHsleDCUZ06T1/5cQq0cOucIMlLw0a6pMvuy4/eKsc=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Sivaprasad Tummala <sivaprasad.tummala@amd.com>", "To": "<david.hunt@intel.com>, <anatoly.burakov@intel.com>, <jerinj@marvell.com>,\n <radu.nicolau@intel.com>, <gakhil@marvell.com>,\n <cristian.dumitrescu@intel.com>, <ferruh.yigit@amd.com>,\n <konstantin.ananyev@huawei.com>, <stephen@networkplumber.org>,\n <mb@smartsharesystems.com>, <david.marchand@redhat.com>", "CC": "<dev@dpdk.org>, <sergio.gonzalez.monroy@intel.com>, <stable@dpdk.org>", "Subject": "[PATCH v7 08/14] examples/ipsec-secgw: fix lcore ID restriction", "Date": "Tue, 26 Mar 2024 13:55:47 +0100", "Message-ID": "<20240326125554.138840-9-sivaprasad.tummala@amd.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240326125554.138840-1-sivaprasad.tummala@amd.com>", "References": "<20240321184721.69040-1-sivaprasad.tummala@amd.com>\n <20240326125554.138840-1-sivaprasad.tummala@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DS2PEPF00003445:EE_|MN2PR12MB4421:EE_", "X-MS-Office365-Filtering-Correlation-Id": "8fa50ca7-2832-4c20-0bac-08dc4d943b48", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n oRltKVBsR7W9DVio5GiVJH10tQu1O25C2Rgnwwnj5jam5zsnAn6dNe/CjRL3bQosJA7sV6Qd91Vv0G5eEiTyYmvcmdvjV6HFdg2xmIENnHGmZe3L5hI8eozKw4M8D+KFA8wFGw0LlMhN37OnhOXP8R9RyNCkQCc3dYPtm/ngrpNhUprT3IhRPytR/NE9bB6d61s/cbR59HnnkQAUEcGvLO0QogGjRaab18SeqTJmcREGF94Lm8ZqE6UiB0cOjRnbRFMCzDRz+w6nqlP1INDX4Q1dKVFsZRPztR0BMB/RcaAitOnHrQkhI0d4AhE11tu6oS+UEhYE8VyFS0Pjr694u7wKIbiCwyoiaq96zq9uFTYAqDyogEIiOUm2l+PIceBnUVjcjkLGuBOUoFeuZj4wiIHxNmnwXQQVNEB7A18nwGbIEN8MDQwHkSH19eFKSevayKHL3avqaRIsHR8MnEirLFEef1914En1y7t0W1/oq6NkUcHggXWCHinc5X8BvgIhSpfGP9sb+JN07mCytM/ef7yKZZOz0iUWTjXjdft+r3vn/R/wH1yCUlcDeK9Fsr2r4Je4low8gaQ63U1Dh4zXe464pYLFqm33PCwFfCU6MQjWSlUgQ6B9t6jbM6kKzX9uKAbhH2u1xpaxyG61HfCzdNiQcTfDaKAosJSXdgF0H+cicg4GyVaK3JwPZPw83wO6QDd0Twl1g8YeDNLCSSxqFxaGoUvuJhq4c6nwLnmGYYDcoNrqtiFflQz0cqU/50he/F72MZSh5a7WTzmI+BQ2bA==", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(7416005)(376005)(82310400014)(36860700004)(1800799015)(921011);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "26 Mar 2024 12:57:02.3906 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 8fa50ca7-2832-4c20-0bac-08dc4d943b48", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DS2PEPF00003445.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR12MB4421", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently the config option allows lcore IDs up to 255,\nirrespective of RTE_MAX_LCORES and needs to be fixed.\n\nThe patch fixes these constraints by allowing all\nlcore IDs up to RTE_MAX_LCORES. Also the queue\nIDs are increased to support up to 65535.\n\nFixes: d299106e8e31 (\"examples/ipsec-secgw: add IPsec sample application\")\nCc: sergio.gonzalez.monroy@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>\nAcked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Ferruh Yigit <ferruh.yigit@amd.com>\n---\n examples/ipsec-secgw/event_helper.h | 2 +-\n examples/ipsec-secgw/ipsec-secgw.c | 21 +++++++++++++--------\n examples/ipsec-secgw/ipsec.c | 2 +-\n examples/ipsec-secgw/ipsec.h | 4 ++--\n 4 files changed, 17 insertions(+), 12 deletions(-)", "diff": "diff --git a/examples/ipsec-secgw/event_helper.h b/examples/ipsec-secgw/event_helper.h\nindex dfb81bfcf1..be635685b4 100644\n--- a/examples/ipsec-secgw/event_helper.h\n+++ b/examples/ipsec-secgw/event_helper.h\n@@ -102,7 +102,7 @@ struct eh_event_link_info {\n \t\t/**< Event port ID */\n \tuint8_t eventq_id;\n \t\t/**< Event queue to be linked to the port */\n-\tuint8_t lcore_id;\n+\tuint32_t lcore_id;\n \t\t/**< Lcore to be polling on this port */\n };\n \ndiff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c\nindex 782535f4b5..2d004d82fd 100644\n--- a/examples/ipsec-secgw/ipsec-secgw.c\n+++ b/examples/ipsec-secgw/ipsec-secgw.c\n@@ -221,7 +221,7 @@ static const char *cfgfile;\n struct lcore_params {\n \tuint16_t port_id;\n \tuint16_t queue_id;\n-\tuint8_t lcore_id;\n+\tuint32_t lcore_id;\n } __rte_cache_aligned;\n \n static struct lcore_params lcore_params_array[MAX_LCORE_PARAMS];\n@@ -807,7 +807,7 @@ check_flow_params(uint16_t fdir_portid, uint8_t fdir_qid)\n static int32_t\n check_poll_mode_params(struct eh_conf *eh_conf)\n {\n-\tuint8_t lcore;\n+\tuint32_t lcore;\n \tuint16_t portid;\n \tuint16_t i;\n \tint32_t socket_id;\n@@ -826,13 +826,13 @@ check_poll_mode_params(struct eh_conf *eh_conf)\n \tfor (i = 0; i < nb_lcore_params; ++i) {\n \t\tlcore = lcore_params[i].lcore_id;\n \t\tif (!rte_lcore_is_enabled(lcore)) {\n-\t\t\tprintf(\"error: lcore %hhu is not enabled in \"\n+\t\t\tprintf(\"error: lcore %u is not enabled in \"\n \t\t\t\t\"lcore mask\\n\", lcore);\n \t\t\treturn -1;\n \t\t}\n \t\tsocket_id = rte_lcore_to_socket_id(lcore);\n \t\tif (socket_id != 0 && numa_on == 0) {\n-\t\t\tprintf(\"warning: lcore %hhu is on socket %d \"\n+\t\t\tprintf(\"warning: lcore %u is on socket %d \"\n \t\t\t\t\"with numa off\\n\",\n \t\t\t\tlcore, socket_id);\n \t\t}\n@@ -867,7 +867,7 @@ static int32_t\n init_lcore_rx_queues(void)\n {\n \tuint16_t i, nb_rx_queue;\n-\tuint8_t lcore;\n+\tuint32_t lcore;\n \n \tfor (i = 0; i < nb_lcore_params; ++i) {\n \t\tlcore = lcore_params[i].lcore_id;\n@@ -1048,7 +1048,11 @@ parse_config(const char *q_arg)\n \tchar *str_fld[_NUM_FLD];\n \tint32_t i;\n \tuint32_t size;\n-\tuint32_t max_fld[_NUM_FLD] = {255, RTE_MAX_QUEUES_PER_PORT, 255};\n+\tuint32_t max_fld[_NUM_FLD] = {\n+\t\t255,\n+\t\tRTE_MAX_QUEUES_PER_PORT,\n+\t\tRTE_MAX_LCORE\n+\t};\n \n \tnb_lcore_params = 0;\n \n@@ -1082,7 +1086,7 @@ parse_config(const char *q_arg)\n \t\tlcore_params_array[nb_lcore_params].queue_id =\n \t\t\t(uint16_t)int_fld[FLD_QUEUE];\n \t\tlcore_params_array[nb_lcore_params].lcore_id =\n-\t\t\t(uint8_t)int_fld[FLD_LCORE];\n+\t\t\t(uint32_t)int_fld[FLD_LCORE];\n \t\t++nb_lcore_params;\n \t}\n \tlcore_params = lcore_params_array;\n@@ -1918,7 +1922,8 @@ port_init(uint16_t portid, uint64_t req_rx_offloads, uint64_t req_tx_offloads,\n \tstruct rte_eth_dev_info dev_info;\n \tstruct rte_eth_txconf *txconf;\n \tuint16_t nb_tx_queue, nb_rx_queue;\n-\tuint16_t tx_queueid, rx_queueid, queue, lcore_id;\n+\tuint16_t tx_queueid, rx_queueid, queue;\n+\tuint32_t lcore_id;\n \tint32_t ret, socket_id;\n \tstruct lcore_conf *qconf;\n \tstruct rte_ether_addr ethaddr;\ndiff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c\nindex c321108119..b52b0ffc3d 100644\n--- a/examples/ipsec-secgw/ipsec.c\n+++ b/examples/ipsec-secgw/ipsec.c\n@@ -259,7 +259,7 @@ create_lookaside_session(struct ipsec_ctx *ipsec_ctx_lcore[],\n \t\t\tcontinue;\n \n \t\t/* Looking for cryptodev, which can handle this SA */\n-\t\tkey.lcore_id = (uint8_t)lcore_id;\n+\t\tkey.lcore_id = lcore_id;\n \t\tkey.cipher_algo = (uint8_t)sa->cipher_algo;\n \t\tkey.auth_algo = (uint8_t)sa->auth_algo;\n \t\tkey.aead_algo = (uint8_t)sa->aead_algo;\ndiff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ipsec.h\nindex 29b9b283f0..6526a80d81 100644\n--- a/examples/ipsec-secgw/ipsec.h\n+++ b/examples/ipsec-secgw/ipsec.h\n@@ -256,11 +256,11 @@ extern struct offloads tx_offloads;\n * (hash key calculation reads 8 bytes if this struct is size 5 bytes).\n */\n struct cdev_key {\n-\tuint16_t lcore_id;\n+\tuint32_t lcore_id;\n \tuint8_t cipher_algo;\n \tuint8_t auth_algo;\n \tuint8_t aead_algo;\n-\tuint8_t padding[3]; /* padding to 8-byte size should be zeroed */\n+\tuint8_t padding; /* padding to 8-byte size should be zeroed */\n };\n \n struct socket_ctx {\n", "prefixes": [ "v7", "08/14" ] }