Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138801/?format=api
{ "id": 138801, "url": "http://patches.dpdk.org/api/patches/138801/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240326125554.138840-6-sivaprasad.tummala@amd.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240326125554.138840-6-sivaprasad.tummala@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240326125554.138840-6-sivaprasad.tummala@amd.com", "date": "2024-03-26T12:55:44", "name": "[v7,05/14] examples/l3fwd: fix lcore ID restriction", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d3d86b815664debfc4f4d7ea9869670172f6088e", "submitter": { "id": 2510, "url": "http://patches.dpdk.org/api/people/2510/?format=api", "name": "Sivaprasad Tummala", "email": "Sivaprasad.Tummala@amd.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240326125554.138840-6-sivaprasad.tummala@amd.com/mbox/", "series": [ { "id": 31619, "url": "http://patches.dpdk.org/api/series/31619/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31619", "date": "2024-03-26T12:55:39", "name": "fix lcore ID restriction", "version": 7, "mbox": "http://patches.dpdk.org/series/31619/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138801/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138801/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2C4BA43D51;\n\tTue, 26 Mar 2024 13:57:01 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 45AD5410DD;\n\tTue, 26 Mar 2024 13:56:51 +0100 (CET)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2059.outbound.protection.outlook.com [40.107.92.59])\n by mails.dpdk.org (Postfix) with ESMTP id 6D48141060;\n Tue, 26 Mar 2024 13:56:48 +0100 (CET)", "from BN1PR12CA0001.namprd12.prod.outlook.com (2603:10b6:408:e1::6)\n by CY8PR12MB8244.namprd12.prod.outlook.com (2603:10b6:930:72::7) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Tue, 26 Mar\n 2024 12:56:44 +0000", "from BN1PEPF0000468D.namprd05.prod.outlook.com\n (2603:10b6:408:e1:cafe::83) by BN1PR12CA0001.outlook.office365.com\n (2603:10b6:408:e1::6) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.13 via Frontend\n Transport; Tue, 26 Mar 2024 12:56:44 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n BN1PEPF0000468D.mail.protection.outlook.com (10.167.243.138) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7409.10 via Frontend Transport; Tue, 26 Mar 2024 12:56:44 +0000", "from ubuntu2004.linuxvmimages.local (10.180.168.240) by\n SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.35; Tue, 26 Mar 2024 07:56:39 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=hCKg2D4nLOHuSzDp45d1O8N1lX3t53/DaHEdUy5d5Rikyb6KsYz4GCD9GBkzTyeKxkLvnwEBCwuhdZNFsk4dZHFGH6JBfRXpwbn6K97iTZtgUMu7XRO6fzjJSwX6i9/ZBt+jU5vXV0kOuHH3PDB1aE/exb5ozNvRdRBVUx7q5wdUnnQQczyQkR7MpCMQvKfliBYU0cUoM3FnMYt0hyUn2+bY8iHMa38HrITfEYvHG7hh1je6AMGCnL3JC4V3yhBSv1ajAiTGjf32/3NruyhXJjV3cHXo+aoAmwsJLv3oD+9c2fiQb+vfWihJEC9Qx5XNjDwcArnZKacMQfq+v1397w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=dZYT+1yB5efFXrSo0WXRJmDmDr/zqly3szx85WuWMhQ=;\n b=Aw9clJD1dW6K/BBh1duSTrn8EyRxOjHf4IqzTdv+gkEE4nznk4uxcYRv/dUa5WeevfsSpfA8E++JYuf9WdHleWCVtZlmBS2NThL1cM2fwlrdZMhDTmSiS+vyTipiOr/WIjuwwycvK1crLKlc9VKOxCiF/JrabcJQSBVsfJ/jy7XK12v328m2Zapdk+wr+Hnt9Me+ZcTz1SIwplQS7K6oVW8T0VCfxPbDom6hgMiwKZABC6ZbNENnqVz/pb7ozvoULxSfJ6CHF5VH/db5Lu0sF5dl61nfGL9LkMLk3idfDDMMNxuNS5y7wWIkRwc+bdJbF4BsHbdbswEd/56CLbW0wA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=dZYT+1yB5efFXrSo0WXRJmDmDr/zqly3szx85WuWMhQ=;\n b=qByhrm3obhHBbR98KGWDRib2g0v2V6dek7FLJaAKvoAChK03gcg2oGWXwvyFEdV0LBM6AC3ukXEw0KoCyDNXdN8vQIduc734XjFqgd0Ar6sKcixs6GyhFhPNxtj33VN9wO/9ooTwwMb+ZHURdE/TgOHnfz6o5z8PCUrqNMELhvY=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Sivaprasad Tummala <sivaprasad.tummala@amd.com>", "To": "<david.hunt@intel.com>, <anatoly.burakov@intel.com>, <jerinj@marvell.com>,\n <radu.nicolau@intel.com>, <gakhil@marvell.com>,\n <cristian.dumitrescu@intel.com>, <ferruh.yigit@amd.com>,\n <konstantin.ananyev@huawei.com>, <stephen@networkplumber.org>,\n <mb@smartsharesystems.com>, <david.marchand@redhat.com>", "CC": "<dev@dpdk.org>, <stable@dpdk.org>", "Subject": "[PATCH v7 05/14] examples/l3fwd: fix lcore ID restriction", "Date": "Tue, 26 Mar 2024 13:55:44 +0100", "Message-ID": "<20240326125554.138840-6-sivaprasad.tummala@amd.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240326125554.138840-1-sivaprasad.tummala@amd.com>", "References": "<20240321184721.69040-1-sivaprasad.tummala@amd.com>\n <20240326125554.138840-1-sivaprasad.tummala@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BN1PEPF0000468D:EE_|CY8PR12MB8244:EE_", "X-MS-Office365-Filtering-Correlation-Id": "802ef878-05d6-45e1-d19a-08dc4d943077", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n rnb8tBN5KiDWTPqs5q4ZmXH/E1NDiwIR4PgnteKoQ23lOSMaXqJYoLFfsJtfjWuxXWrDLLsg9QRa2peTqbgm8TDG+6qgCipZO4E/BXST+uxsXv4GhpK5ZnTda4GifVA/K0ikLd0Ajf3HaROzDUY+Ql+PuW/Zcau0ReIkc/208qmGQFfDE2dyfiV7a1Au/H4yqur6ctjfX+VJ6MDR5280XgVXH57OLPJbLQhpmCrA/nmSwjZFOubYL2kvew+DlsdcvYjWoVDefYYPZ5GBPCX6+7g/ebkMqsIz8i6mQRm9kp679j3v8D5i0k6mbEQaTWs5IKB5gs6YVesxGi9FgEH4/dNmJi/z9j+LTXU3JZvZaZFrF+flHRlrVCduzNYIGNZ0fk3Pj9UxfAPfOwrdeFDNUthjXqmENAbuHeAHXpuyafJJlnI9SJTs3LXJElaS7dxPzjYlm2C5Bx9mNoQyDnJ5DA2mCsgH17XBrMS+sZ6f34ZkHkl6OwZfRU6hwboyPIxCHb3nvF/1ySdJcussD2rGFvziqeU+XZ12i/5HDWym8VBk0y4A2MtR9uk9e7nmk9Q1bc36eI1kqT/xUM0LlGn3qLAdzIZU/SHldxNosGrdB42gm4sbYehlKZcEtAnDDRx5x429Ut7Bac+oqs0Ba+ZnXirDCgqNXNP2ywZm6UQb8z8U8tdirLDU0gZK9p6D7tIP0bF2sIuhN/EWcUqxhEyFCS0UBT2B8l9VwP8z9WWmpLhME0rNuesNIx1fH7gJm+e0rKjXXEANf9OmwgxTyDmG3A==", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(36860700004)(82310400014)(376005)(7416005)(1800799015)(921011);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "26 Mar 2024 12:56:44.2956 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 802ef878-05d6-45e1-d19a-08dc4d943077", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN1PEPF0000468D.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY8PR12MB8244", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently the config option allows lcore IDs up to 255,\nirrespective of RTE_MAX_LCORES and needs to be fixed.\n\nThe patch fixes these constraints by allowing all\nlcore IDs up to RTE_MAX_LCORES.\n\nFixes: af75078fece3 (\"first public release\")\nCc: stable@dpdk.org\n\nSigned-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>\nAcked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Ferruh Yigit <ferruh.yigit@amd.com>\n---\n examples/l3fwd/main.c | 20 ++++++++++++--------\n 1 file changed, 12 insertions(+), 8 deletions(-)", "diff": "diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c\nindex 039207b06c..47baf464e2 100644\n--- a/examples/l3fwd/main.c\n+++ b/examples/l3fwd/main.c\n@@ -99,7 +99,7 @@ struct parm_cfg parm_config;\n struct lcore_params {\n \tuint16_t port_id;\n \tuint16_t queue_id;\n-\tuint8_t lcore_id;\n+\tuint32_t lcore_id;\n } __rte_cache_aligned;\n \n static struct lcore_params lcore_params_array[MAX_LCORE_PARAMS];\n@@ -293,7 +293,7 @@ static int\n check_lcore_params(void)\n {\n \tuint16_t queue, i;\n-\tuint8_t lcore;\n+\tuint32_t lcore;\n \tint socketid;\n \n \tfor (i = 0; i < nb_lcore_params; ++i) {\n@@ -304,12 +304,12 @@ check_lcore_params(void)\n \t\t}\n \t\tlcore = lcore_params[i].lcore_id;\n \t\tif (!rte_lcore_is_enabled(lcore)) {\n-\t\t\tprintf(\"error: lcore %hhu is not enabled in lcore mask\\n\", lcore);\n+\t\t\tprintf(\"error: lcore %u is not enabled in lcore mask\\n\", lcore);\n \t\t\treturn -1;\n \t\t}\n \t\tif ((socketid = rte_lcore_to_socket_id(lcore) != 0) &&\n \t\t\t(numa_on == 0)) {\n-\t\t\tprintf(\"warning: lcore %hhu is on socket %d with numa off \\n\",\n+\t\t\tprintf(\"warning: lcore %u is on socket %d with numa off\\n\",\n \t\t\t\tlcore, socketid);\n \t\t}\n \t}\n@@ -359,14 +359,14 @@ static int\n init_lcore_rx_queues(void)\n {\n \tuint16_t i, nb_rx_queue;\n-\tuint8_t lcore;\n+\tuint32_t lcore;\n \n \tfor (i = 0; i < nb_lcore_params; ++i) {\n \t\tlcore = lcore_params[i].lcore_id;\n \t\tnb_rx_queue = lcore_conf[lcore].n_rx_queue;\n \t\tif (nb_rx_queue >= MAX_RX_QUEUE_PER_LCORE) {\n \t\t\tprintf(\"error: too many queues (%u) for lcore: %u\\n\",\n-\t\t\t\t(unsigned)nb_rx_queue + 1, (unsigned)lcore);\n+\t\t\t\t(unsigned int)nb_rx_queue + 1, lcore);\n \t\t\treturn -1;\n \t\t} else {\n \t\t\tlcore_conf[lcore].rx_queue_list[nb_rx_queue].port_id =\n@@ -500,7 +500,11 @@ parse_config(const char *q_arg)\n \tchar *str_fld[_NUM_FLD];\n \tint i;\n \tunsigned size;\n-\tuint16_t max_fld[_NUM_FLD] = {255, RTE_MAX_QUEUES_PER_PORT, 255};\n+\tuint16_t max_fld[_NUM_FLD] = {\n+\t\t255,\n+\t\tRTE_MAX_QUEUES_PER_PORT,\n+\t\tRTE_MAX_LCORE\n+\t};\n \n \tnb_lcore_params = 0;\n \n@@ -532,7 +536,7 @@ parse_config(const char *q_arg)\n \t\tlcore_params_array[nb_lcore_params].queue_id =\n \t\t\t(uint16_t)int_fld[FLD_QUEUE];\n \t\tlcore_params_array[nb_lcore_params].lcore_id =\n-\t\t\t(uint8_t)int_fld[FLD_LCORE];\n+\t\t\t(uint32_t)int_fld[FLD_LCORE];\n \t\t++nb_lcore_params;\n \t}\n \tlcore_params = lcore_params_array;\n", "prefixes": [ "v7", "05/14" ] }