Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138748/?format=api
{ "id": 138748, "url": "http://patches.dpdk.org/api/patches/138748/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240322135328.393562-1-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240322135328.393562-1-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240322135328.393562-1-david.marchand@redhat.com", "date": "2024-03-22T13:53:28", "name": "table: remove experimental CRC API for some arches", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1f3d1b69398ae4e690a2207281ce342328715578", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240322135328.393562-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 31603, "url": "http://patches.dpdk.org/api/series/31603/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31603", "date": "2024-03-22T13:53:28", "name": "table: remove experimental CRC API for some arches", "version": 1, "mbox": "http://patches.dpdk.org/series/31603/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138748/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138748/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5458543D06;\n\tFri, 22 Mar 2024 14:54:06 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 44D4642E9B;\n\tFri, 22 Mar 2024 14:54:06 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 3D2A340284\n for <dev@dpdk.org>; Fri, 22 Mar 2024 14:54:04 +0100 (CET)", "from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])\n by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-132-uUsr8Sb-PUiqQAsBBCqwfQ-1; Fri,\n 22 Mar 2024 09:54:02 -0400", "from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com\n [10.11.54.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4E1481C0173E;\n Fri, 22 Mar 2024 13:53:58 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.224.28])\n by smtp.corp.redhat.com (Postfix) with ESMTP id B23073C20;\n Fri, 22 Mar 2024 13:53:57 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1711115643;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=KCygQd9Sp9MHGLmpE3rAOCXBUT4zFz3pYdomjSif9G8=;\n b=GsBz9SKmgi+clV3gSppPnuYBrnMH9JhEZt+fF5dUYnsEVVW8U/4XYcBHxadITdNh0AZtkP\n nzTqrPimYG7zx8Yh9EHgtKcrwx78pDrW5wZ5QDba4jDiS2wF9zPGVaiht8JTkJjuJLxLIm\n YNkJPjgUdHBNF7cIag1ncHLJJzHY3A8=", "X-MC-Unique": "uUsr8Sb-PUiqQAsBBCqwfQ-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "Subject": "[PATCH] table: remove experimental CRC API for some arches", "Date": "Fri, 22 Mar 2024 14:53:28 +0100", "Message-ID": "<20240322135328.393562-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.1", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "x86 and ARM architectures provide a non-experimental implementation for\nrte_crc32_u64().\nExperimental API rte_crc32_u64_generic() was only exported for other\narches.\n\nLeaving this API exposed could result in portability issues: an\napplication using rte_crc32_u64_generic() would not compile on x86 or\nARM.\n\nMove this symbol code in the only caller of the table library, and\nremove this symbol.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n lib/table/rte_table_hash_func.h | 29 +++++++++++------------------\n 1 file changed, 11 insertions(+), 18 deletions(-)", "diff": "diff --git a/lib/table/rte_table_hash_func.h b/lib/table/rte_table_hash_func.h\nindex a962ec2f68..aa779c2182 100644\n--- a/lib/table/rte_table_hash_func.h\n+++ b/lib/table/rte_table_hash_func.h\n@@ -14,23 +14,6 @@ extern \"C\" {\n #include <rte_compat.h>\n #include <rte_common.h>\n \n-__rte_experimental\n-static inline uint64_t\n-rte_crc32_u64_generic(uint64_t crc, uint64_t value)\n-{\n-\tint i;\n-\n-\tcrc = (crc & 0xFFFFFFFFLLU) ^ value;\n-\tfor (i = 63; i >= 0; i--) {\n-\t\tuint64_t mask;\n-\n-\t\tmask = -(crc & 1LLU);\n-\t\tcrc = (crc >> 1LLU) ^ (0x82F63B78LLU & mask);\n-\t}\n-\n-\treturn crc;\n-}\n-\n #if defined(RTE_ARCH_X86_64)\n \n #include <x86intrin.h>\n@@ -48,7 +31,17 @@ rte_crc32_u64(uint64_t crc, uint64_t v)\n static inline uint64_t\n rte_crc32_u64(uint64_t crc, uint64_t v)\n {\n-\treturn rte_crc32_u64_generic(crc, v);\n+\tint i;\n+\n+\tcrc = (crc & 0xFFFFFFFFLLU) ^ v;\n+\tfor (i = 63; i >= 0; i--) {\n+\t\tuint64_t mask;\n+\n+\t\tmask = -(crc & 1LLU);\n+\t\tcrc = (crc >> 1LLU) ^ (0x82F63B78LLU & mask);\n+\t}\n+\n+\treturn crc;\n }\n \n #endif\n", "prefixes": [] }