Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138739/?format=api
{ "id": 138739, "url": "http://patches.dpdk.org/api/patches/138739/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240322154637.1346239-1-jingjing.wu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240322154637.1346239-1-jingjing.wu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240322154637.1346239-1-jingjing.wu@intel.com", "date": "2024-03-22T15:46:37", "name": "[v2] graph: fix head move when graph walk in mcore dispatch", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "dc9fa0fcaf2a978d14c2e1ad1f0252ae84757fb8", "submitter": { "id": 47, "url": "http://patches.dpdk.org/api/people/47/?format=api", "name": "Jingjing Wu", "email": "jingjing.wu@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240322154637.1346239-1-jingjing.wu@intel.com/mbox/", "series": [ { "id": 31594, "url": "http://patches.dpdk.org/api/series/31594/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31594", "date": "2024-03-22T15:46:37", "name": "[v2] graph: fix head move when graph walk in mcore dispatch", "version": 2, "mbox": "http://patches.dpdk.org/series/31594/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138739/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138739/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DB67743D1E;\n\tFri, 22 Mar 2024 08:54:46 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9471F42DF1;\n\tFri, 22 Mar 2024 08:54:46 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.15])\n by mails.dpdk.org (Postfix) with ESMTP id 36E714003C\n for <dev@dpdk.org>; Fri, 22 Mar 2024 08:54:44 +0100 (CET)", "from orviesa005.jf.intel.com ([10.64.159.145])\n by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Mar 2024 00:54:43 -0700", "from dpdk-wujingji-spr.sh.intel.com ([10.67.111.103])\n by orviesa005.jf.intel.com with ESMTP; 22 Mar 2024 00:54:42 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1711094084; x=1742630084;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=CZO8OW3lwL+kxAVB96e7MrjR+ogwZsOG0ITm4MsfNCQ=;\n b=gkRQHTcJ2XFXlfNma3gnd/vxxF+i1iQkOM593AVi7/+2wy0PFCz9T43r\n P39l2V2Dd3PzcUtxZNmbDhn8W3qbF1Sx/0994fVmnDEMfY6+eSMsnP2IQ\n ec9ASTr15KP85bLvpnrNz7WToyCaLOVUA3QsniZLvKtrj7Rn+eMZj9/qT\n +7LzXYt9VO4Z/OFCH94VaingY+lq1OBQ4A1dMP+FPz7RxjI6+Xeh9Zjs5\n Kj5QaAzLuBhhNCMCypbs84JGI0DFkeMr1kbIAFysE8FVfHjOYm5d8Elbd\n EJRdxUEE7UWGlCp/xx/AChKhN/5+g7GsSD/hiozdhOkV4DB6X0PQJSEo3 w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11020\"; a=\"6314441\"", "E=Sophos;i=\"6.07,145,1708416000\";\n d=\"scan'208\";a=\"6314441\"", "E=Sophos;i=\"6.07,145,1708416000\"; d=\"scan'208\";a=\"19531810\"" ], "X-ExtLoop1": "1", "From": "Jingjing Wu <jingjing.wu@intel.com>", "To": "dev@dpdk.org", "Cc": "jingjing.wu@intel.com, jerinj@marvell.com, pbhagavatula@marvell.com,\n zhirun.yan@intel.com", "Subject": "[PATCH v2] graph: fix head move when graph walk in mcore dispatch", "Date": "Fri, 22 Mar 2024 15:46:37 +0000", "Message-Id": "<20240322154637.1346239-1-jingjing.wu@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240319141454.3275543-1-jingjing.wu@intel.com>", "References": "<20240319141454.3275543-1-jingjing.wu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Head move happens before the core id check, which will cause the last\nsource node be executed even core id is not correct. This patch changes\nhead check to less than 1 instead of 0 to fix this issue.\n\nFixes: 35dfd9b9fd85 (\"graph: introduce graph walk by cross-core dispatch\")\n\nSigned-off-by: Jingjing Wu <jingjing.wu@intel.com>\n---\n lib/graph/rte_graph_model_mcore_dispatch.h | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/lib/graph/rte_graph_model_mcore_dispatch.h b/lib/graph/rte_graph_model_mcore_dispatch.h\nindex 75ec388cad..1cc75b7ac4 100644\n--- a/lib/graph/rte_graph_model_mcore_dispatch.h\n+++ b/lib/graph/rte_graph_model_mcore_dispatch.h\n@@ -100,9 +100,8 @@ rte_graph_walk_mcore_dispatch(struct rte_graph *graph)\n \t\tnode = (struct rte_node *)RTE_PTR_ADD(graph, cir_start[(int32_t)head++]);\n \n \t\t/* skip the src nodes which not bind with current worker */\n-\t\tif ((int32_t)head < 0 && node->dispatch.lcore_id != graph->dispatch.lcore_id)\n+\t\tif ((int32_t)head < 1 && node->dispatch.lcore_id != graph->dispatch.lcore_id)\n \t\t\tcontinue;\n-\n \t\t/* Schedule the node until all task/objs are done */\n \t\tif (node->dispatch.lcore_id != RTE_MAX_LCORE &&\n \t\t graph->dispatch.lcore_id != node->dispatch.lcore_id &&\n", "prefixes": [ "v2" ] }