Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138735/?format=api
{ "id": 138735, "url": "http://patches.dpdk.org/api/patches/138735/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240322070923.244417-5-huangdengdui@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240322070923.244417-5-huangdengdui@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240322070923.244417-5-huangdengdui@huawei.com", "date": "2024-03-22T07:09:21", "name": "[v2,4/6] net/hns3: use parse link mode info function", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9986612e4b4af69e0423d4798eb51b8a475d756c", "submitter": { "id": 3066, "url": "http://patches.dpdk.org/api/people/3066/?format=api", "name": "huangdengdui", "email": "huangdengdui@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240322070923.244417-5-huangdengdui@huawei.com/mbox/", "series": [ { "id": 31593, "url": "http://patches.dpdk.org/api/series/31593/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31593", "date": "2024-03-22T07:09:17", "name": "support setting lanes", "version": 2, "mbox": "http://patches.dpdk.org/series/31593/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138735/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138735/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E042243D1E;\n\tFri, 22 Mar 2024 08:09:46 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 68A7842E8A;\n\tFri, 22 Mar 2024 08:09:32 +0100 (CET)", "from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35])\n by mails.dpdk.org (Postfix) with ESMTP id A581042E62\n for <dev@dpdk.org>; Fri, 22 Mar 2024 08:09:26 +0100 (CET)", "from mail.maildlp.com (unknown [172.19.163.44])\n by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4V1D095XF8z1R7lC;\n Fri, 22 Mar 2024 15:06:49 +0800 (CST)", "from dggpeml500011.china.huawei.com (unknown [7.185.36.84])\n by mail.maildlp.com (Postfix) with ESMTPS id 29127140133;\n Fri, 22 Mar 2024 15:09:25 +0800 (CST)", "from localhost.huawei.com (10.50.165.33) by\n dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.1.2507.35; Fri, 22 Mar 2024 15:09:24 +0800" ], "From": "Dengdui Huang <huangdengdui@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@amd.com>, <aman.deep.singh@intel.com>,\n <yuying.zhang@intel.com>, <thomas@monjalon.net>,\n <andrew.rybchenko@oktetlabs.ru>, <damodharam.ammepalli@broadcom.com>,\n <stephen@networkplumber.org>, <jerinjacobk@gmail.com>,\n <ajit.khaparde@broadcom.com>, <liuyonglong@huawei.com>,\n <fengchengwen@huawei.com>, <haijie1@huawei.com>, <lihuisong@huawei.com>", "Subject": "[PATCH v2 4/6] net/hns3: use parse link mode info function", "Date": "Fri, 22 Mar 2024 15:09:21 +0800", "Message-ID": "<20240322070923.244417-5-huangdengdui@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20240322070923.244417-1-huangdengdui@huawei.com>", "References": "<20240312075238.3319480-4-huangdengdui@huawei.com>\n <20240322070923.244417-1-huangdengdui@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.50.165.33]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n dggpeml500011.china.huawei.com (7.185.36.84)", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch use the framework public function to\nreplace the driver's private function.\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 51 +++++++---------------------------\n 1 file changed, 10 insertions(+), 41 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex ecd3b2ef64..1b380ac75f 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -4810,45 +4810,6 @@ hns3_check_port_speed(struct hns3_hw *hw, uint32_t link_speeds)\n \treturn 0;\n }\n \n-static uint32_t\n-hns3_get_link_speed(uint32_t link_speeds)\n-{\n-\tuint32_t speed = RTE_ETH_SPEED_NUM_NONE;\n-\n-\tif (link_speeds & RTE_ETH_LINK_SPEED_10M ||\n-\t link_speeds & RTE_ETH_LINK_SPEED_10M_HD)\n-\t\tspeed = RTE_ETH_SPEED_NUM_10M;\n-\tif (link_speeds & RTE_ETH_LINK_SPEED_100M ||\n-\t link_speeds & RTE_ETH_LINK_SPEED_100M_HD)\n-\t\tspeed = RTE_ETH_SPEED_NUM_100M;\n-\tif (link_speeds & RTE_ETH_LINK_SPEED_1G)\n-\t\tspeed = RTE_ETH_SPEED_NUM_1G;\n-\tif (link_speeds & RTE_ETH_LINK_SPEED_10G)\n-\t\tspeed = RTE_ETH_SPEED_NUM_10G;\n-\tif (link_speeds & RTE_ETH_LINK_SPEED_25G)\n-\t\tspeed = RTE_ETH_SPEED_NUM_25G;\n-\tif (link_speeds & RTE_ETH_LINK_SPEED_40G)\n-\t\tspeed = RTE_ETH_SPEED_NUM_40G;\n-\tif (link_speeds & RTE_ETH_LINK_SPEED_50G)\n-\t\tspeed = RTE_ETH_SPEED_NUM_50G;\n-\tif (link_speeds & RTE_ETH_LINK_SPEED_100G)\n-\t\tspeed = RTE_ETH_SPEED_NUM_100G;\n-\tif (link_speeds & RTE_ETH_LINK_SPEED_200G)\n-\t\tspeed = RTE_ETH_SPEED_NUM_200G;\n-\n-\treturn speed;\n-}\n-\n-static uint8_t\n-hns3_get_link_duplex(uint32_t link_speeds)\n-{\n-\tif ((link_speeds & RTE_ETH_LINK_SPEED_10M_HD) ||\n-\t (link_speeds & RTE_ETH_LINK_SPEED_100M_HD))\n-\t\treturn RTE_ETH_LINK_HALF_DUPLEX;\n-\telse\n-\t\treturn RTE_ETH_LINK_FULL_DUPLEX;\n-}\n-\n static int\n hns3_set_copper_port_link_speed(struct hns3_hw *hw,\n \t\t\t\tstruct hns3_set_link_speed_cfg *cfg)\n@@ -4980,14 +4941,22 @@ static int\n hns3_apply_link_speed(struct hns3_hw *hw)\n {\n \tstruct rte_eth_conf *conf = &hw->data->dev_conf;\n+\tstruct rte_eth_link_mode_info mode_info = {0};\n \tstruct hns3_set_link_speed_cfg cfg;\n+\tint ret;\n \n \tmemset(&cfg, 0, sizeof(struct hns3_set_link_speed_cfg));\n \tcfg.autoneg = (conf->link_speeds == RTE_ETH_LINK_SPEED_AUTONEG) ?\n \t\t\tRTE_ETH_LINK_AUTONEG : RTE_ETH_LINK_FIXED;\n \tif (cfg.autoneg != RTE_ETH_LINK_AUTONEG) {\n-\t\tcfg.speed = hns3_get_link_speed(conf->link_speeds);\n-\t\tcfg.duplex = hns3_get_link_duplex(conf->link_speeds);\n+\t\tret = rte_eth_link_mode_parse(conf->link_speeds, &mode_info);\n+\t\tif (ret) {\n+\t\t\thns3_err(hw, \"failed to parse link mode, ret = %d\", ret);\n+\t\t\treturn ret;\n+\t\t}\n+\t\tcfg.speed = mode_onfo.speed_num;\n+\t\tcfg.speed = mode_info.speed_num;\n+\t\tcfg.duplex = mode_info.duplex;\n \t}\n \n \treturn hns3_set_port_link_speed(hw, &cfg);\n", "prefixes": [ "v2", "4/6" ] }