Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138676/?format=api
{ "id": 138676, "url": "http://patches.dpdk.org/api/patches/138676/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240321184721.69040-5-sivaprasad.tummala@amd.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240321184721.69040-5-sivaprasad.tummala@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240321184721.69040-5-sivaprasad.tummala@amd.com", "date": "2024-03-21T18:47:10", "name": "[v6,04/14] examples/ipsec-secgw: fix queue ID restriction", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e55a24c4e0ccc710c526a8cc697234adebee65d5", "submitter": { "id": 2510, "url": "http://patches.dpdk.org/api/people/2510/?format=api", "name": "Sivaprasad Tummala", "email": "Sivaprasad.Tummala@amd.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240321184721.69040-5-sivaprasad.tummala@amd.com/mbox/", "series": [ { "id": 31590, "url": "http://patches.dpdk.org/api/series/31590/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31590", "date": "2024-03-21T18:47:07", "name": "fix lcore ID restriction", "version": 6, "mbox": "http://patches.dpdk.org/series/31590/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138676/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138676/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5DAAC43D0F;\n\tThu, 21 Mar 2024 19:48:35 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1E94342E6B;\n\tThu, 21 Mar 2024 19:48:34 +0100 (CET)", "from NAM04-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam04on2064.outbound.protection.outlook.com [40.107.101.64])\n by mails.dpdk.org (Postfix) with ESMTP id 651CE42E6B\n for <dev@dpdk.org>; Thu, 21 Mar 2024 19:48:32 +0100 (CET)", "from MN2PR04CA0005.namprd04.prod.outlook.com (2603:10b6:208:d4::18)\n by PH8PR12MB7374.namprd12.prod.outlook.com (2603:10b6:510:216::15)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.34; Thu, 21 Mar\n 2024 18:48:29 +0000", "from BL6PEPF0001AB78.namprd02.prod.outlook.com\n (2603:10b6:208:d4:cafe::16) by MN2PR04CA0005.outlook.office365.com\n (2603:10b6:208:d4::18) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.27 via Frontend\n Transport; Thu, 21 Mar 2024 18:48:29 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n BL6PEPF0001AB78.mail.protection.outlook.com (10.167.242.171) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7409.10 via Frontend Transport; Thu, 21 Mar 2024 18:48:28 +0000", "from ubuntu2004.linuxvmimages.local (10.180.168.240) by\n SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.35; Thu, 21 Mar 2024 13:48:25 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=AIDbig1W8dO5EG7zVuFqd7UAGxiEiaXCqELdjHlbOu/opN7ihhiShJcU+BbHdKDWJ1A44YApu39oc9RkQHPhb5Sla0oltkfKwn02B2sYXg/OFXIKvfriGCNdIJw/6spethrJI3nVzMlMCEq/H0Ghk7o52MLhGRWTDrzEpDYecMci/P6P2kV6/6Oz4UaAGU1riSXJ35kUoY2n5c5B8+mNghzWWQ7ARMgbhXlCF93oZ0dfGavMHgHJ0A/CjHB8kYi7iwVbYeCqG+Nqf8ic4Y9zKOPu51sNxovAIVHeNAJmOhRKC9FqFh05oHeV0eGxHJvIbYuDgkuR/ctBFCMKliUBqw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=7B9NXtAogO5duT3T8ebCvhVu80cSN9+05fr8y4JFmMs=;\n b=SD3FvK5s0hR0sf9ybGeAyP+ZXNHEHouV3sFud3ftnsg9wx/SLY/wlhjKm6YAEBKRov5FLVyqEAQErD1b/G65jZlRUjLwqiD9F0a78x6kAkH7sP0Nnymq0gpz6/VYGfWfClgzlshrnndYnAyurPQvU2EITmUO7XWAxHQwIR1ye/s/7x5QyQnwL83niUsqp8lXJY4ftXJ0HXz5HJr4We+Spbca+PBXKR4L0jYCe5Kla5qJwa5pGuG+N6FwTXjty0cG/9CYK85jv+sTCQZLhd/AcfXX8ZZd2C0kRO6wHNA/c7Y0lrb08X60gH0E1RnlKrpcl9LTz8yHhHEQiH8yOhTZcg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=7B9NXtAogO5duT3T8ebCvhVu80cSN9+05fr8y4JFmMs=;\n b=rdjr8GCtH1rxRg3NOPgbnC+K9M1vMJLnPqB0ZvR6Vp/5AzCp16MHEaSKBbN0TjIjnifLEbjBqB23WY8WcCq7Ka2/SxE9xuwF2yPSjtNb/u8w7uDyio6AGVJQzh6SIsRgmCEIi7r4IaoANJJcuxg+lUmRt5EMovkqY1M8ydgBlSs=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Sivaprasad Tummala <sivaprasad.tummala@amd.com>", "To": "<david.hunt@intel.com>, <anatoly.burakov@intel.com>, <jerinj@marvell.com>,\n <radu.nicolau@intel.com>, <gakhil@marvell.com>,\n <cristian.dumitrescu@intel.com>, <ferruh.yigit@amd.com>,\n <konstantin.ananyev@huawei.com>, <stephen@networkplumber.org>,\n <mb@smartsharesystems.com>, <thomas@monjalon.net>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH v6 04/14] examples/ipsec-secgw: fix queue ID restriction", "Date": "Thu, 21 Mar 2024 19:47:10 +0100", "Message-ID": "<20240321184721.69040-5-sivaprasad.tummala@amd.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240321184721.69040-1-sivaprasad.tummala@amd.com>", "References": "<20240318173146.24303-1-sivaprasad.tummala@amd.com>\n <20240321184721.69040-1-sivaprasad.tummala@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BL6PEPF0001AB78:EE_|PH8PR12MB7374:EE_", "X-MS-Office365-Filtering-Correlation-Id": "70021199-8c17-429c-b60a-08dc49d77fc0", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n w5CJr9mF7CfePnX4JjIrIYkeJvNFj6TofYsdLjewboolzlC1ibFwfu+P9pY8q671dLGlJ/J1T8B8Ew/LCH02TpR+kAxBp+4qeRTE8+Ih72aKkYcYdM3GA06zbnORDIo3NG5B87ir5EJemwmVrc7R90b1VlywGua5OJGouerO0hIKxbpr7HLh1HBtCo4Hj67H1oYvgFUGbwd4WfM7XaN4oRNe6DK7p7VvMT5CMC6f1jnKMxl4R5s3Py0jbDbfB80tQep61Y8a5yhtHIF7F+NoH7o6QHn78wjJB8/q+HEqCiFYpVPSCdm6qhmglp0EuJmL9wWZOWkSCyOgXXFJawNF6pW6f+J1sa324vtGyYtVGlNvXajnCPinjqTI6hSpT+NwUGSRE+kWazCyvg1MZ2AUEcLtUrZSIk7tYtWPHfPUhzkeqPU4RGnbuWtCBWk1Gov/va95iUk67M6JYgV6LZMlJjgQk9eU+4WI8dT4K3Wp9TY0PgmjoNM1lcTDOAqCxMdIvnxLh4QuZukn/9PKDB0sikCImOe3xyDz6pliliAAykV54i/qvWzBRTp31wZIkuIKaPrHx1jxkFLaDwxksv7zjcVSM6eSZopUEHFF5Fj/SvE+/kGl9i5EEen7VbDH8KSRrs2V2nNaJQ0OceT3WDhskerDPYxiD02p1n/VOVU7f66o78AIBDIHC919IKYyrLrvahtKsOkHD5rj2ma0Iv4eebXIjuH8G1xvA57qsU6J3cOUBgpBJPIRn3eyOwZlajlVeB4eFI9ABrUzfcc9aJsA6g==", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(82310400014)(36860700004)(1800799015)(7416005)(376005)(921011);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "21 Mar 2024 18:48:28.8649 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 70021199-8c17-429c-b60a-08dc49d77fc0", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BL6PEPF0001AB78.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH8PR12MB7374", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently application supports queue IDs up to 255\nand max queues of 256 irrespective of device support.\nThis limits the number of active lcores to 256.\n\nThe patch fixes these constraints by increasing\nthe queue IDs to support up to 65535.\n\nSigned-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>\nAcked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Ferruh Yigit <ferruh.yigit@amd.com>\n---\n examples/ipsec-secgw/ipsec-secgw.c | 20 ++++++++++----------\n examples/ipsec-secgw/ipsec.h | 2 +-\n examples/ipsec-secgw/ipsec_worker.c | 10 ++++------\n 3 files changed, 15 insertions(+), 17 deletions(-)", "diff": "diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c\nindex 45a303850d..106a058b60 100644\n--- a/examples/ipsec-secgw/ipsec-secgw.c\n+++ b/examples/ipsec-secgw/ipsec-secgw.c\n@@ -220,7 +220,7 @@ static const char *cfgfile;\n \n struct lcore_params {\n \tuint16_t port_id;\n-\tuint8_t queue_id;\n+\tuint16_t queue_id;\n \tuint8_t lcore_id;\n } __rte_cache_aligned;\n \n@@ -695,8 +695,7 @@ ipsec_poll_mode_worker(void)\n \tstruct rte_mbuf *pkts[MAX_PKT_BURST];\n \tuint32_t lcore_id;\n \tuint64_t prev_tsc, diff_tsc, cur_tsc;\n-\tuint16_t i, nb_rx, portid;\n-\tuint8_t queueid;\n+\tuint16_t i, nb_rx, portid, queueid;\n \tstruct lcore_conf *qconf;\n \tint32_t rc, socket_id;\n \tconst uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1)\n@@ -743,7 +742,7 @@ ipsec_poll_mode_worker(void)\n \t\tportid = rxql[i].port_id;\n \t\tqueueid = rxql[i].queue_id;\n \t\tRTE_LOG(INFO, IPSEC,\n-\t\t\t\" -- lcoreid=%u portid=%u rxqueueid=%hhu\\n\",\n+\t\t\t\" -- lcoreid=%u portid=%u rxqueueid=%hu\\n\",\n \t\t\tlcore_id, portid, queueid);\n \t}\n \n@@ -788,8 +787,7 @@ int\n check_flow_params(uint16_t fdir_portid, uint8_t fdir_qid)\n {\n \tuint16_t i;\n-\tuint16_t portid;\n-\tuint8_t queueid;\n+\tuint16_t portid, queueid;\n \n \tfor (i = 0; i < nb_lcore_params; ++i) {\n \t\tportid = lcore_params_array[i].port_id;\n@@ -851,7 +849,7 @@ check_poll_mode_params(struct eh_conf *eh_conf)\n \treturn 0;\n }\n \n-static uint8_t\n+static uint16_t\n get_port_nb_rx_queues(const uint16_t port)\n {\n \tint32_t queue = -1;\n@@ -862,7 +860,7 @@ get_port_nb_rx_queues(const uint16_t port)\n \t\t\t\tlcore_params[i].queue_id > queue)\n \t\t\tqueue = lcore_params[i].queue_id;\n \t}\n-\treturn (uint8_t)(++queue);\n+\treturn (uint16_t)(++queue);\n }\n \n static int32_t\n@@ -1050,6 +1048,8 @@ parse_config(const char *q_arg)\n \tchar *str_fld[_NUM_FLD];\n \tint32_t i;\n \tuint32_t size;\n+\tuint32_t max_fld[_NUM_FLD] = {USHRT_MAX,\n+\t\t\t\tUSHRT_MAX, UCHAR_MAX};\n \n \tnb_lcore_params = 0;\n \n@@ -1070,7 +1070,7 @@ parse_config(const char *q_arg)\n \t\tfor (i = 0; i < _NUM_FLD; i++) {\n \t\t\terrno = 0;\n \t\t\tint_fld[i] = strtoul(str_fld[i], &end, 0);\n-\t\t\tif (errno != 0 || end == str_fld[i] || int_fld[i] > 255)\n+\t\t\tif (errno != 0 || end == str_fld[i] || int_fld[i] > max_fld[i])\n \t\t\t\treturn -1;\n \t\t}\n \t\tif (nb_lcore_params >= MAX_LCORE_PARAMS) {\n@@ -1081,7 +1081,7 @@ parse_config(const char *q_arg)\n \t\tlcore_params_array[nb_lcore_params].port_id =\n \t\t\t(uint8_t)int_fld[FLD_PORT];\n \t\tlcore_params_array[nb_lcore_params].queue_id =\n-\t\t\t(uint8_t)int_fld[FLD_QUEUE];\n+\t\t\t(uint16_t)int_fld[FLD_QUEUE];\n \t\tlcore_params_array[nb_lcore_params].lcore_id =\n \t\t\t(uint8_t)int_fld[FLD_LCORE];\n \t\t++nb_lcore_params;\ndiff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ipsec.h\nindex bdcada1c40..29b9b283f0 100644\n--- a/examples/ipsec-secgw/ipsec.h\n+++ b/examples/ipsec-secgw/ipsec.h\n@@ -285,7 +285,7 @@ struct cnt_blk {\n \n struct lcore_rx_queue {\n \tuint16_t port_id;\n-\tuint8_t queue_id;\n+\tuint16_t queue_id;\n \tvoid *sec_ctx;\n } __rte_cache_aligned;\n \ndiff --git a/examples/ipsec-secgw/ipsec_worker.c b/examples/ipsec-secgw/ipsec_worker.c\nindex 8d122e8519..90a4c38ba4 100644\n--- a/examples/ipsec-secgw/ipsec_worker.c\n+++ b/examples/ipsec-secgw/ipsec_worker.c\n@@ -1598,8 +1598,7 @@ ipsec_poll_mode_wrkr_inl_pr(void)\n \tint32_t socket_id;\n \tuint32_t lcore_id;\n \tint32_t i, nb_rx;\n-\tuint16_t portid;\n-\tuint8_t queueid;\n+\tuint16_t portid, queueid;\n \n \tprev_tsc = 0;\n \tlcore_id = rte_lcore_id();\n@@ -1633,7 +1632,7 @@ ipsec_poll_mode_wrkr_inl_pr(void)\n \t\tportid = rxql[i].port_id;\n \t\tqueueid = rxql[i].queue_id;\n \t\tRTE_LOG(INFO, IPSEC,\n-\t\t\t\" -- lcoreid=%u portid=%u rxqueueid=%hhu\\n\",\n+\t\t\t\" -- lcoreid=%u portid=%u rxqueueid=%hu\\n\",\n \t\t\tlcore_id, portid, queueid);\n \t}\n \n@@ -1729,8 +1728,7 @@ ipsec_poll_mode_wrkr_inl_pr_ss(void)\n \tuint32_t i, nb_rx, j;\n \tint32_t socket_id;\n \tuint32_t lcore_id;\n-\tuint16_t portid;\n-\tuint8_t queueid;\n+\tuint16_t portid, queueid;\n \n \tprev_tsc = 0;\n \tlcore_id = rte_lcore_id();\n@@ -1764,7 +1762,7 @@ ipsec_poll_mode_wrkr_inl_pr_ss(void)\n \t\tportid = rxql[i].port_id;\n \t\tqueueid = rxql[i].queue_id;\n \t\tRTE_LOG(INFO, IPSEC,\n-\t\t\t\" -- lcoreid=%u portid=%u rxqueueid=%hhu\\n\",\n+\t\t\t\" -- lcoreid=%u portid=%u rxqueueid=%hu\\n\",\n \t\t\tlcore_id, portid, queueid);\n \t}\n \n", "prefixes": [ "v6", "04/14" ] }