Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138671/?format=api
{ "id": 138671, "url": "http://patches.dpdk.org/api/patches/138671/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240321161146.340421-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240321161146.340421-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240321161146.340421-7-stephen@networkplumber.org", "date": "2024-03-21T16:00:22", "name": "[v10,06/10] eal: change rte_exit() output to match rte_log()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f471f77271394b9b8bf0741e24817638e83a8e2c", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240321161146.340421-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 31589, "url": "http://patches.dpdk.org/api/series/31589/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31589", "date": "2024-03-21T16:00:17", "name": "Logging enhancements.", "version": 10, "mbox": "http://patches.dpdk.org/series/31589/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138671/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/138671/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1127743D17;\n\tThu, 21 Mar 2024 17:19:22 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E955F42E19;\n\tThu, 21 Mar 2024 17:19:21 +0100 (CET)", "from mail-qt1-f178.google.com (mail-qt1-f178.google.com\n [209.85.160.178])\n by mails.dpdk.org (Postfix) with ESMTP id 1ACA942E05\n for <dev@dpdk.org>; Thu, 21 Mar 2024 17:19:20 +0100 (CET)", "by mail-qt1-f178.google.com with SMTP id\n d75a77b69052e-42a0ba5098bso8578211cf.0\n for <dev@dpdk.org>; Thu, 21 Mar 2024 09:19:20 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n w62-20020a638241000000b005e485fbd455sm41815pgd.45.2024.03.21.09.12.00\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 21 Mar 2024 09:12:00 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711037959;\n x=1711642759; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=OchZbGiqZYOKIHTgrKGiYo+f+aYAEtmo0dzG4HlbOOM=;\n b=iAQ7QrurP7mVx6kh1tMEjYsjCLcCukZ2W4UHScYIGjhATXQzhNwAB1ok5BrfdLibwF\n fEeWiEPfERHa4z8rhQOSYRs2NioHkHJM92K5teWPLdX96kF9sfBULOmS2PLrAjsiq5OU\n 2Gel/vfGZY+s4Co3htkAxuDxhK1U5+6jvteRocZDASiBayr3iIs/5fgmdtK3qkGBoTTR\n HjCdhWSeXaHxGMsSatj+ecSSFBPdXGvReMZAaEZc+1mOjt8L6W+KrZb7QRUJMzt82CJs\n Lbh9d21ftr0TyXH2JcEpvL747vTvVUzEg3yO8qnOYc92eZyBcOHNhv1gkQuSRZsDe0dO\n M7aA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711037959; x=1711642759;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=OchZbGiqZYOKIHTgrKGiYo+f+aYAEtmo0dzG4HlbOOM=;\n b=J5AeuPjZF+TlNo606fUifknR2kyq7be53CVngiJJ5i4bOQyE0Vi9TWIvgQGqOAQlBJ\n ErrikIOMTd6we52vOJ7CuWWSHB51lMzYUVjAy1QlCiA0efIeXju1eCzFoGZTgAMQYCGz\n ZEyG0ahhGLAIdoKU4oYzbkhaO0e5AAKbQv3kKOB1NmiudePxzvsh1EQfTqGYo0TdGYck\n TWLNDf+wyEUjEMpHldHlHihBayNyMCiojO9aIuQUeSY3gtartHbBBgVibDGFsibArxVx\n SLnoRyPz46wM4sUOyTANHwsUnojHHB94+pQA5YIBlC06u2CvwloJYcUm7KKpBGWUy+qo\n vteg==", "X-Gm-Message-State": "AOJu0YxBGY6dslU4hRKL7YTbkhNWzPJwha33gInpg6znU9cUYq6A84in\n LuTQXi5xRiq5RRfwpo0oABGbrkhVX8lBNnKA5t2T4v7nBy7v27j1K4OisyMrGxXFtNo7tWtaZ4Z\n S", "X-Google-Smtp-Source": "\n AGHT+IF/FnG2u4VU5tIKfxowIopkyowg6LfbVqrj2H5GZvt02yKJvab7NRbLaMKlsIP+k6DyoPzg+Q==", "X-Received": "by 2002:a05:6358:99a6:b0:17b:b52c:c121 with SMTP id\n j38-20020a05635899a600b0017bb52cc121mr10487051rwb.13.1711037521063;\n Thu, 21 Mar 2024 09:12:01 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v10 06/10] eal: change rte_exit() output to match rte_log()", "Date": "Thu, 21 Mar 2024 09:00:22 -0700", "Message-ID": "<20240321161146.340421-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240321161146.340421-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240321161146.340421-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The rte_exit() output format confuses the timestamp and coloring\noptions. Change it to use be a single line with proper prefix.\n\nBefore:\n[ 0.006481] EAL: Error - exiting with code: 1\n Cause: [ 0.006489] Cannot init EAL: Permission denied\n\nAfter:\n[ 0.006238] EAL: Error - exiting with code: 1\n[ 0.006250] EAL: Cause: Cannot init EAL: Permission denied\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/common/eal_common_debug.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_debug.c b/lib/eal/common/eal_common_debug.c\nindex 3e77995896d5..568883830f20 100644\n--- a/lib/eal/common/eal_common_debug.c\n+++ b/lib/eal/common/eal_common_debug.c\n@@ -34,17 +34,18 @@ void\n rte_exit(int exit_code, const char *format, ...)\n {\n \tva_list ap;\n+\tchar *msg = NULL;\n \n \tif (exit_code != 0)\n-\t\tRTE_LOG(CRIT, EAL, \"Error - exiting with code: %d\\n\"\n-\t\t\t\t\" Cause: \", exit_code);\n+\t\tEAL_LOG(CRIT, \"Error - exiting with code: %d\", exit_code);\n \n \tva_start(ap, format);\n-\trte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap);\n+\tvasprintf(&msg, format, ap);\n \tva_end(ap);\n \n+\trte_log(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, \"EAL: Cause: %s\", msg);\n+\n \tif (rte_eal_cleanup() != 0 && rte_errno != EALREADY)\n-\t\tEAL_LOG(CRIT,\n-\t\t\t\"EAL could not release all resources\");\n+\t\tEAL_LOG(CRIT, \"EAL could not release all resources\");\n \texit(exit_code);\n }\n", "prefixes": [ "v10", "06/10" ] }