Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138668/?format=api
{ "id": 138668, "url": "http://patches.dpdk.org/api/patches/138668/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240321161146.340421-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240321161146.340421-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240321161146.340421-5-stephen@networkplumber.org", "date": "2024-03-21T16:00:20", "name": "[v10,04/10] eal: initialize log earlier in startup", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8bb6b40b63254eb6b3cbd784f9f3ea96dcdd0abe", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240321161146.340421-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 31589, "url": "http://patches.dpdk.org/api/series/31589/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31589", "date": "2024-03-21T16:00:17", "name": "Logging enhancements.", "version": 10, "mbox": "http://patches.dpdk.org/series/31589/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138668/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138668/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C0B5443D17;\n\tThu, 21 Mar 2024 17:18:51 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AD3A942E25;\n\tThu, 21 Mar 2024 17:18:51 +0100 (CET)", "from mail-oa1-f47.google.com (mail-oa1-f47.google.com\n [209.85.160.47]) by mails.dpdk.org (Postfix) with ESMTP id 46DE942DF5\n for <dev@dpdk.org>; Thu, 21 Mar 2024 17:18:46 +0100 (CET)", "by mail-oa1-f47.google.com with SMTP id\n 586e51a60fabf-22963f0e12cso558618fac.1\n for <dev@dpdk.org>; Thu, 21 Mar 2024 09:18:46 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n w62-20020a638241000000b005e485fbd455sm41815pgd.45.2024.03.21.09.11.58\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 21 Mar 2024 09:11:59 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711037925;\n x=1711642725; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=yzObJr6ChIwzux7DbvCuaGZqdyle5ax9Ncxqa7ENDn0=;\n b=rVCNHq5KvGJCsrw02nbZXTYDmvCbj3qpwRZsq2pxruxgahbce3RSzOTg4XUto1JL2I\n XB+R//lSI5kU9nC2opmA7bAauFPK0Q9iM4U3Q4HUX7/EN+Bf4TpktCEnqF5PQqHAWS5f\n cZRwa8OkjLjOKQY0d2lKiLTMXlypsj2d89my1RvfHWZpCLhW1THH/ZQvXjiircUr8W9R\n P6VgBI9kE92gzCwrgTq/kakJiQuNbkzCVyizuihAb1LEATZJAgdf5l5W9oQZrlUO+Oug\n i942FlCVaH9XW/JBcb/Knjp9oCJcOww5tBARa5UC46C9z4qaGzQHDE4uRX6vcapeJj77\n ZYyA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711037925; x=1711642725;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=yzObJr6ChIwzux7DbvCuaGZqdyle5ax9Ncxqa7ENDn0=;\n b=eR+iwgEeU5kG1l2OAg0+AyZkYFaUcdg3P6jVn8RWj+N6mWbuTmZlKO7C+R+IkzTaVZ\n S7nW9Bib2DdBjJlcXRQbhtXvXejUVmFnO2j0DLNHJeRRSXI14xA9V9yxmU5HJoxSt7eg\n +L04NB321aX+4ym1eFNOnCaP6VM98o3Mi460j/7ioW/DHRjRq4tyQEcEl7SSyg0/VAZw\n Z53EC3OOP80xneK/lCu1DEU29pLMCkMClJCddC4GHjK0VMZtCQGVcLzMMg9D73KGDCH+\n T9eU4m8NkJ+AWIS1eZO7rpBHIAbIw1xWL418pje0jvMyia8bCx+gD+/jgK6xUaBgWkRB\n nDrg==", "X-Gm-Message-State": "AOJu0YzZ99ZN/vWexZ8vmbfIIsIk+Xv691H4NvTZzKtBWfPz9pUSSoZy\n U198ZVVlcHU1/4BMliKNZY9Yop9V/BR8DeRebTNwns5+3zSR2MIaWFH77qdcynoAtPjZzwhCtBe\n H", "X-Google-Smtp-Source": "\n AGHT+IEsdB49fSUDvWcD7XDRMO2W8sUZKNSfdM+d86FSfRO1VqD/VKOrX34mG9lK+EotWozVC79Aew==", "X-Received": "by 2002:a05:6a20:ba9c:b0:1a3:4e19:183c with SMTP id\n fb28-20020a056a20ba9c00b001a34e19183cmr6647454pzb.52.1711037519369;\n Thu, 21 Mar 2024 09:11:59 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v10 04/10] eal: initialize log earlier in startup", "Date": "Thu, 21 Mar 2024 09:00:20 -0700", "Message-ID": "<20240321161146.340421-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240321161146.340421-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240321161146.340421-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Want to make sure that as many log messages as possible\nget added with the real log stream. Despite the comment,\nthere is no dependency on memzones in current code.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/freebsd/eal.c | 14 +++++++-------\n lib/eal/linux/eal.c | 16 ++++++++--------\n lib/eal/unix/eal_unix_log.c | 0\n lib/log/log_unix.c | 4 ++--\n 4 files changed, 17 insertions(+), 17 deletions(-)\n create mode 100644 lib/eal/unix/eal_unix_log.c", "diff": "diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex 94927472edfe..777770176339 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -571,6 +571,13 @@ rte_eal_init(int argc, char **argv)\n \t/* set log level as early as possible */\n \teal_log_level_parse(argc, argv);\n \n+\tif (eal_log_init(getprogname(), internal_conf->syslog_facility) < 0) {\n+\t\trte_eal_init_alert(\"Cannot init logging.\");\n+\t\trte_errno = ENOMEM;\n+\t\trte_atomic_store_explicit(&run_once, 0, rte_memory_order_relaxed);\n+\t\treturn -1;\n+\t}\n+\n \tif (rte_eal_cpu_init() < 0) {\n \t\trte_eal_init_alert(\"Cannot detect lcores.\");\n \t\trte_errno = ENOTSUP;\n@@ -719,13 +726,6 @@ rte_eal_init(int argc, char **argv)\n #endif\n \t}\n \n-\tif (eal_log_init(getprogname(), internal_conf->syslog_facility) < 0) {\n-\t\trte_eal_init_alert(\"Cannot init logging.\");\n-\t\trte_errno = ENOMEM;\n-\t\trte_atomic_store_explicit(&run_once, 0, rte_memory_order_relaxed);\n-\t\treturn -1;\n-\t}\n-\n \t/* in secondary processes, memory init may allocate additional fbarrays\n \t * not present in primary processes, so to avoid any potential issues,\n \t * initialize memzones first.\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex bffeb1f34eb9..e515f3cbc8a8 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -959,6 +959,14 @@ rte_eal_init(int argc, char **argv)\n \t/* clone argv to report out later in telemetry */\n \teal_save_args(argc, argv);\n \n+\tif (eal_log_init(program_invocation_short_name,\n+\t\t\t internal_conf->syslog_facility) < 0) {\n+\t\trte_eal_init_alert(\"Cannot init logging.\");\n+\t\trte_errno = ENOMEM;\n+\t\trte_atomic_store_explicit(&run_once, 0, rte_memory_order_relaxed);\n+\t\treturn -1;\n+\t}\n+\n \tif (rte_eal_cpu_init() < 0) {\n \t\trte_eal_init_alert(\"Cannot detect lcores.\");\n \t\trte_errno = ENOTSUP;\n@@ -1107,14 +1115,6 @@ rte_eal_init(int argc, char **argv)\n #endif\n \t}\n \n-\tif (eal_log_init(program_invocation_short_name,\n-\t\t\t internal_conf->syslog_facility) < 0) {\n-\t\trte_eal_init_alert(\"Cannot init logging.\");\n-\t\trte_errno = ENOMEM;\n-\t\trte_atomic_store_explicit(&run_once, 0, rte_memory_order_relaxed);\n-\t\treturn -1;\n-\t}\n-\n #ifdef VFIO_PRESENT\n \tif (rte_eal_vfio_setup() < 0) {\n \t\trte_eal_init_alert(\"Cannot init VFIO\");\ndiff --git a/lib/eal/unix/eal_unix_log.c b/lib/eal/unix/eal_unix_log.c\nnew file mode 100644\nindex 000000000000..e69de29bb2d1\ndiff --git a/lib/log/log_unix.c b/lib/log/log_unix.c\nindex 2dfb0c974b1d..ae38b4bf3a59 100644\n--- a/lib/log/log_unix.c\n+++ b/lib/log/log_unix.c\n@@ -41,8 +41,8 @@ static cookie_io_functions_t console_log_func = {\n };\n \n /*\n- * set the log to default function, called during eal init process,\n- * once memzones are available.\n+ * set the log to default function, called early in eal init process;\n+ * before lcore's and memzones are setup.\n */\n int\n eal_log_init(const char *id, int facility)\n", "prefixes": [ "v10", "04/10" ] }