Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 138641,
    "url": "http://patches.dpdk.org/api/patches/138641/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1710969121-18503-2-git-send-email-roretzla@linux.microsoft.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1710969121-18503-2-git-send-email-roretzla@linux.microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1710969121-18503-2-git-send-email-roretzla@linux.microsoft.com",
    "date": "2024-03-20T21:12:01",
    "name": "net: stop using mmx intrinsics",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "ba16733adad37126945900f31933b314c64a75c9",
    "submitter": {
        "id": 2077,
        "url": "http://patches.dpdk.org/api/people/2077/?format=api",
        "name": "Tyler Retzlaff",
        "email": "roretzla@linux.microsoft.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1710969121-18503-2-git-send-email-roretzla@linux.microsoft.com/mbox/",
    "series": [
        {
            "id": 31574,
            "url": "http://patches.dpdk.org/api/series/31574/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31574",
            "date": "2024-03-20T21:12:01",
            "name": "net: stop using mmx intrinsics",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/31574/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/138641/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/138641/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DC8BC43D0A;\n\tWed, 20 Mar 2024 22:12:09 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8F14D42E10;\n\tWed, 20 Mar 2024 22:12:06 +0100 (CET)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 5B9EF40A6F\n for <dev@dpdk.org>; Wed, 20 Mar 2024 22:12:03 +0100 (CET)",
            "by linux.microsoft.com (Postfix, from userid 1086)\n id A79EC20B74C1; Wed, 20 Mar 2024 14:12:02 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com A79EC20B74C1",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1710969122;\n bh=oFlmxngHL0Ayps9/vVZGVljVvqV1j1GYAB3fd6xchv0=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=WglN15ttxmHI/r7Ag31BppECoGQ+6XWOZvZR/QFv13+a6SlNMGYx4bWksDBkviVR/\n KTrb2ODbkHH4snm0AdtmOxUPWJC1wmfnRmBaLdxliOVUcMh8Y3ZzlGuzPHEl86/ALD\n +ZnbzwH9fh0trzTgX4qS/N7bNtj4Gl5Bfj7qJ1cw=",
        "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "To": "dev@dpdk.org",
        "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "Subject": "[PATCH] net: stop using mmx intrinsics",
        "Date": "Wed, 20 Mar 2024 14:12:01 -0700",
        "Message-Id": "<1710969121-18503-2-git-send-email-roretzla@linux.microsoft.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1710969121-18503-1-git-send-email-roretzla@linux.microsoft.com>",
        "References": "<1710969121-18503-1-git-send-email-roretzla@linux.microsoft.com>",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Update code to use only avx/sse intrinsics as mmx is not supported on\nMSVC.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/net/net_crc_avx512.c | 28 ++++++++++------------------\n lib/net/net_crc_sse.c    | 28 ++++++++++------------------\n 2 files changed, 20 insertions(+), 36 deletions(-)",
    "diff": "diff --git a/lib/net/net_crc_avx512.c b/lib/net/net_crc_avx512.c\nindex 0f0dee4..6d0c644 100644\n--- a/lib/net/net_crc_avx512.c\n+++ b/lib/net/net_crc_avx512.c\n@@ -8,7 +8,11 @@\n \n #include \"net_crc.h\"\n \n+#ifdef RTE_TOOLCHAIN_MSVC\n+#include <intrin.h>\n+#else\n #include <x86intrin.h>\n+#endif\n \n /* VPCLMULQDQ CRC computation context structure */\n struct crc_vpclmulqdq_ctx {\n@@ -331,13 +335,10 @@ static const alignas(16) uint32_t mask2[4] = {\n \t\t\tc9, c10, c11);\n \tcrc32_eth.fold_3x128b = _mm512_setr_epi64(c12, c13, c14, c15,\n \t\t\tc16, c17, 0, 0);\n-\tcrc32_eth.fold_1x128b = _mm_setr_epi64(_mm_cvtsi64_m64(c16),\n-\t\t\t_mm_cvtsi64_m64(c17));\n+\tcrc32_eth.fold_1x128b = _mm_set_epi64x(c17, c16);\n \n-\tcrc32_eth.rk5_rk6 = _mm_setr_epi64(_mm_cvtsi64_m64(c18),\n-\t\t\t_mm_cvtsi64_m64(c19));\n-\tcrc32_eth.rk7_rk8 = _mm_setr_epi64(_mm_cvtsi64_m64(c20),\n-\t\t\t_mm_cvtsi64_m64(c21));\n+\tcrc32_eth.rk5_rk6 = _mm_set_epi64x(c19, c18);\n+\tcrc32_eth.rk7_rk8 = _mm_set_epi64x(c21, c20);\n }\n \n static void\n@@ -378,13 +379,10 @@ static const alignas(16) uint32_t mask2[4] = {\n \t\t\tc9, c10, c11);\n \tcrc16_ccitt.fold_3x128b = _mm512_setr_epi64(c12, c13, c14, c15,\n \t\t\tc16, c17, 0, 0);\n-\tcrc16_ccitt.fold_1x128b = _mm_setr_epi64(_mm_cvtsi64_m64(c16),\n-\t\t\t_mm_cvtsi64_m64(c17));\n+\tcrc16_ccitt.fold_1x128b = _mm_set_epi64x(c17, c16);\n \n-\tcrc16_ccitt.rk5_rk6 = _mm_setr_epi64(_mm_cvtsi64_m64(c18),\n-\t\t\t_mm_cvtsi64_m64(c19));\n-\tcrc16_ccitt.rk7_rk8 = _mm_setr_epi64(_mm_cvtsi64_m64(c20),\n-\t\t\t_mm_cvtsi64_m64(c21));\n+\tcrc16_ccitt.rk5_rk6 = _mm_set_epi64x(c19, c18);\n+\tcrc16_ccitt.rk7_rk8 = _mm_set_epi64x(c21, c20);\n }\n \n void\n@@ -392,12 +390,6 @@ static const alignas(16) uint32_t mask2[4] = {\n {\n \tcrc32_load_init_constants();\n \tcrc16_load_init_constants();\n-\n-\t/*\n-\t * Reset the register as following calculation may\n-\t * use other data types such as float, double, etc.\n-\t */\n-\t_mm_empty();\n }\n \n uint32_t\ndiff --git a/lib/net/net_crc_sse.c b/lib/net/net_crc_sse.c\nindex d673ae3..9ab80a0 100644\n--- a/lib/net/net_crc_sse.c\n+++ b/lib/net/net_crc_sse.c\n@@ -10,7 +10,11 @@\n \n #include \"net_crc.h\"\n \n+#ifdef RTE_TOOLCHAIN_MSVC\n+#include <intrin.h>\n+#else\n #include <x86intrin.h>\n+#endif\n \n /** PCLMULQDQ CRC computation context structure */\n struct crc_pclmulqdq_ctx {\n@@ -272,12 +276,9 @@ static const alignas(16) uint8_t crc_xmm_shift_tab[48] = {\n \tp =  0x10811LLU;\n \n \t/** Save the params in context structure */\n-\tcrc16_ccitt_pclmulqdq.rk1_rk2 =\n-\t\t_mm_setr_epi64(_mm_cvtsi64_m64(k1), _mm_cvtsi64_m64(k2));\n-\tcrc16_ccitt_pclmulqdq.rk5_rk6 =\n-\t\t_mm_setr_epi64(_mm_cvtsi64_m64(k5), _mm_cvtsi64_m64(k6));\n-\tcrc16_ccitt_pclmulqdq.rk7_rk8 =\n-\t\t_mm_setr_epi64(_mm_cvtsi64_m64(q), _mm_cvtsi64_m64(p));\n+\tcrc16_ccitt_pclmulqdq.rk1_rk2 = _mm_set_epi64x(k2, k1);\n+\tcrc16_ccitt_pclmulqdq.rk5_rk6 = _mm_set_epi64x(k6, k5);\n+\tcrc16_ccitt_pclmulqdq.rk7_rk8 = _mm_set_epi64x(p, q);\n \n \t/** Initialize CRC32 data */\n \tk1 = 0xccaa009eLLU;\n@@ -288,18 +289,9 @@ static const alignas(16) uint8_t crc_xmm_shift_tab[48] = {\n \tp =  0x1db710641LLU;\n \n \t/** Save the params in context structure */\n-\tcrc32_eth_pclmulqdq.rk1_rk2 =\n-\t\t_mm_setr_epi64(_mm_cvtsi64_m64(k1), _mm_cvtsi64_m64(k2));\n-\tcrc32_eth_pclmulqdq.rk5_rk6 =\n-\t\t_mm_setr_epi64(_mm_cvtsi64_m64(k5), _mm_cvtsi64_m64(k6));\n-\tcrc32_eth_pclmulqdq.rk7_rk8 =\n-\t\t_mm_setr_epi64(_mm_cvtsi64_m64(q), _mm_cvtsi64_m64(p));\n-\n-\t/**\n-\t * Reset the register as following calculation may\n-\t * use other data types such as float, double, etc.\n-\t */\n-\t_mm_empty();\n+\tcrc32_eth_pclmulqdq.rk1_rk2 = _mm_set_epi64x(k2, k1);\n+\tcrc32_eth_pclmulqdq.rk5_rk6 = _mm_set_epi64x(k6, k5);\n+\tcrc32_eth_pclmulqdq.rk7_rk8 = _mm_set_epi64x(p, q);\n }\n \n uint32_t\n",
    "prefixes": []
}