Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138481/?format=api
{ "id": 138481, "url": "http://patches.dpdk.org/api/patches/138481/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240319112455.329350-1-getelson@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240319112455.329350-1-getelson@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240319112455.329350-1-getelson@nvidia.com", "date": "2024-03-19T11:24:55", "name": "[v2] net/mlx5: fix sync meter action", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6b21b123a9ef2a060cba68e6f52a81d1a8d05070", "submitter": { "id": 1882, "url": "http://patches.dpdk.org/api/people/1882/?format=api", "name": "Gregory Etelson", "email": "getelson@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240319112455.329350-1-getelson@nvidia.com/mbox/", "series": [ { "id": 31556, "url": "http://patches.dpdk.org/api/series/31556/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31556", "date": "2024-03-19T11:24:55", "name": "[v2] net/mlx5: fix sync meter action", "version": 2, "mbox": "http://patches.dpdk.org/series/31556/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138481/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/138481/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 690D243CFA;\n\tTue, 19 Mar 2024 12:25:31 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E53A2402D1;\n\tTue, 19 Mar 2024 12:25:30 +0100 (CET)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2085.outbound.protection.outlook.com [40.107.237.85])\n by mails.dpdk.org (Postfix) with ESMTP id 669C340298\n for <dev@dpdk.org>; Tue, 19 Mar 2024 12:25:29 +0100 (CET)", "from SA1PR03CA0010.namprd03.prod.outlook.com (2603:10b6:806:2d3::26)\n by MN0PR12MB6222.namprd12.prod.outlook.com (2603:10b6:208:3c2::19)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.26; Tue, 19 Mar\n 2024 11:25:26 +0000", "from SA2PEPF00001506.namprd04.prod.outlook.com\n (2603:10b6:806:2d3:cafe::90) by SA1PR03CA0010.outlook.office365.com\n (2603:10b6:806:2d3::26) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.27 via Frontend\n Transport; Tue, 19 Mar 2024 11:25:26 +0000", "from mail.nvidia.com (216.228.117.160) by\n SA2PEPF00001506.mail.protection.outlook.com (10.167.242.38) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7409.10 via Frontend Transport; Tue, 19 Mar 2024 11:25:26 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 19 Mar\n 2024 04:25:12 -0700", "from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Tue, 19 Mar\n 2024 04:25:09 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=M1kJmB4ZjzWZyYc79uLmRbCY6zyNWC++tYxqJ+/yzW7mosJQRn5imyIQwAXOWszut5etaQSbcSFGK3bjm5IWVXH4bPNAhWRIj4IhxZ9sQ4/7xSZk+gdv+2NX9MP0LNZiVc9Q/Xv7LIuKVxvDf9Yf5dofrQ1TJ7OHesWJsVMcSkbk6G4pt4yy4JQFwU/XaQkKBvBv3r/FW+mS1q6RPjwarKwCPWX8ejbP4CcONWWwcVJTdq8BMNgTUzIMNdR/5I/MOeQQ9B02T2V8ENZpI6idJFxhD5qm4iQexO8EUXFpT8RVvkRtiTAIdCTWyQUBaiJYw7C0zDBAQSbWvctfhLPxVg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=giUJmdPfu8U4rqogS5yEIOWRuzYO/X3bMEszdBtO1os=;\n b=DcWIactYPyH/bEK4uWV7kANdeK8C6DIedXF1w3e43J1h1EmxXeH5EPgy2/O1KE4TvEUx6sLckxFsmRk+TY48uLeQuUUNiszn+mInxb/h/okeSNtWieRkyB9xB4GzLe9/LE5pFCMisU+xLrDbqzUFatvAFjTlKyougpeppJ9n1KQ1ZFxnyQSTKuSXNNpkDaiNfMAIVvnLA+ssa8PJqrPd5A1fIYCwVX7T7ka2VOs9lj7eq/M7llRQLsw5foR4xKtdv269914oUpCov6Q79LW8G00SbFHHlEGrp0mQTM54BuSuQ9Ywaym1tG2QRNO2JGqaBWtK10oSOfjLlf7orVOBdw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=giUJmdPfu8U4rqogS5yEIOWRuzYO/X3bMEszdBtO1os=;\n b=m35o/URKw0Igi6adl0nEAvATAg4Q3zsGlIFC9YPSTCQi2cczi8ZhkEsYTmWcTAQq/io1xCj3AjEH3ZE0eZNpcmt55LrOud1lEgFc7YjBUwgk1t736CJqTpECrbwDr9PPfXoB/i9Rp2+rlrhm/rO1nvBFpujY/SPL/1W/QxFic1uhAwGEk+a5P9Wxs1Klbk4D8LXFo6ORUMWIrZa1Um+n4AzVNi+GDbxyXXtma614DA4h2XgMvHcHrInsXUt06wt0L01knusG/6nO+CnPsWNBMh0wbEDPTOfrJk40tuu1jF0EBZtE/KegiSqbNN5kZXSxXz8uisHszWIoX9UnbVMdXA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Gregory Etelson <getelson@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<getelson@nvidia.com>, <mkashani@nvidia.com>, <rasland@nvidia.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>, Viacheslav Ovsiienko\n <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>, Suanming Mou\n <suanmingm@nvidia.com>, Matan Azrad <matan@nvidia.com>", "Subject": "[PATCH v2] net/mlx5: fix sync meter action", "Date": "Tue, 19 Mar 2024 13:24:55 +0200", "Message-ID": "<20240319112455.329350-1-getelson@nvidia.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20240318181045.272879-1-getelson@nvidia.com>", "References": "<20240318181045.272879-1-getelson@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "rnnvmail203.nvidia.com (10.129.68.9) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SA2PEPF00001506:EE_|MN0PR12MB6222:EE_", "X-MS-Office365-Filtering-Correlation-Id": "475ac9bc-32ba-4146-2b84-08dc48074655", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n F2nwXAaqzIY3FkKXCD6rlbZEdDS6/N3Vv3EWgKHVHALkb979PZQIL7fKtKxlbSg+nCZux14Hzifjs1Co5kOJyQiWH8UXYJzUoG2Gy9YEKQ9vVx6eL7wY2uFrrCiKbwXzTs7xtBHfzOl6Ym6nojyq6x2lyxTYdQykoPl+xySoqFJtzQJ9iNwEbuRLaYSWmTWcput3VBob/q+6+r2jrAVtOYkkwjuJLO79QGQ6J0y6rppZ0OuormJtjy+I7+kQBKK0xAUkd1zA1BIBNVW9oZxExh0/zE3CuDHaUyhN/VIh7vBNohakOD2Ehe0MpYnZBxSYjGpH9l64WV4CTjGCIVtFrw6ywcxGgAHfPnePXKi5WZ/XbGwRPOHZDARDHHblO8Sj1L56Kiqg68MNBpZSsNjV2TSPMqliyaCIKBIpQXQVe5tyaj9GP13ckcHt4crfHy1Q8IQmY3WSxtQZAWowF6ihpYktGZyXfRnLHrT+LZuMHsJpwyHWJcuVU+ud6u181f6zvJcRom0LM605PZeh+dxUV+JRlvMJ3SE3faMxunqfbEMqA6BQaIDCJWQZMJViOegjGsl2+vh87n7VXY9ynAqMrrRAEaSQfipAv4wB/bChC52vFwiUwKwjbQkfMgykWqlTJoSAyefCc/Ea8lB4gxNxEVrHBoLrSCnBKQsUa9n1ahFn4ItO3HAkpTZIHIHnroauGOvtdkSr/qB/ZLkn0w9iTQwY5jZ1HIwONaJUtyGH+xAPfNhc3wdyfO1DxNDQfmML", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(36860700004)(376005)(82310400014)(1800799015); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "19 Mar 2024 11:25:26.0475 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 475ac9bc-32ba-4146-2b84-08dc48074655", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n SA2PEPF00001506.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN0PR12MB6222", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "PMD implements sync METER flow action as async.\nQueue selected for sync operations is `MLX5_HW_INV_QUEUE`.\nThat dummy queue value is translated into `CTRL_QUEUE_ID(priv)`.\nAsync job allocation converts INV queue into the real value, but\njob release does not.\n\nThis patch fixes the queue value provided to `flow_hw_job_put()`.\n\nThis patch also removes dead code found in METER_MARK\ndestroy handler.\n\nCoverity issue: 415806\nCoverity issue: 415804\n\nFixes: 4359d9d1f76b (\"net/mlx5: fix sync meter processing in HWS\")\n\nSigned-off-by: Gregory Etelson <getelson@nvidia.com>\nAcked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>\n---\nv2: Fixed Coverity tag.\n---\n drivers/net/mlx5/mlx5_flow_hw.c | 5 +----\n drivers/net/mlx5/mlx5_flow_meter.c | 2 +-\n 2 files changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex 35f1ed7a03..9ebbe664d1 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -11494,10 +11494,7 @@ flow_hw_action_handle_destroy(struct rte_eth_dev *dev, uint32_t queue,\n \t\t\t\tNULL, \"Unable to wait for ASO meter CQE\");\n \t\t\tbreak;\n \t\t}\n-\t\tif (!job)\n-\t\t\tmlx5_ipool_free(pool->idx_pool, idx);\n-\t\telse\n-\t\t\taso = true;\n+\t\taso = true;\n \t\tbreak;\n \tcase MLX5_INDIRECT_ACTION_TYPE_RSS:\n \t\tret = flow_dv_action_destroy(dev, handle, error);\ndiff --git a/drivers/net/mlx5/mlx5_flow_meter.c b/drivers/net/mlx5/mlx5_flow_meter.c\nindex 4045c4c249..ca361f7efa 100644\n--- a/drivers/net/mlx5/mlx5_flow_meter.c\n+++ b/drivers/net/mlx5/mlx5_flow_meter.c\n@@ -2265,7 +2265,7 @@ mlx5_flow_meter_hws_create(struct rte_eth_dev *dev, uint32_t meter_id,\n \tret = mlx5_aso_meter_update_by_wqe(priv, MLX5_HW_INV_QUEUE, aso_mtr,\n \t\t\t\t\t &priv->mtr_bulk, job, true);\n \tif (ret) {\n-\t\tflow_hw_job_put(priv, job, MLX5_HW_INV_QUEUE);\n+\t\tflow_hw_job_put(priv, job, CTRL_QUEUE_ID(priv));\n \t\treturn -rte_mtr_error_set(error, ENOTSUP,\n \t\t\t\t\t RTE_MTR_ERROR_TYPE_UNSPECIFIED,\n \t\t\t\t\t NULL, \"Failed to create devx meter.\");\n", "prefixes": [ "v2" ] }