Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138449/?format=api
{ "id": 138449, "url": "http://patches.dpdk.org/api/patches/138449/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240318111838.16991-2-fengchengwen@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240318111838.16991-2-fengchengwen@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240318111838.16991-2-fengchengwen@huawei.com", "date": "2024-03-18T11:18:33", "name": "[v4,1/6] argparse: refine error message", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8455c92423c3e257881bfd9de8389a3e21a19776", "submitter": { "id": 2146, "url": "http://patches.dpdk.org/api/people/2146/?format=api", "name": "fengchengwen", "email": "fengchengwen@huawei.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240318111838.16991-2-fengchengwen@huawei.com/mbox/", "series": [ { "id": 31544, "url": "http://patches.dpdk.org/api/series/31544/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31544", "date": "2024-03-18T11:18:32", "name": "refine argparse library", "version": 4, "mbox": "http://patches.dpdk.org/series/31544/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138449/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138449/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8D6D943CE3;\n\tMon, 18 Mar 2024 12:21:08 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 92A9440A6E;\n\tMon, 18 Mar 2024 12:21:04 +0100 (CET)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by mails.dpdk.org (Postfix) with ESMTP id 9F05C40A67\n for <dev@dpdk.org>; Mon, 18 Mar 2024 12:21:00 +0100 (CET)", "from mail.maildlp.com (unknown [172.19.163.17])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Tysps55x8z1FMs7;\n Mon, 18 Mar 2024 19:20:37 +0800 (CST)", "from dggpeml500024.china.huawei.com (unknown [7.185.36.10])\n by mail.maildlp.com (Postfix) with ESMTPS id D46A31A0172;\n Mon, 18 Mar 2024 19:20:58 +0800 (CST)", "from localhost.localdomain (10.50.165.33) by\n dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.1.2507.35; Mon, 18 Mar 2024 19:20:58 +0800" ], "From": "Chengwen Feng <fengchengwen@huawei.com>", "To": "<thomas@monjalon.net>, <david.marchand@redhat.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH v4 1/6] argparse: refine error message", "Date": "Mon, 18 Mar 2024 11:18:33 +0000", "Message-ID": "<20240318111838.16991-2-fengchengwen@huawei.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240318111838.16991-1-fengchengwen@huawei.com>", "References": "<20240220131502.47510-1-fengchengwen@huawei.com>\n <20240318111838.16991-1-fengchengwen@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.50.165.33]", "X-ClientProxiedBy": "dggems704-chm.china.huawei.com (10.3.19.181) To\n dggpeml500024.china.huawei.com (7.185.36.10)", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch refines the error message.\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n lib/argparse/rte_argparse.c | 31 +++++++++++++++++--------------\n 1 file changed, 17 insertions(+), 14 deletions(-)", "diff": "diff --git a/lib/argparse/rte_argparse.c b/lib/argparse/rte_argparse.c\nindex 2d953f1694..48738cd07b 100644\n--- a/lib/argparse/rte_argparse.c\n+++ b/lib/argparse/rte_argparse.c\n@@ -67,7 +67,7 @@ verify_arg_name(const struct rte_argparse_arg *arg)\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tif (arg->name_long[1] != '-') {\n-\t\t\tARGPARSE_LOG(ERR, \"optional long name %s must only start with '--'\",\n+\t\t\tARGPARSE_LOG(ERR, \"optional long name %s doesn't start with '--'\",\n \t\t\t\t arg->name_long);\n \t\t\treturn -EINVAL;\n \t\t}\n@@ -101,7 +101,7 @@ static int\n verify_arg_help(const struct rte_argparse_arg *arg)\n {\n \tif (arg->help == NULL) {\n-\t\tARGPARSE_LOG(ERR, \"argument %s must have help info!\", arg->name_long);\n+\t\tARGPARSE_LOG(ERR, \"argument %s doesn't have help info!\", arg->name_long);\n \t\treturn -EINVAL;\n \t}\n \n@@ -116,13 +116,13 @@ verify_arg_has_val(const struct rte_argparse_arg *arg)\n \tif (is_arg_positional(arg)) {\n \t\tif (has_val == RTE_ARGPARSE_ARG_REQUIRED_VALUE)\n \t\t\treturn 0;\n-\t\tARGPARSE_LOG(ERR, \"argument %s is positional, should has zero or required-val!\",\n+\t\tARGPARSE_LOG(ERR, \"argument %s is positional, must config required-val!\",\n \t\t\t arg->name_long);\n \t\treturn -EINVAL;\n \t}\n \n \tif (has_val == 0) {\n-\t\tARGPARSE_LOG(ERR, \"argument %s is optional, has-val config wrong!\",\n+\t\tARGPARSE_LOG(ERR, \"argument %s is optional, has-value config wrong!\",\n \t\t\t arg->name_long);\n \t\treturn -EINVAL;\n \t}\n@@ -140,13 +140,13 @@ verify_arg_saver(const struct rte_argparse *obj, uint32_t index)\n \n \tif (arg->val_saver == NULL) {\n \t\tif (val_type != 0) {\n-\t\t\tARGPARSE_LOG(ERR, \"argument %s parse by callback, val-type must be zero!\",\n+\t\t\tARGPARSE_LOG(ERR, \"argument %s parsed by callback, value-type should not be set!\",\n \t\t\t\t arg->name_long);\n \t\t\treturn -EINVAL;\n \t\t}\n \n \t\tif (obj->callback == NULL) {\n-\t\t\tARGPARSE_LOG(ERR, \"argument %s parse by callback, but callback is NULL!\",\n+\t\t\tARGPARSE_LOG(ERR, \"argument %s parsed by callback, but callback is NULL!\",\n \t\t\t\t arg->name_long);\n \t\t\treturn -EINVAL;\n \t\t}\n@@ -155,12 +155,12 @@ verify_arg_saver(const struct rte_argparse *obj, uint32_t index)\n \t}\n \n \tif (val_type == 0 || val_type >= cmp_max) {\n-\t\tARGPARSE_LOG(ERR, \"argument %s val-type config wrong!\", arg->name_long);\n+\t\tARGPARSE_LOG(ERR, \"argument %s value-type config wrong!\", arg->name_long);\n \t\treturn -EINVAL;\n \t}\n \n \tif (has_val == RTE_ARGPARSE_ARG_REQUIRED_VALUE && arg->val_set != NULL) {\n-\t\tARGPARSE_LOG(ERR, \"argument %s has required value, val-set should be NULL!\",\n+\t\tARGPARSE_LOG(ERR, \"argument %s has required value, value-set should be NULL!\",\n \t\t\t arg->name_long);\n \t\treturn -EINVAL;\n \t}\n@@ -175,7 +175,8 @@ verify_arg_flags(const struct rte_argparse *obj, uint32_t index)\n \tuint32_t unused_bits = arg_attr_unused_bits(arg);\n \n \tif (unused_bits != 0) {\n-\t\tARGPARSE_LOG(ERR, \"argument %s flags set wrong!\", arg->name_long);\n+\t\tARGPARSE_LOG(ERR, \"argument %s flags unused bits should not be set!\",\n+\t\t\t arg->name_long);\n \t\treturn -EINVAL;\n \t}\n \n@@ -189,7 +190,7 @@ verify_arg_flags(const struct rte_argparse *obj, uint32_t index)\n \t}\n \n \tif (arg->val_saver != NULL) {\n-\t\tARGPARSE_LOG(ERR, \"argument %s could occur multiple times, should use callback to parse!\",\n+\t\tARGPARSE_LOG(ERR, \"argument %s supports multiple times, should use callback to parse!\",\n \t\t\t arg->name_long);\n \t\treturn -EINVAL;\n \t}\n@@ -536,8 +537,10 @@ parse_arg_autosave(struct rte_argparse_arg *arg, const char *value)\n \treturn ret;\n }\n \n+/* arg_parse indicates the name entered by the user, which can be long-name or short-name. */\n static int\n-parse_arg_val(struct rte_argparse *obj, struct rte_argparse_arg *arg, char *value)\n+parse_arg_val(struct rte_argparse *obj, const char *arg_name,\n+\t struct rte_argparse_arg *arg, char *value)\n {\n \tint ret;\n \n@@ -546,7 +549,7 @@ parse_arg_val(struct rte_argparse *obj, struct rte_argparse_arg *arg, char *valu\n \telse\n \t\tret = parse_arg_autosave(arg, value);\n \tif (ret != 0) {\n-\t\tARGPARSE_LOG(ERR, \"argument %s parse value fail!\", arg->name_long);\n+\t\tARGPARSE_LOG(ERR, \"argument %s parse value fail!\", arg_name);\n \t\treturn ret;\n \t}\n \n@@ -582,7 +585,7 @@ parse_args(struct rte_argparse *obj, int argc, char **argv, bool *show_help)\n \t\t\t\treturn -EINVAL;\n \t\t\t}\n \t\t\targ = find_position_arg(obj, position_index);\n-\t\t\tret = parse_arg_val(obj, arg, curr_argv);\n+\t\t\tret = parse_arg_val(obj, arg->name_long, arg, curr_argv);\n \t\t\tif (ret != 0)\n \t\t\t\treturn ret;\n \t\t\tcontinue;\n@@ -629,7 +632,7 @@ parse_args(struct rte_argparse *obj, int argc, char **argv, bool *show_help)\n \t\t\t/* Do nothing, because it's optional value, only support arg=val or arg. */\n \t\t}\n \n-\t\tret = parse_arg_val(obj, arg, value);\n+\t\tret = parse_arg_val(obj, arg_name, arg, value);\n \t\tif (ret != 0)\n \t\t\treturn ret;\n \n", "prefixes": [ "v4", "1/6" ] }