Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138439/?format=api
{ "id": 138439, "url": "http://patches.dpdk.org/api/patches/138439/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240318024002.551435-1-ashish.sadanandan@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240318024002.551435-1-ashish.sadanandan@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240318024002.551435-1-ashish.sadanandan@gmail.com", "date": "2024-03-18T02:40:02", "name": "[v2,1/1] eal: add C++ include guard in generic/rte_vect.h", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c01230c8ac65dbf1994b7be3ec1e8ca8a63cf2aa", "submitter": { "id": 2031, "url": "http://patches.dpdk.org/api/people/2031/?format=api", "name": "Ashish Sadanandan", "email": "ashish.sadanandan@gmail.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240318024002.551435-1-ashish.sadanandan@gmail.com/mbox/", "series": [ { "id": 31539, "url": "http://patches.dpdk.org/api/series/31539/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31539", "date": "2024-03-18T02:40:02", "name": "[v2,1/1] eal: add C++ include guard in generic/rte_vect.h", "version": 2, "mbox": "http://patches.dpdk.org/series/31539/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138439/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/138439/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9DA8A43CDC;\n\tMon, 18 Mar 2024 03:40:12 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2C678402BF;\n\tMon, 18 Mar 2024 03:40:12 +0100 (CET)", "from mail-pl1-f169.google.com (mail-pl1-f169.google.com\n [209.85.214.169])\n by mails.dpdk.org (Postfix) with ESMTP id A48C340289;\n Mon, 18 Mar 2024 03:40:10 +0100 (CET)", "by mail-pl1-f169.google.com with SMTP id\n d9443c01a7336-1e0025ef1efso6994205ad.1;\n Sun, 17 Mar 2024 19:40:10 -0700 (PDT)", "from asadanan1-lnx.qualcomm.com (i-global254.qualcomm.com.\n [199.106.103.254]) by smtp.gmail.com with ESMTPSA id\n 13-20020a170902ee4d00b001dd7d66aa18sm7894556plo.67.2024.03.17.19.40.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 17 Mar 2024 19:40:08 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1710729609; x=1711334409; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ndMSvrCpAqF7t8oicgT1JyTBMpP3diAbcnqX9tXheLU=;\n b=IjmLvTHL7WxxPYV9yTLYpBu2Eq20Ue7Vq2jaAAl76rRQj4enT8y4ajXqbNlFE4EZya\n YV6UBrpDfmBEB+FHDIbwzcGyaneS7AAD2ZcAwX80SVCgpTxNwcmPqX+HIaDGgtj5E3RT\n 2UfannvIhyJJW2icBhK7CRmUKQjtBqv27Bfbuka1Uvi1FOZW1euK9JJop50KqWnN2nCn\n HroOFwkRG+CctN2zLW5eG+xLeIicXOMtWXECW3g13sBVYeSBvVREw6XrEXgPxn6q96/a\n 1hZYz5RbD3uIVvlN34iw3MKhbLfgQEb1ZvO0inx7GFzPIDZ7GecIKvGel811SlXziazT\n SmyA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1710729609; x=1711334409;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=ndMSvrCpAqF7t8oicgT1JyTBMpP3diAbcnqX9tXheLU=;\n b=YGdbhhThtI+ZtZ5/WGKkRP7v4Z6TCZzzGp9ZyGby7NzT0+EZGhuCLjOW1tFzTIhrdU\n lKUXIoKAhHk6WSZwU9el/02ZcDEuf3OqV51xvGZ4i8RiHnkejdm5zDzFVuWrpySKmmPq\n xN7i5U8I8iyQMDSz//67XaPBQIaCiOV075nsGiFL+79HsbfqtI6yFnEbRzSQE4zlkvu5\n SeEOkcJWFZWU8+7OLJa8aruDDKnYrf14KHUVNR2NMPW/UTKjCaROw9iAMKDwwLx/LqkO\n 6YXAX8oBuov688nD4Vx/la+vCT6Dy1G8IjQKAwX4VrRiJRcZtXg9w1zg1a3x0jW3vZf+\n IgYw==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCXDUEXX6acEhGl0a4+Jrv1nqu9j++f/ozVWfvNqFXlg7093PlKY5z7KoJQqmXcqBpBl3TQQ/OehA8B7dXd7Em4=", "X-Gm-Message-State": "AOJu0YxrY+mTQt2Q6OwymV+3y8anYF+njxege7vFXzT43rb7y5u8VfK1\n B1y6LXPFm6TCC4ITzeMaZ4wPd8d1IfA4qcPNWM6uKpyRtkywNStWPPVilVOv2Zc=", "X-Google-Smtp-Source": "\n AGHT+IHQq8gFlmtUVomRuin7ZhJ+KDQr+q17vJVAQVCyxKYKCJIopOCaEe4SFxE5/t+TP21pe2+0sw==", "X-Received": "by 2002:a17:903:1112:b0:1dd:da9d:940d with SMTP id\n n18-20020a170903111200b001ddda9d940dmr12599149plh.38.1710729608792;\n Sun, 17 Mar 2024 19:40:08 -0700 (PDT)", "From": "Ashish Sadanandan <ashish.sadanandan@gmail.com>", "To": "dev@dpdk.org,\n\tThomas Monjalon <thomas@monjalon.net>", "Cc": "Ashish Sadanandan <ashish.sadanandan@gmail.com>,\n nelio.laranjeiro@6wind.com, stable@dpdk.org", "Subject": "[PATCH v2 1/1] eal: add C++ include guard in generic/rte_vect.h", "Date": "Sun, 17 Mar 2024 20:40:02 -0600", "Message-Id": "<20240318024002.551435-1-ashish.sadanandan@gmail.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20240202051335.776290-1-ashish.sadanandan@gmail.com>", "References": "<20240202051335.776290-1-ashish.sadanandan@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The header was missing the extern \"C\" directive which causes name\nmangling of functions by C++ compilers, leading to linker errors\ncomplaining of undefined references to these functions.\n\nAlso updated the coding style contribution guideline with a new\n\"Language Linkage\" section stating `extern \"C\"` block should be added to\npublic headers.\n\nFixes: 86c743cf9140 (\"eal: define generic vector types\")\nCc: nelio.laranjeiro@6wind.com\nCc: stable@dpdk.org\n\nSigned-off-by: Ashish Sadanandan <ashish.sadanandan@gmail.com>\n---\n .mailmap | 2 +-\n doc/guides/contributing/coding_style.rst | 21 +++++++++++++++++++++\n lib/eal/include/generic/rte_vect.h | 8 ++++++++\n 3 files changed, 30 insertions(+), 1 deletion(-)", "diff": "diff --git a/.mailmap b/.mailmap\nindex 50726e1232..24de59ba89 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -142,7 +142,7 @@ Ashijeet Acharya <ashijeet.acharya@6wind.com>\n Ashish Gupta <ashishg@marvell.com> <ashish.gupta@marvell.com> <ashish.gupta@caviumnetworks.com>\n Ashish Jain <ashish.jain@nxp.com>\n Ashish Paul <apaul@juniper.net>\n-Ashish Sadanandan <ashish.sadanandan@gmail.com>\n+Ashish Sadanandan <ashish.sadanandan@gmail.com> <quic_asadanan@quicinc.com>\n Ashish Shah <ashish.n.shah@intel.com>\n Ashwin Sekhar T K <asekhar@marvell.com> <ashwin.sekhar@caviumnetworks.com>\n Asim Jamshed <asim.jamshed@gmail.com>\ndiff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst\nindex 1ebc79ca3c..da57cc1f80 100644\n--- a/doc/guides/contributing/coding_style.rst\n+++ b/doc/guides/contributing/coding_style.rst\n@@ -106,6 +106,27 @@ Headers should be protected against multiple inclusion with the usual:\n \n #endif /* _FILE_H_ */\n \n+Language Linkage\n+~~~~~~~~~~~~~~~~\n+\n+Public headers should enclose all function and variable declarations and defintions in an ``extern \"C\"`` block to facilitate interoperability with C++.\n+\n+.. code-block:: c\n+\n+ #ifndef _FILE_H_\n+ #define _FILE_H_\n+\n+ #ifdef __cplusplus\n+ extern \"C\" {\n+ #endif\n+\n+ /* Code */\n+\n+ #ifdef __cplusplus\n+ }\n+ #endif\n+\n+ #endif /* _FILE_H_ */\n \n Macros\n ~~~~~~\ndiff --git a/lib/eal/include/generic/rte_vect.h b/lib/eal/include/generic/rte_vect.h\nindex 6540419cd2..3578d8749b 100644\n--- a/lib/eal/include/generic/rte_vect.h\n+++ b/lib/eal/include/generic/rte_vect.h\n@@ -15,6 +15,10 @@\n \n #include <stdint.h>\n \n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n #ifndef RTE_TOOLCHAIN_MSVC\n \n /* Unsigned vector types */\n@@ -226,4 +230,8 @@ uint16_t rte_vect_get_max_simd_bitwidth(void);\n */\n int rte_vect_set_max_simd_bitwidth(uint16_t bitwidth);\n \n+#ifdef __cplusplus\n+}\n+#endif\n+\n #endif /* _RTE_VECT_H_ */\n", "prefixes": [ "v2", "1/1" ] }