Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138420/?format=api
{ "id": 138420, "url": "http://patches.dpdk.org/api/patches/138420/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240315054213.540-9-vvelumuri@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240315054213.540-9-vvelumuri@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240315054213.540-9-vvelumuri@marvell.com", "date": "2024-03-15T05:42:13", "name": "[v3,8/8] crypto/cnxk: update the context structure of tls", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5f6eb4a0c5bf39e5cd0203898efea642f14c06e1", "submitter": { "id": 2363, "url": "http://patches.dpdk.org/api/people/2363/?format=api", "name": "Vidya Sagar Velumuri", "email": "vvelumuri@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240315054213.540-9-vvelumuri@marvell.com/mbox/", "series": [ { "id": 31530, "url": "http://patches.dpdk.org/api/series/31530/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31530", "date": "2024-03-15T05:42:05", "name": "Fixes and minor improvements for Crypto cnxk", "version": 3, "mbox": "http://patches.dpdk.org/series/31530/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138420/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138420/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A252143CA6;\n\tFri, 15 Mar 2024 06:44:02 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 47C9242EBA;\n\tFri, 15 Mar 2024 06:43:46 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id A62AC410FC\n for <dev@dpdk.org>; Fri, 15 Mar 2024 06:42:39 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id\n 42EMJOr2032321 for <dev@dpdk.org>; Thu, 14 Mar 2024 22:42:38 -0700", "from dc6wp-exch02.marvell.com ([4.21.29.225])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3wv9xa12hj-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 14 Mar 2024 22:42:38 -0700 (PDT)", "from DC6WP-EXCH02.marvell.com (10.76.176.209) by\n DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.12; Thu, 14 Mar 2024 22:42:37 -0700", "from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com\n (10.76.176.209) with Microsoft SMTP Server id 15.2.1258.12 via Frontend\n Transport; Thu, 14 Mar 2024 22:42:37 -0700", "from BG-LT92004.corp.innovium.com (unknown [10.193.69.194])\n by maili.marvell.com (Postfix) with ESMTP id 5034A3F703F;\n Thu, 14 Mar 2024 22:42:35 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=\n pfpt0220; bh=Ws3k1GuStpZg63k3NYnd3K5ZM3899P+X2XWF4+OEzNE=; b=bUD\n 4rsKH+I8Idt+dMWcu+KDLoNOfJm2b7VKOLMtYOVVbnasVbu43Pwzc0KysTO5j5xD\n L/eoBRSIbFwG/h5jG44TKZT+905H1KbqAw28qHiawnM/47GjeXuFhRkbMNuy9SYN\n yokeZ7gDcM1zyMxh9icEe7lzzB6xthqW5L5zzPpezIA6lH7nuaX43apYDIJfPGWZ\n MV+VfSucM+P2gKc1j0RXSKP6BdgWpgljFeFbtdR7902gmABaCpMPRKyYY74TWwhb\n SEaVQ4z59t1qqDAZb7rzzgNMUCsTSCv1+Nai1oVfoT2phZwhnH/sMaGq0tpoEqX3\n i7SQR8yub6zYSzZTBmA==", "From": "Vidya Sagar Velumuri <vvelumuri@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>", "CC": "Jerin Jacob <jerinj@marvell.com>, <dev@dpdk.org>, Aakash Sasidharan\n <asasidharan@marvell.com>, Anoob Joseph <anoobj@marvell.com>", "Subject": "[PATCH v3 8/8] crypto/cnxk: update the context structure of tls", "Date": "Fri, 15 Mar 2024 11:12:13 +0530", "Message-ID": "<20240315054213.540-9-vvelumuri@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240315054213.540-1-vvelumuri@marvell.com>", "References": "<20240314131839.3362494-1-vvelumuri@marvell.com>\n <20240315054213.540-1-vvelumuri@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "h8DDgnO4eiaV0M9NNI0kNBYpV6DnJ1lL", "X-Proofpoint-GUID": "h8DDgnO4eiaV0M9NNI0kNBYpV6DnJ1lL", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2024-03-14_13,2024-03-13_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Keep the record context for TLS-1.3 in sync with microcode\nstructure.\n\nReport error if optional padding is enabled for AEAD\ncase in both TLS-1.2 and DTLS-1.2.\n\nUse the proper offset for calculating the context size in case of TLS-1.3.\n\nSigned-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>\n---\n drivers/common/cnxk/roc_ie_ot_tls.h | 17 ++++++++++++-----\n drivers/crypto/cnxk/cn10k_tls.c | 6 +++---\n 2 files changed, 15 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_ie_ot_tls.h b/drivers/common/cnxk/roc_ie_ot_tls.h\nindex 39c42775f4..2d6a290d9b 100644\n--- a/drivers/common/cnxk/roc_ie_ot_tls.h\n+++ b/drivers/common/cnxk/roc_ie_ot_tls.h\n@@ -68,6 +68,16 @@ struct roc_ie_ot_tls_read_ctx_update_reg {\n \tuint64_t ar_winbits[ROC_IE_OT_TLS_AR_WINBITS_SZ];\n };\n \n+struct roc_ie_ot_tls_1_3_read_ctx_update_reg {\n+\tuint64_t rsvd0;\n+\tuint64_t ar_valid_mask;\n+\tuint64_t hard_life;\n+\tuint64_t soft_life;\n+\tuint64_t mib_octs;\n+\tuint64_t mib_pkts;\n+\tuint64_t rsvd1;\n+};\n+\n union roc_ie_ot_tls_param2 {\n \tuint16_t u16;\n \tstruct {\n@@ -137,11 +147,8 @@ struct roc_ie_ot_tls_read_sa {\n \n \tunion {\n \t\tstruct {\n-\t\t\t/* Word10 */\n-\t\t\tuint64_t w10_rsvd6;\n-\n-\t\t\t/* Word11 - Word25 */\n-\t\t\tstruct roc_ie_ot_tls_read_ctx_update_reg ctx;\n+\t\t\t/* Word10 - Word16 */\n+\t\t\tstruct roc_ie_ot_tls_1_3_read_ctx_update_reg ctx;\n \t\t} tls_13;\n \n \t\tstruct {\ndiff --git a/drivers/crypto/cnxk/cn10k_tls.c b/drivers/crypto/cnxk/cn10k_tls.c\nindex 3505a71a6c..7b73a58d2a 100644\n--- a/drivers/crypto/cnxk/cn10k_tls.c\n+++ b/drivers/crypto/cnxk/cn10k_tls.c\n@@ -121,8 +121,8 @@ cnxk_tls_xform_verify(struct rte_security_tls_record_xform *tls_xform,\n \n \tif (crypto_xform->type == RTE_CRYPTO_SYM_XFORM_AEAD) {\n \t\t/* optional padding is not allowed in TLS-1.2 for AEAD */\n-\t\tif ((tls_xform->ver == RTE_SECURITY_VERSION_TLS_1_2) &&\n-\t\t (tls_xform->options.extra_padding_enable == 1))\n+\t\tif ((tls_xform->options.extra_padding_enable == 1) &&\n+\t\t (tls_xform->ver != RTE_SECURITY_VERSION_TLS_1_3))\n \t\t\treturn -EINVAL;\n \n \t\treturn tls_xform_aead_verify(tls_xform, crypto_xform);\n@@ -312,7 +312,7 @@ tls_read_ctx_size(struct roc_ie_ot_tls_read_sa *sa, enum rte_security_tls_versio\n \t/* Variable based on Anti-replay Window */\n \tif (tls_ver == RTE_SECURITY_VERSION_TLS_1_3) {\n \t\tsize = offsetof(struct roc_ie_ot_tls_read_sa, tls_13.ctx) +\n-\t\t offsetof(struct roc_ie_ot_tls_read_ctx_update_reg, ar_winbits);\n+\t\t sizeof(struct roc_ie_ot_tls_1_3_read_ctx_update_reg);\n \t} else {\n \t\tsize = offsetof(struct roc_ie_ot_tls_read_sa, tls_12.ctx) +\n \t\t offsetof(struct roc_ie_ot_tls_read_ctx_update_reg, ar_winbits);\n", "prefixes": [ "v3", "8/8" ] }