Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138417/?format=api
{ "id": 138417, "url": "http://patches.dpdk.org/api/patches/138417/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240315054213.540-6-vvelumuri@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240315054213.540-6-vvelumuri@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240315054213.540-6-vvelumuri@marvell.com", "date": "2024-03-15T05:42:10", "name": "[v3,5/8] crypto/cnxk: move metadata to second cacheline", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8694cb8c12c5e4fc9d84960df7da2d2c3714ea9b", "submitter": { "id": 2363, "url": "http://patches.dpdk.org/api/people/2363/?format=api", "name": "Vidya Sagar Velumuri", "email": "vvelumuri@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240315054213.540-6-vvelumuri@marvell.com/mbox/", "series": [ { "id": 31530, "url": "http://patches.dpdk.org/api/series/31530/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31530", "date": "2024-03-15T05:42:05", "name": "Fixes and minor improvements for Crypto cnxk", "version": 3, "mbox": "http://patches.dpdk.org/series/31530/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138417/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/138417/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A0B1243CA6;\n\tFri, 15 Mar 2024 06:43:38 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3754342ECB;\n\tFri, 15 Mar 2024 06:43:15 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 1CE9E410FC\n for <dev@dpdk.org>; Fri, 15 Mar 2024 06:42:31 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id\n 42F0aS24018658 for <dev@dpdk.org>; Thu, 14 Mar 2024 22:42:30 -0700", "from dc6wp-exch02.marvell.com ([4.21.29.225])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3wvbxbrpg6-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 14 Mar 2024 22:42:30 -0700 (PDT)", "from DC6WP-EXCH02.marvell.com (10.76.176.209) by\n DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.12; Thu, 14 Mar 2024 22:42:29 -0700", "from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com\n (10.76.176.209) with Microsoft SMTP Server id 15.2.1258.12 via Frontend\n Transport; Thu, 14 Mar 2024 22:42:29 -0700", "from BG-LT92004.corp.innovium.com (unknown [10.193.69.194])\n by maili.marvell.com (Postfix) with ESMTP id 7B4A85B6939;\n Thu, 14 Mar 2024 22:42:27 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=\n pfpt0220; bh=pnRqFUugNY9z/K+q6dpb9JUYgBPHBjAENHt+JA+Bo5M=; b=fMb\n vC90EQUmb/8nlxopmpLoaYOxmffg5lh2O5AZS4c/MRjgWiPujWpJjvuohaeAAPAi\n 0Mc12oHS4NhC9bf6d/TNFO7x6tO8n8aYzY8SvJ+cd0Efj9I1fx+cIDBaOjp37FfY\n btgf1h6AVCnl9o9E9Y7upNFr1J7NNaH85isdNUNnYvdA9wDMIq7Zqor+L3uvqQPF\n Wbz4kei0hPqZTHXQv4rPTuiRDPDKvgNKNRFoBmt19SfnYDZC6KeTZ4Yy0Gm/GGbi\n QzeS1wBv/A23kWaHJCOmc7m65g3MrQwypbYG7VpZFHvpy7NdVmQxgohTHWXFk35P\n dF00z9zroGonyd0G2vA==", "From": "Vidya Sagar Velumuri <vvelumuri@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>", "CC": "Anoob Joseph <anoobj@marvell.com>, Jerin Jacob <jerinj@marvell.com>,\n <dev@dpdk.org>, Aakash Sasidharan <asasidharan@marvell.com>", "Subject": "[PATCH v3 5/8] crypto/cnxk: move metadata to second cacheline", "Date": "Fri, 15 Mar 2024 11:12:10 +0530", "Message-ID": "<20240315054213.540-6-vvelumuri@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240315054213.540-1-vvelumuri@marvell.com>", "References": "<20240314131839.3362494-1-vvelumuri@marvell.com>\n <20240315054213.540-1-vvelumuri@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "TV3oDokyhsuzSM3IHWsJ_n4G7ci3aKk1", "X-Proofpoint-ORIG-GUID": "TV3oDokyhsuzSM3IHWsJ_n4G7ci3aKk1", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2024-03-14_13,2024-03-13_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Anoob Joseph <anoobj@marvell.com>\n\nIn security session, move PMD metadata to second cacheline. Also\noptimize the fields to minimize the memory usage.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>\n---\n drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 10 ++++++----\n drivers/crypto/cnxk/cn10k_ipsec.c | 4 ++--\n drivers/crypto/cnxk/cn10k_tls.c | 2 +-\n 3 files changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/crypto/cnxk/cn10k_cryptodev_sec.h b/drivers/crypto/cnxk/cn10k_cryptodev_sec.h\nindex 881a0276cc..230c0f7c1c 100644\n--- a/drivers/crypto/cnxk/cn10k_cryptodev_sec.h\n+++ b/drivers/crypto/cnxk/cn10k_cryptodev_sec.h\n@@ -5,6 +5,7 @@\n #ifndef __CN10K_CRYPTODEV_SEC_H__\n #define __CN10K_CRYPTODEV_SEC_H__\n \n+#include <rte_common.h>\n #include <rte_security.h>\n \n #include \"roc_constants.h\"\n@@ -19,23 +20,24 @@ struct cn10k_sec_session {\n \tuint8_t rte_sess[SEC_SESS_SIZE];\n \n \t/** PMD private space */\n+\tRTE_MARKER cacheline1 __rte_cache_aligned;\n \n-\tenum rte_security_session_protocol proto;\n \t/** Pre-populated CPT inst words */\n \tstruct cnxk_cpt_inst_tmpl inst;\n \tuint16_t max_extended_len;\n \tuint16_t iv_offset;\n+\tuint8_t proto;\n \tuint8_t iv_length;\n \tunion {\n \t\tstruct {\n \t\t\tuint8_t ip_csum;\n-\t\t\tbool is_outbound;\n+\t\t\tuint8_t is_outbound : 1;\n \t\t} ipsec;\n \t\tstruct {\n \t\t\tuint8_t enable_padding : 1;\n \t\t\tuint8_t tail_fetch_len : 2;\n-\t\t\tuint8_t rvsd : 5;\n-\t\t\tbool is_write;\n+\t\t\tuint8_t is_write : 1;\n+\t\t\tuint8_t rvsd : 4;\n \t\t} tls;\n \t};\n \t/** Queue pair */\ndiff --git a/drivers/crypto/cnxk/cn10k_ipsec.c b/drivers/crypto/cnxk/cn10k_ipsec.c\nindex 74d6cd70d1..ef5f0ff4aa 100644\n--- a/drivers/crypto/cnxk/cn10k_ipsec.c\n+++ b/drivers/crypto/cnxk/cn10k_ipsec.c\n@@ -76,7 +76,7 @@ cn10k_ipsec_outb_sa_create(struct roc_cpt *roc_cpt, struct roc_cpt_lf *lf,\n \t}\n #endif\n \n-\tsec_sess->ipsec.is_outbound = true;\n+\tsec_sess->ipsec.is_outbound = 1;\n \n \t/* Get Rlen calculation data */\n \tret = cnxk_ipsec_outb_rlens_get(&rlens, ipsec_xfrm, crypto_xfrm);\n@@ -177,7 +177,7 @@ cn10k_ipsec_inb_sa_create(struct roc_cpt *roc_cpt, struct roc_cpt_lf *lf,\n \t\tgoto sa_dptr_free;\n \t}\n \n-\tsec_sess->ipsec.is_outbound = false;\n+\tsec_sess->ipsec.is_outbound = 0;\n \tsec_sess->inst.w7 = cpt_inst_w7_get(roc_cpt, in_sa);\n \n \t/* Save index/SPI in cookie, specific required for Rx Inject */\ndiff --git a/drivers/crypto/cnxk/cn10k_tls.c b/drivers/crypto/cnxk/cn10k_tls.c\nindex 11279dac46..ae3ed3176c 100644\n--- a/drivers/crypto/cnxk/cn10k_tls.c\n+++ b/drivers/crypto/cnxk/cn10k_tls.c\n@@ -739,7 +739,7 @@ cn10k_tls_write_sa_create(struct roc_cpt *roc_cpt, struct roc_cpt_lf *lf,\n \t\tsec_sess->iv_length = crypto_xfrm->next->cipher.iv.length;\n \t}\n \n-\tsec_sess->tls.is_write = true;\n+\tsec_sess->tls.is_write = 1;\n \tsec_sess->tls.enable_padding = tls_xfrm->options.extra_padding_enable;\n \tsec_sess->max_extended_len = tls_write_rlens_get(tls_xfrm, crypto_xfrm);\n \tsec_sess->proto = RTE_SECURITY_PROTOCOL_TLS_RECORD;\n", "prefixes": [ "v3", "5/8" ] }