Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138393/?format=api
{ "id": 138393, "url": "http://patches.dpdk.org/api/patches/138393/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240314114220.203241-10-igozlan@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240314114220.203241-10-igozlan@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240314114220.203241-10-igozlan@nvidia.com", "date": "2024-03-14T11:42:17", "name": "[10/13] net/mlx5/hws: fix rule is in resize check", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b94c5ec5ef652453689a200e3488f4ed6b0ef7aa", "submitter": { "id": 3118, "url": "http://patches.dpdk.org/api/people/3118/?format=api", "name": "Itamar Gozlan", "email": "igozlan@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240314114220.203241-10-igozlan@nvidia.com/mbox/", "series": [ { "id": 31512, "url": "http://patches.dpdk.org/api/series/31512/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31512", "date": "2024-03-14T11:42:08", "name": "[01/13] net/mlx5/hws: move warn into debug level when needed", "version": 1, "mbox": "http://patches.dpdk.org/series/31512/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138393/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138393/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E7E2943CA5;\n\tThu, 14 Mar 2024 12:44:29 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C08B242EDB;\n\tThu, 14 Mar 2024 12:43:39 +0100 (CET)", "from NAM12-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam12on2085.outbound.protection.outlook.com [40.107.243.85])\n by mails.dpdk.org (Postfix) with ESMTP id 9D6AA42ECC\n for <dev@dpdk.org>; Thu, 14 Mar 2024 12:43:36 +0100 (CET)", "from DS7PR03CA0167.namprd03.prod.outlook.com (2603:10b6:5:3b2::22)\n by MN6PR12MB8514.namprd12.prod.outlook.com (2603:10b6:208:474::16) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.33; Thu, 14 Mar\n 2024 11:43:32 +0000", "from CY4PEPF0000E9DB.namprd05.prod.outlook.com\n (2603:10b6:5:3b2:cafe::b2) by DS7PR03CA0167.outlook.office365.com\n (2603:10b6:5:3b2::22) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.21 via Frontend\n Transport; Thu, 14 Mar 2024 11:43:32 +0000", "from mail.nvidia.com (216.228.117.161) by\n CY4PEPF0000E9DB.mail.protection.outlook.com (10.167.241.81) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 11:43:32 +0000", "from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Mar\n 2024 04:43:22 -0700", "from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail203.nvidia.com\n (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 14 Mar\n 2024 04:43:21 -0700", "from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend\n Transport; Thu, 14 Mar 2024 04:43:18 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=E/AZe/hmudDjfQS08rhrEOmNtrqQy/Ebh+WyU/EhIchMyAIJaae8qVHQRCvXHBzwRgkRxDVYg12/539MHhiNfK2YzmjpDeE3ziNC+Hr8r2+g44OR1sgaVQ3jfKvmISXi8PLfXZfUPzuh40stqS03LZOpOQSRFV/1txAm9mt2sMWBU+AXHtPWFqdtWz7IFoClEkWQjPIPsV+DCFHLZ7unCjcFO7Gu8jxtodDMgpANNS0qbkCq/furQmY8cck8nIaHMXaWUqB0nRVeYd3dJokJYaNvIN9PNPF2qSD9lqHkdYPgq+FZ0N0odkiy0Wx0Uhz4HzLuiZBZ2vzs24fmgJyDnw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=NQxJgIlO1iuKcyHGuqLuf6ZWEg488S1jViRG5gr1qs4=;\n b=gNoH0Rd3I+7hIiFv9FRPxZOoo4szJOkbtG035/u6fwQpzOwZh+PhPdbYZ8WKcZ5XaRANTaAZ6KYSBg5D0TBfVZkUjcpqdkVmdjIPx48cMqHEqGQ6HFfn0P1qhZl7VXtW3HQ670kNg9tv/G1BUz99ce9F44pD7Jw12CRvg/UwlVT6bxwG+NEYoB/m2bcrEQuM0GUDW7FgAuYPzJfdpxnVXFYLzQD1hyJQw83CJIGOreGxxOTD7SgVPXxICPrQCV0v16hA9nS10qWdNoGW7wlqHyhuTzkzNW0ayFmKiq4dQcWDCZayvKO2xSq+ClWXxf8okuOOA70bFw9B4kKpANH2bw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=NQxJgIlO1iuKcyHGuqLuf6ZWEg488S1jViRG5gr1qs4=;\n b=MT9jQtVrj4lbBUAMj9oFE8noV4OiY5shyzhHvj1s7VMDvv1QPZjXxGuTCcINs0D6H/VwTf5Il3ISLAsAubc+VTcEv+aKLrRQ4a9BJaf2hGAXjJ996Tta7uGkFc3069RQw/yVCm91wb/uZgz+vRJNXNMwLeop1VTqZwbjQl1OnN2c2mFtPDPbCjkCmI2PD8dptehGiGSlV/F63dq+4qScgASYDtGe9Lt+v2ZqjpZkhj6jFzS8RPWb/mcs/x/1vL4f031yDeZPFQivtlNcpYxJ6n/V6dtz6i3oPYamwMMjYHsEvWPfkWUKksKfX683bjLAm1TwpPj3onU+sPZtZJngEA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Itamar Gozlan <igozlan@nvidia.com>", "To": "<igozlan@nvidia.com>, <erezsh@nvidia.com>, <hamdani@nvidia.com>,\n <kliteyn@nvidia.com>, <valex@nvidia.com>, <viacheslavo@nvidia.com>,\n <thomas@monjalon.net>, Dariusz Sosnowski <dsosnowski@nvidia.com>, Ori Kam\n <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>, Matan Azrad\n <matan@nvidia.com>", "CC": "<dev@dpdk.org>, <mkashani@nvidia.com>", "Subject": "[PATCH 10/13] net/mlx5/hws: fix rule is in resize check", "Date": "Thu, 14 Mar 2024 13:42:17 +0200", "Message-ID": "<20240314114220.203241-10-igozlan@nvidia.com>", "X-Mailer": "git-send-email 2.39.3", "In-Reply-To": "<20240314114220.203241-1-igozlan@nvidia.com>", "References": "<20240314114220.203241-1-igozlan@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-NV-OnPremToCloud": "ExternallySecured", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CY4PEPF0000E9DB:EE_|MN6PR12MB8514:EE_", "X-MS-Office365-Filtering-Correlation-Id": "be9e4b3c-a756-4331-0395-08dc441bf990", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n EI50Wio1Lb1rgT7iqvW/P3Q9cTis89llMK4Lk1hhv9//vyqp5Ovt+xkRUfoVZkwAjuuNZI/nnQa1QkjPUuOnHAP9VS6aFsb1ZWyKTnTsaoHbnoeX1Z6rjCb7NNKLYAvjvC07QIubaE7+C3YoHO3H5FtMy7Ai+TvEI6Z30p9/QX6r7diV4tb4PFsfq4HsO52IGzfPbq+5TTyQZMrqGauMRqSV9w6rxK5APLd4wrfuiF7fVG53WzO9sxazGVEfpb55WJurUyHBZ7ujOkEG9YzC3dskZyPsVq8MtHvLTXBjWanFreFpLlewvrcbknFF/qvvwKI1jdtlJpDMZRPUW+LZazygFSM76bKROatPPR/tW7QMqvkRTkeCdcCFkOzjLE5oVN8Gv47wsGieaz4JztxihlrFfLgs35ZOeKw6eQxb4AS7vynqwRSSCpU/91xh/zfOKtplpvOVl1mIoRTHcUayO7E4bSefRAF55BiQlGyRe9+VjWNwEbSjruk1IT9l/OgafUyWs7waAQAi7YO8jBXu5YSwbbQupqJogp48ewvpPio86JAZV3s+OIUaRj+RyvDqlbOWJDPI/t33wogewYPhHp9QPaLxzW3v5wR4inyLsBIMgRGkY/aY2CHHxpphKMRQzJ7fucqcN/2XCOlxQWOeL+I7kV39GoTkNCXkuipL3DtkHOk/GkYLc5dwGAilPspsTo27Yvqgqf9rapzgsgP/hTMSiemd2m1mMwX/cCM15LKn90/hvZ0mCffI95T389PVr80yp/nDawOGaP74cBsgZg==", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230031)(36860700004)(376005)(1800799015)(82310400014)(921011);\n DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Mar 2024 11:43:32.0444 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n be9e4b3c-a756-4331-0395-08dc441bf990", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CY4PEPF0000E9DB.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN6PR12MB8514", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Alex Vesker <valex@nvidia.com>\n\nThe check to detect if a rule is in resize was done incorrectly,\nthis can lead to an incorrect function call upon completion for\nrules which are not in resize (move).\nSince the resize_info is in a union we cannot rely only on the\npointer value but also need to make sure the matcher is in resize\nprocess, this assures us the resize info is valid.\n\nFixes: 762feceb8294 (\"net/mlx5/hws: support resizable matchers\")\nSigned-off-by: Alex Vesker <valex@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/hws/mlx5dr_rule.c | 7 +++++++\n drivers/net/mlx5/hws/mlx5dr_rule.h | 6 +-----\n 2 files changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c\nindex 7bcf2de55f..3e8e90ba76 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_rule.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_rule.c\n@@ -350,6 +350,13 @@ static void mlx5dr_rule_move_init(struct mlx5dr_rule *rule,\n \trule->resize_info->state = MLX5DR_RULE_RESIZE_STATE_WRITING;\n }\n \n+bool mlx5dr_rule_move_in_progress(struct mlx5dr_rule *rule)\n+{\n+\treturn unlikely(mlx5dr_matcher_is_in_resize(rule->matcher)) &&\n+\t rule->resize_info &&\n+\t rule->resize_info->state != MLX5DR_RULE_RESIZE_STATE_IDLE;\n+}\n+\n static int mlx5dr_rule_create_hws_fw_wqe(struct mlx5dr_rule *rule,\n \t\t\t\t\t struct mlx5dr_rule_attr *attr,\n \t\t\t\t\t uint8_t mt_idx,\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_rule.h b/drivers/net/mlx5/hws/mlx5dr_rule.h\nindex 07adf9c5ad..dffaec1c0f 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_rule.h\n+++ b/drivers/net/mlx5/hws/mlx5dr_rule.h\n@@ -72,10 +72,6 @@ int mlx5dr_rule_move_hws_remove(struct mlx5dr_rule *rule,\n int mlx5dr_rule_move_hws_add(struct mlx5dr_rule *rule,\n \t\t\t struct mlx5dr_rule_attr *attr);\n \n-static inline bool mlx5dr_rule_move_in_progress(struct mlx5dr_rule *rule)\n-{\n-\treturn rule->resize_info &&\n-\t rule->resize_info->state != MLX5DR_RULE_RESIZE_STATE_IDLE;\n-}\n+bool mlx5dr_rule_move_in_progress(struct mlx5dr_rule *rule);\n \n #endif /* MLX5DR_RULE_H_ */\n", "prefixes": [ "10/13" ] }