Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138387/?format=api
{ "id": 138387, "url": "http://patches.dpdk.org/api/patches/138387/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240314114220.203241-4-igozlan@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240314114220.203241-4-igozlan@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240314114220.203241-4-igozlan@nvidia.com", "date": "2024-03-14T11:42:11", "name": "[04/13] net/mlx5/hws: remove unused capabilities and fields", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0c86926129790fb591e49800ad302a813dba8f02", "submitter": { "id": 3118, "url": "http://patches.dpdk.org/api/people/3118/?format=api", "name": "Itamar Gozlan", "email": "igozlan@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240314114220.203241-4-igozlan@nvidia.com/mbox/", "series": [ { "id": 31512, "url": "http://patches.dpdk.org/api/series/31512/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31512", "date": "2024-03-14T11:42:08", "name": "[01/13] net/mlx5/hws: move warn into debug level when needed", "version": 1, "mbox": "http://patches.dpdk.org/series/31512/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138387/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138387/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4129743CA5;\n\tThu, 14 Mar 2024 12:43:31 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3504442EAD;\n\tThu, 14 Mar 2024 12:43:23 +0100 (CET)", "from NAM12-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam12on2061.outbound.protection.outlook.com [40.107.243.61])\n by mails.dpdk.org (Postfix) with ESMTP id 8EE8D42E89\n for <dev@dpdk.org>; Thu, 14 Mar 2024 12:43:14 +0100 (CET)", "from CH2PR11CA0027.namprd11.prod.outlook.com (2603:10b6:610:54::37)\n by SA3PR12MB8021.namprd12.prod.outlook.com (2603:10b6:806:305::16)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.21; Thu, 14 Mar\n 2024 11:43:11 +0000", "from CH3PEPF0000000C.namprd04.prod.outlook.com\n (2603:10b6:610:54:cafe::98) by CH2PR11CA0027.outlook.office365.com\n (2603:10b6:610:54::37) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36 via Frontend\n Transport; Thu, 14 Mar 2024 11:43:11 +0000", "from mail.nvidia.com (216.228.117.160) by\n CH3PEPF0000000C.mail.protection.outlook.com (10.167.244.39) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 11:43:10 +0000", "from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Mar\n 2024 04:42:59 -0700", "from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail205.nvidia.com\n (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 14 Mar\n 2024 04:42:59 -0700", "from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend\n Transport; Thu, 14 Mar 2024 04:42:56 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Qjja3TLrB1Ozz/6WrsocOylTWcQSJwba7hXj6fYtiSCAKZUDm1U4pGcuhcrqODwSbhtV1NKLbZPxRbK6G7X/sTR0IvfyMlvWtNCvUSlaQcERs4cil7AniK5p3ZzUH2kCV9GylvsCLXzPkufwuodjFFi4E8SAHBRk3FxiTjEYD6jPoVNw+kTHQ19P9LOiHslcrhW2P+1hSS9JZ4HN9fB2eTCv+9567He24Izooob8igwzfVUhHj4evRj03RbOyp22IZ3JrCgDXi6LfhRU6d91pikK9/FZoI1mTNbunYEKWUSqmw84CKweg2ibFECY+zQg73Ap6RhLePCHeHhCvBxgyQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=cuBzhutTkD9BFus82ufCUwEb6ahUTKmQ7XOjKwoEojg=;\n b=FdKGXJiOivlFr3NhoFBR5pHCyhXgSEK+PcNfy/1DxTCsLQ+O8IslhSvU7MtXHzArBGGfnAv40RetEUOFauzyvrayx/n23zj+rr1pr1mDdpmAncLapEMBbJCvK/NBXxdAh/xG7z94gWMhAStYxZGxVQiEeooayvkmrGvUkXVfIKSB8bpVhSB/eisuK0W+n5ArYHhuVkd3Tvm5gxC86cgQwa+1tG0ytBge4xQwRl2fTQCagnNSrp37kFBcBW6XRDPKqK9Z46aHehQtFIgQLe/CSR7ENQXmK77P+2Ml9JT61GioE3uP+Z20LmslJO8D6Qa5x2igk5Q+2mcfSL2zvj95mg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=cuBzhutTkD9BFus82ufCUwEb6ahUTKmQ7XOjKwoEojg=;\n b=AidvcTQuE/T6i8poly+HeH1rftly+rfeRIv15x8w4/EL7FdPogKiWBda5Gm4QJDA+Zn5V3LMjA6R6eF2q1Ch2UdNduyctxAKmLhfwpIuffqgwzw/GLxTCdd/vPI8+pY2vJ1PtCoSeHbyE8F9whej+q8s3DYUSiAqWH4ToxT/T3XXswZh9TD8Dw5khVp51+C2C96ZCFDD1EDXsgFN6uHVWvjnloz1P5AGzmX15FCLaOEnZBhL7NsPap0ynZXmnqnV3jiKrd4+d7ZnH7y2s5se4VsT2msXVEi+GXXvgnnLTByuxAot0lvqZxwVBnwy5jB1gDWZ4+92Vc4BDayrsHDGpw==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Itamar Gozlan <igozlan@nvidia.com>", "To": "<igozlan@nvidia.com>, <erezsh@nvidia.com>, <hamdani@nvidia.com>,\n <kliteyn@nvidia.com>, <valex@nvidia.com>, <viacheslavo@nvidia.com>,\n <thomas@monjalon.net>, Dariusz Sosnowski <dsosnowski@nvidia.com>, Ori Kam\n <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>, Matan Azrad\n <matan@nvidia.com>", "CC": "<dev@dpdk.org>, <mkashani@nvidia.com>", "Subject": "[PATCH 04/13] net/mlx5/hws: remove unused capabilities and fields", "Date": "Thu, 14 Mar 2024 13:42:11 +0200", "Message-ID": "<20240314114220.203241-4-igozlan@nvidia.com>", "X-Mailer": "git-send-email 2.39.3", "In-Reply-To": "<20240314114220.203241-1-igozlan@nvidia.com>", "References": "<20240314114220.203241-1-igozlan@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-NV-OnPremToCloud": "ExternallySecured", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CH3PEPF0000000C:EE_|SA3PR12MB8021:EE_", "X-MS-Office365-Filtering-Correlation-Id": "4c42c8dc-8b03-42d1-5f65-08dc441becf5", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n akXHCfK2fZhieMSud2G9bPyI7akLZRbYCw+ifbMbAlhFjG1/euzMGalhnrcBJlBWd7iO/D8kcnPvnloi0KyyHX1Hqwu46XupfQ4pMEKL1AJwz4l/yysgEKNgZMb2cqEVfnyEfPAlt83QIfkdxrsPB6DY1Z7o3ibUPKvUWuk5QYQ+akrjTd20pFXIMQk7/G5NhbzmdPyz22oHwq7yDeRoBe+DwxXe0UPRoKU97xqU+SPfXNlt2+uJ/WcnQsnO4DK8pc1m1lKOLUysiTl43l9DErQZe0bzle4RA2WpK+581cK+92YeGVuf83It5LESYv1pLnbABiuGfdfkEByhLdWCQ7tkO2EGqbRs6GOc323tZOFdNpxrddYl1hKMlSUZDTh+ANsS7/CR9eU5DWYdw+YS9z6SGPW5+A1eSXzWUITcZFD7vC7WZkr/T8fvmTu8IZo7n17DSMRCc/QyglimzQ19fgAfLFT2In7D/7ClcaADUEXWi9LRkqHShfbJEGGrIEGUwMdcqMceVq8M76O5k7LboqNb1xvNJsQncoHpFf9XC33qlDyvqjRltEGK3i9ZCYdtCCxD34SpbbJU6lRCfCoUe3rhb5IU2Cj/JhtAiBAWFP4t4TQHZxn8mLpVMtkJCUJI2kBD60f127+VwI956DkpCAmcyU1VVi2Uo1vPlYIiQcCFEI1yC743PHowUzwUpYaPM2IfhApUs86eGfMHmWOakwOcX7gda5EWph9emqfIjsKX846dIF8ktjot4BgLNCXeWewA8mp96EyErjwaDi2e/Q==", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(36860700004)(376005)(82310400014)(1800799015)(921011);\n DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Mar 2024 11:43:10.8514 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 4c42c8dc-8b03-42d1-5f65-08dc441becf5", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CH3PEPF0000000C.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SA3PR12MB8021", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Yevgeny Kliteynik <kliteyn@nvidia.com>\n\nThe following caps were never in use:\n - wire_regc\n - metadata_c\n - metadata_c_mask\nAlso send ring's reg_addr field wasn't in use.\n\nRemoving these caps and fields from structs and removing\nthe code that queried them.\n\nSigned-off-by: Yevgeny Kliteynik <kliteyn@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/hws/mlx5dr_cmd.c | 11 ++---------\n drivers/net/mlx5/hws/mlx5dr_cmd.h | 3 ---\n drivers/net/mlx5/hws/mlx5dr_send.c | 1 -\n drivers/net/mlx5/hws/mlx5dr_send.h | 1 -\n 4 files changed, 2 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c\nindex 0e0cc479a6..666d678b42 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_cmd.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c\n@@ -1344,12 +1344,10 @@ int mlx5dr_cmd_query_caps(struct ibv_context *ctx,\n \tstrlcpy(caps->fw_ver, attr_ex.orig_attr.fw_ver, sizeof(caps->fw_ver));\n \n \tport_info = flow_hw_get_wire_port(ctx);\n-\tif (port_info) {\n-\t\tcaps->wire_regc = port_info->regc_value;\n+\tif (port_info)\n \t\tcaps->wire_regc_mask = port_info->regc_mask;\n-\t} else {\n+\telse\n \t\tDR_LOG(INFO, \"Failed to query wire port regc value\");\n-\t}\n \n \treturn ret;\n }\n@@ -1374,10 +1372,5 @@ int mlx5dr_cmd_query_ib_port(struct ibv_context *ctx,\n \tvport_caps->vport_num = port_info.vport_id;\n \tvport_caps->esw_owner_vhca_id = port_info.esw_owner_vhca_id;\n \n-\tif (port_info.query_flags & MLX5_PORT_QUERY_REG_C0) {\n-\t\tvport_caps->metadata_c = port_info.vport_meta_tag;\n-\t\tvport_caps->metadata_c_mask = port_info.vport_meta_mask;\n-\t}\n-\n \treturn 0;\n }\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.h b/drivers/net/mlx5/hws/mlx5dr_cmd.h\nindex 9d385fc57f..ea5d346d8e 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_cmd.h\n+++ b/drivers/net/mlx5/hws/mlx5dr_cmd.h\n@@ -194,8 +194,6 @@ struct mlx5dr_cmd_query_ft_caps {\n struct mlx5dr_cmd_query_vport_caps {\n \tuint16_t vport_num;\n \tuint16_t esw_owner_vhca_id;\n-\tuint32_t metadata_c;\n-\tuint32_t metadata_c_mask;\n };\n \n struct mlx5dr_cmd_generate_wqe_attr {\n@@ -207,7 +205,6 @@ struct mlx5dr_cmd_generate_wqe_attr {\n };\n \n struct mlx5dr_cmd_query_caps {\n-\tuint32_t wire_regc;\n \tuint32_t wire_regc_mask;\n \tuint32_t flex_protocols;\n \tuint8_t wqe_based_update;\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c\nindex f749401c6f..d58fdb108f 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_send.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_send.c\n@@ -729,7 +729,6 @@ static int mlx5dr_send_ring_open_sq(struct mlx5dr_context *ctx,\n \tbuf_sz = queue->num_entries * MAX_WQES_PER_RULE;\n \tsq_log_buf_sz = log2above(buf_sz);\n \tsq_buf_sz = 1 << (sq_log_buf_sz + log2above(MLX5_SEND_WQE_BB));\n-\tsq->reg_addr = queue->uar->reg_addr;\n \n \tpage_size = sysconf(_SC_PAGESIZE);\n \tbuf_aligned = align(sq_buf_sz, page_size);\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_send.h b/drivers/net/mlx5/hws/mlx5dr_send.h\nindex 0c89faa8a7..48593adbed 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_send.h\n+++ b/drivers/net/mlx5/hws/mlx5dr_send.h\n@@ -114,7 +114,6 @@ struct mlx5dr_send_ring_sq {\n \tchar *buf;\n \tuint32_t sqn;\n \t__be32 *db;\n-\tvoid *reg_addr;\n \tuint16_t cur_post;\n \tuint16_t buf_mask;\n \tstruct mlx5dr_send_ring_priv *wr_priv;\n", "prefixes": [ "04/13" ] }