Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138372/?format=api
{ "id": 138372, "url": "http://patches.dpdk.org/api/patches/138372/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240314093630.1066948-2-mingjinx.ye@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240314093630.1066948-2-mingjinx.ye@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240314093630.1066948-2-mingjinx.ye@intel.com", "date": "2024-03-14T09:36:28", "name": "[1/3] bus/vdev: revert fix devargs in secondary process", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "19d56c3e173c19eb7760dcb76e686b8750f60b8f", "submitter": { "id": 2862, "url": "http://patches.dpdk.org/api/people/2862/?format=api", "name": "Mingjin Ye", "email": "mingjinx.ye@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240314093630.1066948-2-mingjinx.ye@intel.com/mbox/", "series": [ { "id": 31507, "url": "http://patches.dpdk.org/api/series/31507/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31507", "date": "2024-03-14T09:36:27", "name": "fix insert dev core dump", "version": 1, "mbox": "http://patches.dpdk.org/series/31507/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138372/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138372/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5E26143CB2;\n\tThu, 14 Mar 2024 10:54:40 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3A19742E4C;\n\tThu, 14 Mar 2024 10:54:37 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.17])\n by mails.dpdk.org (Postfix) with ESMTP id 004CC400D5;\n Thu, 14 Mar 2024 10:54:34 +0100 (CET)", "from orviesa010.jf.intel.com ([10.64.159.150])\n by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Mar 2024 02:54:34 -0700", "from unknown (HELO localhost.localdomain) ([10.239.252.253])\n by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Mar 2024 02:54:33 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1710410075; x=1741946075;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=U/9hDK+WemuwTzVaiO2ua2FU9uZ/uKlnzmoxOBfYsGs=;\n b=g9AVdc/alQxMBq3VVwdR6JdzBh1aJyiy5DikFNPb4De+NDMZyHhUl+yW\n 4MfSnBG/fSU8It1qqavcoy/D1/V5sk7MOuCckmAHuthpw5K+Q6T+Dk0h3\n 27FGOfI505f/uGAlvAYrapk7lcFCeIMsk/DfXhxQztscAEjtHej7Bbx1W\n zBu8SGdXCJfR4MMdQId6ncjbKL1a0obPTd1mRKCTjYhR5V+2PlSxDogHJ\n Z7nATQygNRh28KO1+0XdM3sRoteHCkB7jTnDJLrHGUzYrkzCSSu5H3BPw\n HTbxgLl4h3Kd9Jj7nFRhOO9dFWjlt3MNK2Ip5Zk6UlX8B5eiN/4TuxIG1 A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11012\"; a=\"5339884\"", "E=Sophos;i=\"6.07,125,1708416000\";\n d=\"scan'208\";a=\"5339884\"", "E=Sophos;i=\"6.07,125,1708416000\"; d=\"scan'208\";a=\"12125201\"" ], "X-ExtLoop1": "1", "From": "Mingjin Ye <mingjinx.ye@intel.com>", "To": "dev@dpdk.org", "Cc": "Mingjin Ye <mingjinx.ye@intel.com>, stable@dpdk.org,\n Anatoly Burakov <anatoly.burakov@intel.com>", "Subject": "[PATCH 1/3] bus/vdev: revert fix devargs in secondary process", "Date": "Thu, 14 Mar 2024 09:36:28 +0000", "Message-Id": "<20240314093630.1066948-2-mingjinx.ye@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240314093630.1066948-1-mingjinx.ye@intel.com>", "References": "<20240314093630.1066948-1-mingjinx.ye@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The asan tool detected a memory leak in the vdev driver\nalloc_devargs. The previous commit was that when inserting\na vdev device, the primary process alloc devargs and the\nsecondary process looks for devargs. This causes the\ndevice to not be created if the secondary process does\nnot initialise the vdev device. And, this is not the\nroot cause.\n\nTherefore the following commit was reverted accordingly.\n\nFixes: 6666628362c9 (\"bus/vdev: fix devargs in secondary process\")\n\nAfter restoring this commit, the memory leak still exists.\nA new patch has since fixed this issue.\n\nFixes: 6666628362c9 (\"bus/vdev: fix devargs in secondary process\")\nCc: stable@dpdk.org\n\nSigned-off-by: Mingjin Ye <mingjinx.ye@intel.com>\n---\n drivers/bus/vdev/vdev.c | 21 +--------------------\n 1 file changed, 1 insertion(+), 20 deletions(-)", "diff": "diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c\nindex 14cf856237..38d05a9fe9 100644\n--- a/drivers/bus/vdev/vdev.c\n+++ b/drivers/bus/vdev/vdev.c\n@@ -263,22 +263,6 @@ alloc_devargs(const char *name, const char *args)\n \treturn devargs;\n }\n \n-static struct rte_devargs *\n-vdev_devargs_lookup(const char *name)\n-{\n-\tstruct rte_devargs *devargs;\n-\tchar dev_name[32];\n-\n-\tRTE_EAL_DEVARGS_FOREACH(\"vdev\", devargs) {\n-\t\tdevargs->bus->parse(devargs->name, &dev_name);\n-\t\tif (strcmp(dev_name, name) == 0) {\n-\t\t\tVDEV_LOG(INFO, \"devargs matched %s\", dev_name);\n-\t\t\treturn devargs;\n-\t\t}\n-\t}\n-\treturn NULL;\n-}\n-\n static int\n insert_vdev(const char *name, const char *args,\n \t\tstruct rte_vdev_device **p_dev,\n@@ -291,10 +275,7 @@ insert_vdev(const char *name, const char *args,\n \tif (name == NULL)\n \t\treturn -EINVAL;\n \n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n-\t\tdevargs = alloc_devargs(name, args);\n-\telse\n-\t\tdevargs = vdev_devargs_lookup(name);\n+\tdevargs = alloc_devargs(name, args);\n \n \tif (!devargs)\n \t\treturn -ENOMEM;\n", "prefixes": [ "1/3" ] }