Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138370/?format=api
{ "id": 138370, "url": "http://patches.dpdk.org/api/patches/138370/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240314091708.1542769-6-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240314091708.1542769-6-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240314091708.1542769-6-david.marchand@redhat.com", "date": "2024-03-14T09:17:06", "name": "[v2,5/6] app/testpmd: remove dead code for disabling cmdline library", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5be8e9f49467d8d1f4c22ceb117b4474d329d463", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240314091708.1542769-6-david.marchand@redhat.com/mbox/", "series": [ { "id": 31506, "url": "http://patches.dpdk.org/api/series/31506/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31506", "date": "2024-03-14T09:17:01", "name": "testpmd options parsing cleanup", "version": 2, "mbox": "http://patches.dpdk.org/series/31506/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138370/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138370/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 53B4343CB2;\n\tThu, 14 Mar 2024 10:17:51 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F0F7542E89;\n\tThu, 14 Mar 2024 10:17:40 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 4F6EE42E7B\n for <dev@dpdk.org>; Thu, 14 Mar 2024 10:17:36 +0100 (CET)", "from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])\n by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-599-TQ_7SpimNlelcC0V7X4giw-1; Thu,\n 14 Mar 2024 05:17:30 -0400", "from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com\n [10.11.54.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2E8EE1C07583;\n Thu, 14 Mar 2024 09:17:30 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.225.27])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 681C33C21;\n Thu, 14 Mar 2024 09:17:29 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1710407855;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=nz5/ICh3Od5It+bfsDClPohIfdKdMDyMCYj1DfOpJvk=;\n b=I9NoCfGZaBwji8rciiizhd4NEtT6rYeIprQL0VdMgqvjlXBp20owC+bIqYlADgU5KL+Hms\n dfScBEsPMHKJaTWJmguoqHG3MsjHmqkCSPrX3WyQdRQoOFSLNT1OktKGUY+TCO56pNzSAc\n Fn/jJbukfuLl6bGEJkI13MvJls+fgbA=", "X-MC-Unique": "TQ_7SpimNlelcC0V7X4giw-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Aman Singh <aman.deep.singh@intel.com>,\n Yuying Zhang <yuying.zhang@intel.com>", "Subject": "[PATCH v2 5/6] app/testpmd: remove dead code for disabling cmdline\n library", "Date": "Thu, 14 Mar 2024 10:17:06 +0100", "Message-ID": "<20240314091708.1542769-6-david.marchand@redhat.com>", "In-Reply-To": "<20240314091708.1542769-1-david.marchand@redhat.com>", "References": "<20240308144841.3615262-1-david.marchand@redhat.com>\n <20240314091708.1542769-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.1", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The cmdline library is always enabled with meson.\nRemove traces of a time when it may have been possible to disable it.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n app/test-pmd/parameters.c | 19 +------------------\n app/test-pmd/testpmd.c | 5 +----\n 2 files changed, 2 insertions(+), 22 deletions(-)", "diff": "diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c\nindex fc5cf3a195..a69639b6fb 100644\n--- a/app/test-pmd/parameters.c\n+++ b/app/test-pmd/parameters.c\n@@ -45,10 +45,8 @@ usage(char* progname)\n {\n \tprintf(\"\\nUsage: %s [EAL options] -- [testpmd options]\\n\\n\",\n \t progname);\n-#ifdef RTE_LIB_CMDLINE\n \tprintf(\" --interactive: run in interactive mode.\\n\");\n \tprintf(\" --cmdline-file: execute cli commands before startup.\\n\");\n-#endif\n \tprintf(\" --auto-start: start forwarding on init \"\n \t \"[always when non-interactive].\\n\");\n \tprintf(\" --help: display this message and quit.\\n\");\n@@ -95,12 +93,10 @@ usage(char* progname)\n \tprintf(\" --max-pkt-len=N: set the maximum size of packet to N bytes.\\n\");\n \tprintf(\" --max-lro-pkt-size=N: set the maximum LRO aggregated packet \"\n \t \"size to N bytes.\\n\");\n-#ifdef RTE_LIB_CMDLINE\n \tprintf(\" --eth-peers-configfile=name: config file with ethernet addresses \"\n \t \"of peer ports.\\n\");\n \tprintf(\" --eth-peer=X,M:M:M:M:M:M: set the MAC address of the X peer \"\n \t \"port (0 <= X < %d).\\n\", RTE_MAX_ETHPORTS);\n-#endif\n \tprintf(\" --disable-crc-strip: disable CRC stripping by hardware.\\n\");\n \tprintf(\" --enable-scatter: enable scattered Rx.\\n\");\n \tprintf(\" --enable-lro: enable large receive offload.\\n\");\n@@ -210,7 +206,6 @@ usage(char* progname)\n \t \" 0x01 - hairpin ports loop, 0x00 - hairpin port self\\n\");\n }\n \n-#ifdef RTE_LIB_CMDLINE\n static int\n init_peer_eth_addrs(const char *config_filename)\n {\n@@ -240,7 +235,6 @@ init_peer_eth_addrs(const char *config_filename)\n \tnb_peer_eth_addrs = (portid_t) i;\n \treturn 0;\n }\n-#endif\n \n /*\n * Parse the coremask given as argument (hexadecimal string) and set\n@@ -610,13 +604,11 @@ launch_args_parse(int argc, char** argv)\n \n \tstatic struct option lgopts[] = {\n \t\t{ \"help\",\t\t\t0, 0, 0 },\n-#ifdef RTE_LIB_CMDLINE\n \t\t{ \"interactive\",\t\t0, 0, 0 },\n \t\t{ \"cmdline-file\",\t\t1, 0, 0 },\n \t\t{ \"auto-start\",\t\t\t0, 0, 0 },\n \t\t{ \"eth-peers-configfile\",\t1, 0, 0 },\n \t\t{ \"eth-peer\",\t\t\t1, 0, 0 },\n-#endif\n \t\t{ \"tx-first\",\t\t\t0, 0, 0 },\n \t\t{ \"stats-period\",\t\t1, 0, 0 },\n \t\t{ \"display-xstats\",\t\t1, 0, 0 },\n@@ -725,20 +717,13 @@ launch_args_parse(int argc, char** argv)\n \n \targvopt = argv;\n \n-#ifdef RTE_LIB_CMDLINE\n-#define SHORTOPTS \"i\"\n-#else\n-#define SHORTOPTS \"\"\n-#endif\n-\twhile ((opt = getopt_long(argc, argvopt, SHORTOPTS \"ah\",\n+\twhile ((opt = getopt_long(argc, argvopt, \"iah\",\n \t\t\t\t lgopts, &opt_idx)) != EOF) {\n \t\tswitch (opt) {\n-#ifdef RTE_LIB_CMDLINE\n \t\tcase 'i':\n \t\t\tprintf(\"Interactive-mode selected\\n\");\n \t\t\tinteractive = 1;\n \t\t\tbreak;\n-#endif\n \t\tcase 'a':\n \t\t\tprintf(\"Auto-start selected\\n\");\n \t\t\tauto_start = 1;\n@@ -749,7 +734,6 @@ launch_args_parse(int argc, char** argv)\n \t\t\t\tusage(argv[0]);\n \t\t\t\texit(EXIT_SUCCESS);\n \t\t\t}\n-#ifdef RTE_LIB_CMDLINE\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"interactive\")) {\n \t\t\t\tprintf(\"Interactive-mode selected\\n\");\n \t\t\t\tinteractive = 1;\n@@ -817,7 +801,6 @@ launch_args_parse(int argc, char** argv)\n \t\t\t\t\t\t port_end);\n \t\t\t\tnb_peer_eth_addrs++;\n \t\t\t}\n-#endif\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"tx-ip\")) {\n \t\t\t\tstruct in_addr in;\n \t\t\t\tchar *end;\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 81d905d759..70ea257fda 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -4700,7 +4700,6 @@ main(int argc, char** argv)\n \tif (record_core_cycles)\n \t\trte_lcore_register_usage_cb(lcore_usage_callback);\n \n-#ifdef RTE_LIB_CMDLINE\n \tif (init_cmdline() != 0)\n \t\trte_exit(EXIT_FAILURE,\n \t\t\t\"Could not initialise cmdline context.\\n\");\n@@ -4714,9 +4713,7 @@ main(int argc, char** argv)\n \t\t\tstart_packet_forwarding(0);\n \t\t}\n \t\tprompt();\n-\t} else\n-#endif\n-\t{\n+\t} else {\n \t\tprintf(\"No commandline core given, start packet forwarding\\n\");\n \t\tstart_packet_forwarding(tx_first);\n \t\tif (stats_period != 0) {\n", "prefixes": [ "v2", "5/6" ] }