Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138344/?format=api
{ "id": 138344, "url": "http://patches.dpdk.org/api/patches/138344/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240314070536.3169210-8-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240314070536.3169210-8-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240314070536.3169210-8-chaoyong.he@corigine.com", "date": "2024-03-14T07:05:35", "name": "[7/8] net/nfp: fix dereference after null check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2ce5644fb4effc46a2159c0732d09883a298e0d1", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240314070536.3169210-8-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 31503, "url": "http://patches.dpdk.org/api/series/31503/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31503", "date": "2024-03-14T07:05:28", "name": "fix some coverity issues", "version": 1, "mbox": "http://patches.dpdk.org/series/31503/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138344/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138344/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 305FC43CAB;\n\tThu, 14 Mar 2024 08:06:57 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BF5AB42E8B;\n\tThu, 14 Mar 2024 08:06:17 +0100 (CET)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2109.outbound.protection.outlook.com [40.107.220.109])\n by mails.dpdk.org (Postfix) with ESMTP id 0EA6E42E7D;\n Thu, 14 Mar 2024 08:06:16 +0100 (CET)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by DS0PR13MB6235.namprd13.prod.outlook.com (2603:10b6:8:115::5) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.21; Thu, 14 Mar\n 2024 07:06:13 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7362.035; Thu, 14 Mar 2024\n 07:06:13 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=b4GZazPerowVU27ahTeh1a/b8lnGvq1u2y3baUvXgNRp3OHFotW6sXg6e1AW/AJsSbeYz/qeqUyBirleh9ebiNzU1Gn3M22Wgco8aKYKa5x5koJ+3Xw6tqih9KG6OJaFN8ullExVSw7ax3md0Gi/3WcMFtXAI3RLLrJMKscYEnqdD4r2RlUqEs+5VbaQK1lSbgM6T2jqeCG3482mP2ZKZMP2NHWK1CBSYfdBDQzDZNidVnamxa3AIuZ9dfMhIIVTyty3EM/npEulTXUPntRpZpqjdjyiWYmSpoLYzi4oI5RUW+D9nXSMXMddEqbt/X76EwSc2PEn2iA/+YJdwq+4Zw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=byfzGYTm0KCnIF14nNyHqdujt6PmveJmOG8kEXXL4OI=;\n b=Lg7QDDCW6Yqood2We7dlapnOzkZXfOIAhIfrJn4QLBudD4TaWpXJvDzl7O7E1jeVXRhS+qjoSooxyw99fgPKOseidN9DjTIm7Z559xsvC9D3AjBjyKefoNv9Z+4F+o8hyo2JJGNQUSLTPTQ6LgfWQ4jV8vyGUqzAvdaFoyALNRkC+ew3Z0159zkHG8EdBcpbQz5c2frIV2t40quqSvoQABq/nqYciYa/edgllYTvc4GGtcEkMVObIbi7P12ygCjNuit70dFO15Bls6oo38n1LRWdINMEOfCvd8/gUBX9/D5CLlklCfPghdbJt2aaKQ/PJEGXtr9ClyoHLOakMD7JQQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=byfzGYTm0KCnIF14nNyHqdujt6PmveJmOG8kEXXL4OI=;\n b=hQ0LZD9lst04kXGM+mUcOiutGJiqzxBCG98ORfu2gXEQ3oug5rXZlwJM7R4vNsG+1fpxt2nDGJqLK3H0OHotP7+B90jOMyDB3AJyWffWq/fT0FrwnEviQcdtrfUy2FJ7GVoJeTz/GX3YLJy0JhUQlL4m68cqFzI07OtmScjhcKc=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Peng Zhang <peng.zhang@corigine.com>,\n stable@dpdk.org, Chaoyong He <chaoyong.he@corigine.com>", "Subject": "[PATCH 7/8] net/nfp: fix dereference after null check", "Date": "Thu, 14 Mar 2024 15:05:35 +0800", "Message-Id": "<20240314070536.3169210-8-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20240314070536.3169210-1-chaoyong.he@corigine.com>", "References": "<20240314070536.3169210-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SG2PR06CA0191.apcprd06.prod.outlook.com (2603:1096:4:1::23)\n To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|DS0PR13MB6235:EE_", "X-MS-Office365-Filtering-Correlation-Id": "40b08fca-952e-48a1-6b61-08dc43f53be9", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n JoMy1H2ocCjHJBUhkBllouyNHpLJSq48KP2OBcEdRSHQ4ie2+/6ja7+Oxj35d3vF/qWTH/YfeU1Wj1uKs62FDNKX+OV8W2G3ceUW5Q+QVpYCb1/zMtjUXqvYdTB8NNB5LGfutMEDc2itG4Cy+04Q4qtMjNf5LKoeS+CMGViAEFSMKyc06a7enBkvTkcyjih01E/4xVyf5cyyAEEtxsyHWZShLSaj2nC/Mwf529r4Z12AUu+Gh1DQX+AF8qpz2d4sQbaniUUm4cbYzXSr1jQewL6yOi8F3etFUaSte5sMX5rck92sDzMol5zGae1b2Pgswh4g/PyBGkrWuQPw/xlqT70aek2ET/MI61I4syNZKhmDMQ7kDbauKtTB4XfSRzdav8Rc8GBLu00iDWTiMCsdzRkhNoqS7PXe4PiRhQwK5o1tS6nKVvT6nlJH5OBMgL3EnXtrGPC4GKCNjN5VwVPuFeXMlqKVVGz5s1ZCGaYFowURCC5rM09+OYOz0hRPUG1UKzfk8AqXmFtf7iCz7xkx7Z7dax9LFbecyvuw6C42AHvO+PI2xuUcex4MaOlMSTDDCQQDw1dOOFYpoewr1hFuQwZrzl+PCmpwE4zRJpXQwBkmOsoCrawXJiEo5NV1d7EKNe9sADTD7O2w9bXrE9AYQSzhnid7OON3CbC5ozxeINLLXWY0TT47cErWgs2eJvZLxHQQuOxRgMbkaBFaTUBI+DrQI8qUT1hVcW8sUHsDcmI=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(376005)(52116005)(1800799015)(38350700005); DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n dkSLKMTJX8C/ZbQgX/3RZwH5ZuiFLNCW06E4/fk1Ik4Crtl575iIzwR8z3MQWj7gEqPh3iUxJ79+Y5HmLpdTwuysVczZfv2OmdnXJhUJvT87LSqy0p8pbxIEE0OOyYyzxcls7NmcncU86G6J+wjuaYFgNdZWvKmmVyrijmg0dMD7b2hjQBA/gXzijL7TMTfgVdoPaOvR5uX3k3Ols/5eeLkmgNXeRJG94ddhB7tWIxTAxEFfXqrN4gvngiPez7GkfgncvXQNUYuHGRfJF/a2NlUH8KtwCLoOS8SZVCHKzcaQYKFeqO7y7zv1EZJPyXSgGYHyU+7c4iECbBr2FhALW3YMOU0ywgoCVjmLMJm9LIFbfPDfvBfb3XMcpkj1Oqr+El5rC1VmmjgBq59GMNsdw5JSWfTBYeK77lRIQ42KfBTAr0tQ29pFudAV9MtIn/zYeh5CqILUrCbDpnPl6AueSphOObGyVX+zp/f5k2VuX1IFfGiABM8CXxsuHMmVvKIf+NKr2P4SpgbeaVRHMQHoC1D6LU9horwysUURZr70BatkGQZxXoTCVMoEjLbKg3OoFYMpI+qn7jFLN6y598lRZlMi06IumzPsI+yL6BLvu9DCX9sNKhPR2alyLODSfh4SggFprLHvFFJEPVV/4VdTomnFQecogCb9Cj3AT3DdxaumDH2H1Q6pujYaEVpBBTcJzO1dSAuDAmhk8ys8Q42g46HqOS2PUolshcuYBo/vJtMuCOPZbQ6CnTfz6IIH4ofes0KnF0mabGksrxQVyufzHJuQUe5yLnBFZAspq19g/MVlAVoMFLiXNTsn/TjH1NTOmC5xd2EQ92ou+7OBYKRf9RqUcOZhwBgrq55n2TIBeEh/nZ+EcO6sEZ66cZxwB0soxsT9JMXvU/opA0R3rin0+evPY+lofGMFMqr6P0CeKV938ETV7ekn8S7bX8n6DplXTSjsezBeruXdBfcAGfzXBZPbUeIvxRr3Vk6EpbwPquaLv6YLdUHZtjhVo+3gVwoGOlQktm1XYJO12/y9PfYMOfEb8424HI4vgdKkBGo1jrXcRZTFnzAf+tbLuqub2UZcJvHRBvzPf3Ss5YiyN1d1luHc07u3gatmlxK2X3TLwzlb4KuV1pMDuJ2JsbLKDu6vQQIVwoxZzVtfPpGB9Ij7mFfU1P8XBpgj2HXo6Iiol5FvZ+R2x/hYfjK8fqFRWZevEKVOSIMGfTljP3Yss1EgSVbV887mAXRWH6xF+zAdJiCag9PmQNXUxfntwMdzu2U09MbHMNyEyROtGGIEM5xsB7ySoyq/OlaMPqX2iqaEmXa5jR8Y8BYJcJSIngpmX7IJMVOxyzfdvuCdZJoHMz8vvMwtjIMAVXNloDu1a5KKKEsr0E3z8ox3syYqt6A3xQRX5Zohv3GNClgDjaAs/WKUdw87AGvU7sT7GEUSKc4lnGimkqYP/l57DIKRVFqohEUBQdoqlq7ArvWjfnhA863gxmTwb64m6EPVqAJhb8z995+1rhzG8gw3zAnrO8//Kz7p5JDC6/2yhyxlPB8QG6uQb/8fLpg5KWy28kNOyKUwyjcghL0huLov7yvrqdF2VXTD8h6Z4SXLReeSg63ET1S+1g==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 40b08fca-952e-48a1-6b61-08dc43f53be9", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Mar 2024 07:06:13.3880 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n /jPqvU+LJVWg2Yyhcxt7dZDR3+zJv2lIuWUhJ/hQCCA6YqYkgMeTS7XrLJGFOo6M3nRirK927CbmRSWZWJoOpsQwGyeEClsWEjjSJT6DMnU=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DS0PR13MB6235", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Peng Zhang <peng.zhang@corigine.com>\n\nCI found in the logic of 'nfp_elf_read_first_symtab()' has\ndereference after null check problem.\n\nCoverity issue: 415042\nFixes: c82ca09c441c (\"net/nfp: add ELF module\")\nCc: stable@dpdk.org\n\nSigned-off-by: Peng Zhang <peng.zhang@corigine.com>\nReviewed-by: Chaoyong He <chaoyong.he@corigine.com>\n---\n drivers/net/nfp/nfpcore/nfp_elf.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/nfp/nfpcore/nfp_elf.c b/drivers/net/nfp/nfpcore/nfp_elf.c\nindex fbd350589b..268cdb1aff 100644\n--- a/drivers/net/nfp/nfpcore/nfp_elf.c\n+++ b/drivers/net/nfp/nfpcore/nfp_elf.c\n@@ -900,7 +900,8 @@ nfp_elf_read_first_symtab(struct nfp_elf *ectx)\n \tuint64_t sh_size;\n \tstruct nfp_elf_elf64_shdr *sec;\n \n-\tfor (idx = 0, sec = ectx->shdrs; idx < ectx->shdrs_cnt; idx++, sec++) {\n+\tfor (idx = 0; idx < ectx->shdrs_cnt; idx++) {\n+\t\tsec = &ectx->shdrs[idx];\n \t\tif (sec != NULL) {\n \t\t\tsh_type = rte_le_to_cpu_32(sec->sh_type);\n \t\t\tif (sh_type == NFP_ELF_SHT_SYMTAB)\n@@ -908,6 +909,9 @@ nfp_elf_read_first_symtab(struct nfp_elf *ectx)\n \t\t}\n \t}\n \n+\tif (sec == NULL)\n+\t\treturn -EINVAL;\n+\n \tsh_size = rte_le_to_cpu_64(sec->sh_size);\n \n \tif (idx < ectx->shdrs_cnt && sh_type == NFP_ELF_SHT_SYMTAB) {\n", "prefixes": [ "7/8" ] }