Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 138313,
    "url": "http://patches.dpdk.org/api/patches/138313/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240313105901.1959675-7-asasidharan@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20240313105901.1959675-7-asasidharan@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20240313105901.1959675-7-asasidharan@marvell.com",
    "date": "2024-03-13T10:58:46",
    "name": "[v5,06/21] test/security: unit test for custom content verification",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "8619c2c6fac3c8cd12aa0c4d06dd0045fb8134ac",
    "submitter": {
        "id": 2800,
        "url": "http://patches.dpdk.org/api/people/2800/?format=api",
        "name": "Aakash Sasidharan",
        "email": "asasidharan@marvell.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240313105901.1959675-7-asasidharan@marvell.com/mbox/",
    "series": [
        {
            "id": 31494,
            "url": "http://patches.dpdk.org/api/series/31494/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31494",
            "date": "2024-03-13T10:58:40",
            "name": "Improvements and new test cases",
            "version": 5,
            "mbox": "http://patches.dpdk.org/series/31494/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/138313/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/138313/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3C9EE43C9E;\n\tWed, 13 Mar 2024 11:59:50 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 75BD342DF7;\n\tWed, 13 Mar 2024 11:59:27 +0100 (CET)",
            "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id EA43642DEF\n for <dev@dpdk.org>; Wed, 13 Mar 2024 11:59:23 +0100 (CET)",
            "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id\n 42D9Wo95022137; Wed, 13 Mar 2024 03:59:23 -0700",
            "from dc5-exch05.marvell.com ([199.233.59.128])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3wu9kvr7wa-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Wed, 13 Mar 2024 03:59:22 -0700 (PDT)",
            "from DC5-EXCH05.marvell.com (10.69.176.209) by\n DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.12; Wed, 13 Mar 2024 03:59:22 -0700",
            "from maili.marvell.com (10.69.176.80) by DC5-EXCH05.marvell.com\n (10.69.176.209) with Microsoft SMTP Server id 15.2.1258.12 via Frontend\n Transport; Wed, 13 Mar 2024 03:59:22 -0700",
            "from localhost.localdomain (unknown [10.28.36.177])\n by maili.marvell.com (Postfix) with ESMTP id DD3E13F7080;\n Wed, 13 Mar 2024 03:59:19 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=\n pfpt0220; bh=9d9zwoNT2ig+qwHFIWK1JiFApmVgayJzjxddzIRjfvw=; b=f+K\n I4sPEUP71JGQXnEZ4E+Je4mcgsTqplsDD0nvTJX09AIlIrxp6w5oiygbtFgCLsNX\n EfUwWxN7e32t8Z2EEIJy9QDs3e9F8MiZIw6T3Bn5xwurfKQFeGHeHeq1bJRvkV2f\n +Yi1eFJ+cBzuGYdYTDl7m3QLj9tdrJ4HV8GFzZLlGT79v3qecVRWbha82yJGEDGF\n CDz8/LUDEYpzTESj5+idSRkSCndoY+ImORfTBvc84ItKcIDCXyyyAAkfKL4zGr6q\n SgLBBnVwa95ol6ihERWIJ5V+57BcpjBTTOCWdXIndJEjyvVMZenXfkMphFnwNBt1\n rVQS5HaTn51NReR6vSg==",
        "From": "Aakash Sasidharan <asasidharan@marvell.com>",
        "To": "Akhil Goyal <gakhil@marvell.com>, Fan Zhang <fanzhang.oss@gmail.com>",
        "CC": "<jerinj@marvell.com>, <anoobj@marvell.com>, <vvelumuri@marvell.com>,\n <asasidharan@marvell.com>, <dev@dpdk.org>",
        "Subject": "[PATCH v5 06/21] test/security: unit test for custom content\n verification",
        "Date": "Wed, 13 Mar 2024 16:28:46 +0530",
        "Message-ID": "<20240313105901.1959675-7-asasidharan@marvell.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20240313105901.1959675-1-asasidharan@marvell.com>",
        "References": "<20240313055030.1685039-1-asasidharan@marvell.com>\n <20240313105901.1959675-1-asasidharan@marvell.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-GUID": "woADsrKFhS_tTpgf3mOlat-XWMarlU6-",
        "X-Proofpoint-ORIG-GUID": "woADsrKFhS_tTpgf3mOlat-XWMarlU6-",
        "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2024-03-13_07,2024-03-12_01,2023-05-22_02",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Vidya Sagar Velumuri <vvelumuri@marvell.com>\n\nAdd unit test to verify the TLS header creation with\ncustom content type\n\nSigned-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>\n---\n app/test/test_cryptodev.c                     | 19 +++++++++++++++++++\n app/test/test_cryptodev_security_tls_record.c |  3 +++\n app/test/test_cryptodev_security_tls_record.h |  9 +++++++++\n 3 files changed, 31 insertions(+)",
    "diff": "diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c\nindex 324ef3c276..5cb878b9ba 100644\n--- a/app/test/test_cryptodev.c\n+++ b/app/test/test_cryptodev.c\n@@ -21,6 +21,7 @@\n #include <rte_ip.h>\n #include <rte_string_fns.h>\n #include <rte_tcp.h>\n+#include <rte_tls.h>\n #include <rte_udp.h>\n \n #ifdef RTE_CRYPTO_SCHEDULER\n@@ -12108,6 +12109,20 @@ test_tls_record_proto_corrupt_pkt(void)\n \treturn test_tls_record_proto_all(&flags);\n }\n \n+static int\n+test_tls_record_proto_custom_content_type(void)\n+{\n+\tstruct tls_record_test_flags flags = {\n+\t\t.content_type = TLS_RECORD_TEST_CONTENT_TYPE_CUSTOM\n+\t};\n+\tstruct crypto_testsuite_params *ts_params = &testsuite_params;\n+\tstruct rte_cryptodev_info dev_info;\n+\n+\trte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);\n+\n+\treturn test_tls_record_proto_all(&flags);\n+}\n+\n static int\n test_dtls_1_2_record_proto_data_walkthrough(void)\n {\n@@ -17232,6 +17247,10 @@ static struct unit_test_suite tls12_record_proto_testsuite  = {\n \t\t\t\"TLS packet header corruption\",\n \t\t\tut_setup_security, ut_teardown,\n \t\t\ttest_tls_record_proto_corrupt_pkt),\n+\t\tTEST_CASE_NAMED_ST(\n+\t\t\t\"Custom content type\",\n+\t\t\tut_setup_security, ut_teardown,\n+\t\t\ttest_tls_record_proto_custom_content_type),\n \t\tTEST_CASES_END() /**< NULL terminate unit test array */\n \t}\n };\ndiff --git a/app/test/test_cryptodev_security_tls_record.c b/app/test/test_cryptodev_security_tls_record.c\nindex 93ff7f36fa..9a2af259c9 100644\n--- a/app/test/test_cryptodev_security_tls_record.c\n+++ b/app/test/test_cryptodev_security_tls_record.c\n@@ -108,6 +108,9 @@ test_tls_record_td_prepare(const struct crypto_param *param1, const struct crypt\n \t\ttd->input_text.len = data_len;\n \t}\n \n+\tif (flags->content_type == TLS_RECORD_TEST_CONTENT_TYPE_CUSTOM)\n+\t\ttd->app_type = RTE_TLS_TYPE_MAX;\n+\n \ttls_pkt_size = td->input_text.len;\n \n \tif (!td->aead) {\ndiff --git a/app/test/test_cryptodev_security_tls_record.h b/app/test/test_cryptodev_security_tls_record.h\nindex a7c0ca87bf..73719063a8 100644\n--- a/app/test/test_cryptodev_security_tls_record.h\n+++ b/app/test/test_cryptodev_security_tls_record.h\n@@ -42,6 +42,14 @@ static_assert(TLS_1_3_RECORD_PLAINTEXT_MAX_LEN <= TEST_SEC_CLEARTEXT_MAX_LEN,\n \n #define TLS_RECORD_PLAINTEXT_MIN_LEN       (1u)\n \n+enum tls_record_test_content_type {\n+\tTLS_RECORD_TEST_CONTENT_TYPE_APP,\n+\t/* For verifying zero packet length */\n+\tTLS_RECORD_TEST_CONTENT_TYPE_HANDSHAKE,\n+\t/* For verifying handling of custom content types */\n+\tTLS_RECORD_TEST_CONTENT_TYPE_CUSTOM,\n+};\n+\n struct tls_record_test_data {\n \tstruct {\n \t\tuint8_t data[32];\n@@ -89,6 +97,7 @@ struct tls_record_test_flags {\n \tbool data_walkthrough;\n \tenum rte_security_tls_version tls_version;\n \tbool pkt_corruption;\n+\tenum tls_record_test_content_type content_type;\n };\n \n extern struct tls_record_test_data tls_test_data_aes_128_gcm_v1;\n",
    "prefixes": [
        "v5",
        "06/21"
    ]
}