Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138284/?format=api
{ "id": 138284, "url": "http://patches.dpdk.org/api/patches/138284/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240313055030.1685039-2-asasidharan@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240313055030.1685039-2-asasidharan@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240313055030.1685039-2-asasidharan@marvell.com", "date": "2024-03-13T05:50:10", "name": "[v4,01/21] test/security: enable AES-GCM in combined mode TLS", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "580eb31d577d77064e519a44361e62ab3e017c4c", "submitter": { "id": 2800, "url": "http://patches.dpdk.org/api/people/2800/?format=api", "name": "Aakash Sasidharan", "email": "asasidharan@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240313055030.1685039-2-asasidharan@marvell.com/mbox/", "series": [ { "id": 31490, "url": "http://patches.dpdk.org/api/series/31490/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31490", "date": "2024-03-13T05:50:09", "name": "Improvements and new test cases", "version": 4, "mbox": "http://patches.dpdk.org/series/31490/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138284/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138284/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7975343C9A;\n\tWed, 13 Mar 2024 06:50:45 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 828A940E01;\n\tWed, 13 Mar 2024 06:50:42 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 3E39F402E0\n for <dev@dpdk.org>; Wed, 13 Mar 2024 06:50:39 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id\n 42D40615015029; Tue, 12 Mar 2024 22:50:38 -0700", "from dc6wp-exch02.marvell.com ([4.21.29.225])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3wtt8htkqp-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 12 Mar 2024 22:50:38 -0700 (PDT)", "from DC6WP-EXCH02.marvell.com (10.76.176.209) by\n DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.12; Tue, 12 Mar 2024 22:50:36 -0700", "from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com\n (10.76.176.209) with Microsoft SMTP Server id 15.2.1258.12 via Frontend\n Transport; Tue, 12 Mar 2024 22:50:36 -0700", "from localhost.localdomain (unknown [10.28.36.177])\n by maili.marvell.com (Postfix) with ESMTP id 6DAE53F7082;\n Tue, 12 Mar 2024 22:50:34 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=\n pfpt0220; bh=QUZcyTj5XidC+pbqc55KVF8529MavEbdwy3kwFi1fM8=; b=duR\n 464pwtVzrcr6F09B4UUoMu+nBuwCJyUDGgFbxDuCFinqDfOvfGhegbUgjW3+EiB3\n g0O5tU+70ps5hm/DD3eCpykWc0KGcbx9cnmhERnBx5fL93SiY9edCsfeM8OX7B1F\n gy76QNGso/RPk1adCu/FFBa+vX0MkTFONH+I092uOMaAJhaqqXkHc90LPOyAa1J/\n MsQtK7FS3dsnv5Zfhf8mJIHzexFRnH4XbMgooCeet/tcHF9y78TpqKwrDd7GDfB6\n nqCawY1nHhu59+0Awh6t/iB+3MmqSNAOW4pesXFbKLCPMXKNEawBqGOET/iaV0A1\n gl3IAKneOhtABaKyDwQ==", "From": "Aakash Sasidharan <asasidharan@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>, Fan Zhang <fanzhang.oss@gmail.com>,\n Anoob Joseph <anoobj@marvell.com>, Vidya Sagar Velumuri\n <vvelumuri@marvell.com>", "CC": "<jerinj@marvell.com>, <asasidharan@marvell.com>, <dev@dpdk.org>", "Subject": "[PATCH v4 01/21] test/security: enable AES-GCM in combined mode TLS", "Date": "Wed, 13 Mar 2024 11:20:10 +0530", "Message-ID": "<20240313055030.1685039-2-asasidharan@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240313055030.1685039-1-asasidharan@marvell.com>", "References": "<20240312175143.1664699-1-asasidharan@marvell.com>\n <20240313055030.1685039-1-asasidharan@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "0cy8RW-cYAoj8wPNIW7YqaZFETVpEht6", "X-Proofpoint-GUID": "0cy8RW-cYAoj8wPNIW7YqaZFETVpEht6", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2024-03-13_05,2024-03-12_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Enable AES-GCM AEAD tests in combined mode TLS test suite.\n\nCoverity issue: 414888\nFixes: 9157ccb8f876 (\"test/crypto: verify TLS headers\")\n\nSigned-off-by: Aakash Sasidharan <asasidharan@marvell.com>\n---\n app/test/test_cryptodev_security_tls_record.c | 10 ++++++++--\n app/test/test_security_proto.h | 3 +++\n 2 files changed, 11 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test/test_cryptodev_security_tls_record.c b/app/test/test_cryptodev_security_tls_record.c\nindex bcb2eba4ff..14a7a2511e 100644\n--- a/app/test/test_cryptodev_security_tls_record.c\n+++ b/app/test/test_cryptodev_security_tls_record.c\n@@ -116,6 +116,7 @@ test_tls_record_td_prepare(const struct crypto_param *param1, const struct crypt\n \t\t}\n \t} else {\n \t\tmac_len = td->xform.aead.aead.digest_length;\n+\t\troundup_len = 0;\n \t\texp_nonce_len = 8;\n \t}\n \n@@ -123,7 +124,10 @@ test_tls_record_td_prepare(const struct crypto_param *param1, const struct crypt\n \tcase RTE_SECURITY_VERSION_TLS_1_2:\n \tcase RTE_SECURITY_VERSION_TLS_1_3:\n \t\thdr_len = sizeof(struct rte_tls_hdr);\n-\t\tmin_padding = 1;\n+\t\tif (td->aead)\n+\t\t\tmin_padding = 0;\n+\t\telse\n+\t\t\tmin_padding = 1;\n \t\tbreak;\n \tcase RTE_SECURITY_VERSION_DTLS_1_2:\n \t\thdr_len = sizeof(struct rte_dtls_hdr);\n@@ -139,7 +143,9 @@ test_tls_record_td_prepare(const struct crypto_param *param1, const struct crypt\n \n \t/* Padding */\n \ttls_pkt_size += min_padding;\n-\ttls_pkt_size = RTE_ALIGN_MUL_CEIL(tls_pkt_size, roundup_len);\n+\n+\tif (roundup_len)\n+\t\ttls_pkt_size = RTE_ALIGN_MUL_CEIL(tls_pkt_size, roundup_len);\n \n \t/* Explicit nonce */\n \ttls_pkt_size += exp_nonce_len;\ndiff --git a/app/test/test_security_proto.h b/app/test/test_security_proto.h\nindex efa023b99d..5b92daa810 100644\n--- a/app/test/test_security_proto.h\n+++ b/app/test/test_security_proto.h\n@@ -27,16 +27,19 @@ static const struct crypto_param aead_list[] = {\n \t\t.type = RTE_CRYPTO_SYM_XFORM_AEAD,\n \t\t.alg.aead = RTE_CRYPTO_AEAD_AES_GCM,\n \t\t.key_length = 16,\n+\t\t.digest_length = 16,\n \t},\n \t{\n \t\t.type = RTE_CRYPTO_SYM_XFORM_AEAD,\n \t\t.alg.aead = RTE_CRYPTO_AEAD_AES_GCM,\n \t\t.key_length = 24,\n+\t\t.digest_length = 16,\n \t},\n \t{\n \t\t.type = RTE_CRYPTO_SYM_XFORM_AEAD,\n \t\t.alg.aead = RTE_CRYPTO_AEAD_AES_GCM,\n \t\t.key_length = 32,\n+\t\t.digest_length = 16,\n \t},\n \t{\n \t\t.type = RTE_CRYPTO_SYM_XFORM_AEAD,\n", "prefixes": [ "v4", "01/21" ] }