Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138251/?format=api
{ "id": 138251, "url": "http://patches.dpdk.org/api/patches/138251/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240312180716.8515-2-shaibran@amazon.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240312180716.8515-2-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240312180716.8515-2-shaibran@amazon.com", "date": "2024-03-12T18:06:46", "name": "[v4,01/31] net/ena: rework the metrics multi-process functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fd0ca011263f96abf48afff072bfe901bb229f1f", "submitter": { "id": 2930, "url": "http://patches.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240312180716.8515-2-shaibran@amazon.com/mbox/", "series": [ { "id": 31487, "url": "http://patches.dpdk.org/api/series/31487/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31487", "date": "2024-03-12T18:06:45", "name": "net/ena: v2.9.0 driver release", "version": 4, "mbox": "http://patches.dpdk.org/series/31487/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138251/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138251/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A53DF43C94;\n\tTue, 12 Mar 2024 19:07:34 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 58A2A42DD2;\n\tTue, 12 Mar 2024 19:07:32 +0100 (CET)", "from smtp-fw-80007.amazon.com (smtp-fw-80007.amazon.com\n [99.78.197.218]) by mails.dpdk.org (Postfix) with ESMTP id 73E3242DDF\n for <dev@dpdk.org>; Tue, 12 Mar 2024 19:07:30 +0100 (CET)", "from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO\n smtpout.prod.us-east-1.prod.farcaster.email.amazon.dev) ([10.25.36.210])\n by smtp-border-fw-80007.pdx80.corp.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2024 18:07:28 +0000", "from EX19MTAEUB001.ant.amazon.com [10.0.10.100:47873]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.0.5:2525] with\n esmtp (Farcaster)\n id fadf1d8f-aa24-4ee6-90af-ec5abe23f09a;\n Tue, 12 Mar 2024 18:07:26 +0000 (UTC)", "from EX19D007EUB002.ant.amazon.com (10.252.51.117) by\n EX19MTAEUB001.ant.amazon.com (10.252.51.28) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Tue, 12 Mar 2024 18:07:26 +0000", "from EX19MTAUWA001.ant.amazon.com (10.250.64.204) by\n EX19D007EUB002.ant.amazon.com (10.252.51.117) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Tue, 12 Mar 2024 18:07:25 +0000", "from HFA15-CG15235BS.amazon.com (10.85.143.174) by\n mail-relay.amazon.com (10.250.64.204) with Microsoft SMTP Server id\n 15.2.1258.28 via Frontend Transport; Tue, 12 Mar 2024 18:07:23 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1710266851; x=1741802851;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=SOx7LsS6G0ty/ZpiCj/kAL1TgAnWPKqvmUmP5IMtYfk=;\n b=WjpqCpJrNp7BBFuvH87yTrpDkAnxZFtMugJvxPNMo90f1dAIA97f6bie\n uK6iGAErFcXhO0jY1P25GeNibnPklu7st6Pur+hiOAsSqiG9vHKY2VmOe\n YVt+RzqgzVi15N+Oz6Qz9MszAxixNMqjbgItDPs+n0BoGdscn2JPz8bVM c=;", "X-IronPort-AV": "E=Sophos;i=\"6.07,119,1708387200\"; d=\"scan'208\";a=\"280481460\"", "X-Farcaster-Flow-ID": "fadf1d8f-aa24-4ee6-90af-ec5abe23f09a", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>", "Subject": "[PATCH v4 01/31] net/ena: rework the metrics multi-process functions", "Date": "Tue, 12 Mar 2024 20:06:46 +0200", "Message-ID": "<20240312180716.8515-2-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240312180716.8515-1-shaibran@amazon.com>", "References": "<20240312180716.8515-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\n1. Changed the rte_memcpy call to use the precomputed buf_size.\n2. Removed redundant address operators (ampersand symbol)\n when providing memcpy source address parameter.\n3. Code style related change.\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\n drivers/net/ena/ena_ethdev.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex beb17c4125..6d500bfa78 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -531,8 +531,8 @@ __extension__ ({\n __extension__ ({\n \tENA_TOUCH(rsp);\n \tENA_TOUCH(ena_dev);\n-\tif (stats != (struct ena_admin_eni_stats *)&adapter->metrics_stats)\n-\t\trte_memcpy(stats, &adapter->metrics_stats, sizeof(*stats));\n+\tif (stats != (struct ena_admin_eni_stats *)adapter->metrics_stats)\n+\t\trte_memcpy(stats, adapter->metrics_stats, sizeof(*stats));\n }),\n \tstruct ena_com_dev *ena_dev, struct ena_admin_eni_stats *stats);\n \n@@ -590,9 +590,8 @@ __extension__ ({\n __extension__ ({\n \tENA_TOUCH(rsp);\n \tENA_TOUCH(ena_dev);\n-\tENA_TOUCH(buf_size);\n-\tif (buf != (char *)&adapter->metrics_stats)\n-\t\trte_memcpy(buf, &adapter->metrics_stats, adapter->metrics_num * sizeof(uint64_t));\n+\tif (buf != (char *)adapter->metrics_stats)\n+\t\trte_memcpy(buf, adapter->metrics_stats, buf_size);\n }),\n \tstruct ena_com_dev *ena_dev, char *buf, size_t buf_size);\n \n@@ -4088,7 +4087,7 @@ ena_mp_primary_handle(const struct rte_mp_msg *mp_msg, const void *peer)\n \tcase ENA_MP_CUSTOMER_METRICS_GET:\n \t\tres = ena_com_get_customer_metrics(ena_dev,\n \t\t\t\t(char *)adapter->metrics_stats,\n-\t\t\t\tsizeof(uint64_t) * adapter->metrics_num);\n+\t\t\t\tadapter->metrics_num * sizeof(uint64_t));\n \t\tbreak;\n \tcase ENA_MP_SRD_STATS_GET:\n \t\tres = ena_com_get_ena_srd_info(ena_dev,\n", "prefixes": [ "v4", "01/31" ] }