Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138249/?format=api
{ "id": 138249, "url": "http://patches.dpdk.org/api/patches/138249/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240312175143.1664699-22-asasidharan@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240312175143.1664699-22-asasidharan@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240312175143.1664699-22-asasidharan@marvell.com", "date": "2024-03-12T17:51:43", "name": "[v3,21/21] test/security: add out of place sgl test case for TLS 1.2", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5dbc1fad0e3401a985f70bb7090465f280b79ba6", "submitter": { "id": 2800, "url": "http://patches.dpdk.org/api/people/2800/?format=api", "name": "Aakash Sasidharan", "email": "asasidharan@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240312175143.1664699-22-asasidharan@marvell.com/mbox/", "series": [ { "id": 31485, "url": "http://patches.dpdk.org/api/series/31485/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31485", "date": "2024-03-12T17:51:22", "name": "Improvements and new test cases", "version": 3, "mbox": "http://patches.dpdk.org/series/31485/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138249/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/138249/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F28AD43C94;\n\tTue, 12 Mar 2024 18:54:09 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BC08A42E03;\n\tTue, 12 Mar 2024 18:52:52 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id BFE9242E34\n for <dev@dpdk.org>; Tue, 12 Mar 2024 18:52:49 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id\n 42CG4QDQ015018; Tue, 12 Mar 2024 10:52:49 -0700", "from dc6wp-exch02.marvell.com ([4.21.29.225])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3wtt8hrg2g-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 12 Mar 2024 10:52:48 -0700 (PDT)", "from DC6WP-EXCH02.marvell.com (10.76.176.209) by\n DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.12; Tue, 12 Mar 2024 10:52:47 -0700", "from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com\n (10.76.176.209) with Microsoft SMTP Server id 15.2.1258.12 via Frontend\n Transport; Tue, 12 Mar 2024 10:52:47 -0700", "from localhost.localdomain (unknown [10.28.36.177])\n by maili.marvell.com (Postfix) with ESMTP id 284A33F70A1;\n Tue, 12 Mar 2024 10:52:44 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=\n pfpt0220; bh=vYObzcUTdgIrvFCUjOgMNXhJy0tLgvgFCjSB6OM6f2I=; b=XmR\n y729eByXWh2qO8BrBHtdQg8JWaOXGEHz5zV1Czs1KECm8bRL7yySlcCWzOOWHII0\n AowueXYAiSLnqJE6qUnGpHMT3kAovzOsFWt/vakOFmZZEWYA7Iax+qxNT3d69O0K\n FuhcVjp4W6DZoiZFPWPYRNodOYS2k2oFORZdyMdiQsASPAsvwFKQ0+XQhKsvtdZv\n r4YZ32j/PHrPKMEq6sN4efv+uVgM/FvI/ZH03Tq3RPLLarVfUxGPYUv8enEWz8Lc\n WiWL8GDUPAjc91Rg/Oi8LLAgsVfdpOYlkGNhtFcCWeQ1Hscn+V75jnXg4SjNxQV3\n 3DKpghyhZ36AlcDTD9g==", "From": "Aakash Sasidharan <asasidharan@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>, Fan Zhang <fanzhang.oss@gmail.com>", "CC": "<jerinj@marvell.com>, <anoobj@marvell.com>, <vvelumuri@marvell.com>,\n <asasidharan@marvell.com>, <dev@dpdk.org>", "Subject": "[PATCH v3 21/21] test/security: add out of place sgl test case for\n TLS 1.2", "Date": "Tue, 12 Mar 2024 23:21:43 +0530", "Message-ID": "<20240312175143.1664699-22-asasidharan@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240312175143.1664699-1-asasidharan@marvell.com>", "References": "<20240312071805.1354530-1-asasidharan@marvell.com>\n <20240312175143.1664699-1-asasidharan@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "YpCojPV-r4DHuo6KIXWRhbsOHo2zoQhe", "X-Proofpoint-GUID": "YpCojPV-r4DHuo6KIXWRhbsOHo2zoQhe", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2024-03-12_11,2024-03-12_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add TLS 1.2 out-of-place multi-segmented packet test.\n\nSigned-off-by: Aakash Sasidharan <asasidharan@marvell.com>\n---\n app/test/test_cryptodev.c | 52 ++++++++++++++++++-\n app/test/test_cryptodev_security_tls_record.h | 1 +\n 2 files changed, 51 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c\nindex 572740cbf9..1703ebccf1 100644\n--- a/app/test/test_cryptodev.c\n+++ b/app/test/test_cryptodev.c\n@@ -11873,6 +11873,11 @@ test_tls_record_proto_process(const struct tls_record_test_data td[],\n \t\tut_params->ibuf = create_segmented_mbuf(ts_params->mbuf_pool, td[i].input_text.len,\n \t\t\t\tnb_segs, 0);\n \t\tpktmbuf_write(ut_params->ibuf, 0, td[i].input_text.len, td[i].input_text.data);\n+\t\tif (flags->out_of_place)\n+\t\t\tut_params->obuf = create_segmented_mbuf(ts_params->mbuf_pool,\n+\t\t\t\t\ttd[i].output_text.len, nb_segs, 0);\n+\t\telse\n+\t\t\tut_params->obuf = NULL;\n \n \t\t/* Generate crypto op data structure */\n \t\tut_params->op = rte_crypto_op_alloc(ts_params->op_mpool,\n@@ -11888,7 +11893,7 @@ test_tls_record_proto_process(const struct tls_record_test_data td[],\n \n \t\t/* Set crypto operation mbufs */\n \t\tut_params->op->sym->m_src = ut_params->ibuf;\n-\t\tut_params->op->sym->m_dst = NULL;\n+\t\tut_params->op->sym->m_dst = ut_params->obuf;\n \t\tut_params->op->param1.tls_record.content_type = td[i].app_type;\n \n \t\tif (flags->opt_padding)\n@@ -11920,7 +11925,10 @@ test_tls_record_proto_process(const struct tls_record_test_data td[],\n \t\t\tres_d_tmp = &res_d[i];\n \n \t\tif (ut_params->op->status == RTE_CRYPTO_OP_STATUS_SUCCESS) {\n-\t\t\tret = test_tls_record_post_process(ut_params->ibuf, &td[i], res_d_tmp,\n+\t\t\tstruct rte_mbuf *buf = flags->out_of_place ? ut_params->obuf :\n+\t\t\t\t\t\tut_params->ibuf;\n+\n+\t\t\tret = test_tls_record_post_process(buf, &td[i], res_d_tmp,\n \t\t\t\t\t\t\t silent, flags);\n \t\t\tif (ret != TEST_SUCCESS)\n \t\t\t\tgoto crypto_op_free;\n@@ -11929,6 +11937,11 @@ test_tls_record_proto_process(const struct tls_record_test_data td[],\n \t\trte_crypto_op_free(ut_params->op);\n \t\tut_params->op = NULL;\n \n+\t\tif (flags->out_of_place) {\n+\t\t\trte_pktmbuf_free(ut_params->obuf);\n+\t\t\tut_params->obuf = NULL;\n+\t\t}\n+\n \t\trte_pktmbuf_free(ut_params->ibuf);\n \t\tut_params->ibuf = NULL;\n \t}\n@@ -11937,6 +11950,11 @@ test_tls_record_proto_process(const struct tls_record_test_data td[],\n \trte_crypto_op_free(ut_params->op);\n \tut_params->op = NULL;\n \n+\tif (flags->out_of_place) {\n+\t\trte_pktmbuf_free(ut_params->obuf);\n+\t\tut_params->obuf = NULL;\n+\t}\n+\n \trte_pktmbuf_free(ut_params->ibuf);\n \tut_params->ibuf = NULL;\n \n@@ -12127,6 +12145,32 @@ test_tls_record_proto_sgl_data_walkthrough(enum rte_security_tls_version tls_ver\n \treturn test_tls_record_proto_all(&flags);\n }\n \n+static int\n+test_tls_record_proto_sgl_oop(enum rte_security_tls_version tls_version)\n+{\n+\tstruct tls_record_test_flags flags = {\n+\t\t.nb_segs_in_mbuf = 5,\n+\t\t.out_of_place = true,\n+\t\t.tls_version = tls_version\n+\t};\n+\tstruct crypto_testsuite_params *ts_params = &testsuite_params;\n+\tstruct rte_cryptodev_info dev_info;\n+\n+\trte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);\n+\tif (!(dev_info.feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) {\n+\t\tprintf(\"Device doesn't support in-place scatter-gather. Test Skipped.\\n\");\n+\t\treturn TEST_SKIPPED;\n+\t}\n+\n+\treturn test_tls_record_proto_all(&flags);\n+}\n+\n+static int\n+test_tls_1_2_record_proto_sgl_oop(void)\n+{\n+\treturn test_tls_record_proto_sgl_oop(RTE_SECURITY_VERSION_TLS_1_2);\n+}\n+\n static int\n test_tls_1_2_record_proto_sgl_data_walkthrough(void)\n {\n@@ -17657,6 +17701,10 @@ static struct unit_test_suite tls12_record_proto_testsuite = {\n \t\t\t\"Multi-segmented mode data walkthrough\",\n \t\t\tut_setup_security, ut_teardown,\n \t\t\ttest_tls_1_2_record_proto_sgl_data_walkthrough),\n+\t\tTEST_CASE_NAMED_ST(\n+\t\t\t\"Multi-segmented mode out of place\",\n+\t\t\tut_setup_security, ut_teardown,\n+\t\t\ttest_tls_1_2_record_proto_sgl_oop),\n \t\tTEST_CASE_NAMED_ST(\n \t\t\t\"TLS packet header corruption\",\n \t\t\tut_setup_security, ut_teardown,\ndiff --git a/app/test/test_cryptodev_security_tls_record.h b/app/test/test_cryptodev_security_tls_record.h\nindex b31c38af06..e788d36b7a 100644\n--- a/app/test/test_cryptodev_security_tls_record.h\n+++ b/app/test/test_cryptodev_security_tls_record.h\n@@ -98,6 +98,7 @@ struct tls_record_test_flags {\n \tbool pkt_corruption;\n \tbool zero_len;\n \tbool padding_corruption;\n+\tbool out_of_place;\n \tuint8_t nb_segs_in_mbuf;\n \tuint8_t opt_padding;\n \tenum rte_security_tls_version tls_version;\n", "prefixes": [ "v3", "21/21" ] }