Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138131/?format=api
{ "id": 138131, "url": "http://patches.dpdk.org/api/patches/138131/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240308181137.69855-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240308181137.69855-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240308181137.69855-3-stephen@networkplumber.org", "date": "2024-03-08T18:10:25", "name": "[v3,2/3] examples/vm_power_manager: do not use EAL logtype", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7351ec9fbe1e7b0a8fd1a37cbe2a463f8582d1c6", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240308181137.69855-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 31443, "url": "http://patches.dpdk.org/api/series/31443/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31443", "date": "2024-03-08T18:10:23", "name": "replace use of EAL logtype in applications", "version": 3, "mbox": "http://patches.dpdk.org/series/31443/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138131/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138131/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 523E443C27;\n\tFri, 8 Mar 2024 19:12:02 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8AC2142F9D;\n\tFri, 8 Mar 2024 19:11:52 +0100 (CET)", "from mail-pf1-f172.google.com (mail-pf1-f172.google.com\n [209.85.210.172])\n by mails.dpdk.org (Postfix) with ESMTP id E0BA1402BB\n for <dev@dpdk.org>; Fri, 8 Mar 2024 19:11:49 +0100 (CET)", "by mail-pf1-f172.google.com with SMTP id\n d2e1a72fcca58-6da9c834646so2152546b3a.3\n for <dev@dpdk.org>; Fri, 08 Mar 2024 10:11:49 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n fn17-20020a056a002fd100b006e2301e702fsm14376020pfb.125.2024.03.08.10.11.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 08 Mar 2024 10:11:48 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709921509;\n x=1710526309; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=EStD9EvR6OoecugU86AyTaCTLdlfFyksP+Y5mTQTQRU=;\n b=GyQieI0V70EnOPu/n4jX7rkV1If5tpwrUdHi14Fx8Sqx8qq+ylKbUqQP0q2qumWOT7\n yK7Fu2KS/i77djt9fjQYc7RTnedl0+UpH08szZtSHUIpAV0s/zcFoGOo6CNQnfaJSW/i\n /zvNiodnUtIlmng0MqpOwQj4kmiNPHePGF2CeQhElmcT/eH+w4MOQdDX0BE6eQGISzax\n kfBFjvfYpFfsTqA5JuwzJnTOP6rpIVcZPzdx8uhlYtZP6wLGyDVD+EoZiZCjedccwHKh\n OJSkOiAD7WEksa+BStvAR464wcGCydl8W2MXnYjqDkVztsXFKXQODKGqCNo566eNPdEI\n hRlQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1709921509; x=1710526309;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=EStD9EvR6OoecugU86AyTaCTLdlfFyksP+Y5mTQTQRU=;\n b=PQAeMGcvcRzS/aCHVhbiWCWrp0tDECy/3evsTZqGBruKOWCIrCNt7c55+c90dgLB71\n aefOvA7UWGTHboT78vI78xqn3WEBpeoIP7FaZTywhA73kr67NKKPpp4w34r1x8VGaTA+\n whJbL4ASoejBQZNBm7c7FT/Yb5Tg1COwajPcntYcPZD0VkLhAoTsnd8ybKQhfbhnROBy\n ToA3kGQ8MQ1TbbK9IfcGCwUDUM3jIraLKn0yDKO29IDhfRfU8JLD7ZeOljSNGvGSBETO\n 631+at5A94xcoOWeTuKWGJBTAaNDt6PjC/YWVyzFdEc18hvQhIBLNs+chzGbnwBKl8wL\n C6gQ==", "X-Gm-Message-State": "AOJu0Yx0YWO11RInPUlNmy4Lu17OaVEbrdalnIzh/52+PdJ30WgVMjRM\n X/q6zelGeHuOMkMdaBZGer+ySfH4zu32/YlHMbKCu38w0L7BE5GLE/9Ezy8gp9Zffq0MipDgjYL\n R//Y=", "X-Google-Smtp-Source": "\n AGHT+IH9XBnF9oKQJKCl6lK5U2cQVnVg2upVkH78spGNoXUdXYr/Vwmv7FNR7/O/yThSWdvhD984MQ==", "X-Received": "by 2002:a05:6a20:3941:b0:1a1:2f17:b13c with SMTP id\n r1-20020a056a20394100b001a12f17b13cmr13129856pzg.3.1709921509192;\n Fri, 08 Mar 2024 10:11:49 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n David Hunt <david.hunt@intel.com>, Huisong Li <lihuisong@huawei.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>", "Subject": "[PATCH v3 2/3] examples/vm_power_manager: do not use EAL logtype", "Date": "Fri, 8 Mar 2024 10:10:25 -0800", "Message-ID": "<20240308181137.69855-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240308181137.69855-1-stephen@networkplumber.org>", "References": "<20231211172437.61958-1-stephen@networkplumber.org>\n <20240308181137.69855-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Be consistent for all the error printouts and use fprintf().\nThe EAL logtype is reserved for internal use by EAL.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: David Hunt <david.hunt@intel.com>\nAcked-by: Huisong Li <lihuisong@huawei.com>\n---\n examples/vm_power_manager/main.c | 11 ++++-------\n 1 file changed, 4 insertions(+), 7 deletions(-)", "diff": "diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c\nindex b159291d77ce..c14138202004 100644\n--- a/examples/vm_power_manager/main.c\n+++ b/examples/vm_power_manager/main.c\n@@ -17,7 +17,6 @@\n #include <rte_common.h>\n #include <rte_eal.h>\n #include <rte_launch.h>\n-#include <rte_log.h>\n #include <rte_per_lcore.h>\n #include <rte_lcore.h>\n #include <rte_ethdev.h>\n@@ -425,8 +424,7 @@ main(int argc, char **argv)\n \n \tlcore_id = rte_get_next_lcore(-1, 1, 0);\n \tif (lcore_id == RTE_MAX_LCORE) {\n-\t\tRTE_LOG(ERR, EAL, \"A minimum of three cores are required to run \"\n-\t\t\t\t\"application\\n\");\n+\t\tfprintf(stderr, \"A minimum of three cores are required to run application\\n\");\n \t\treturn 0;\n \t}\n \tprintf(\"Running channel monitor on lcore id %d\\n\", lcore_id);\n@@ -434,16 +432,15 @@ main(int argc, char **argv)\n \n \tlcore_id = rte_get_next_lcore(lcore_id, 1, 0);\n \tif (lcore_id == RTE_MAX_LCORE) {\n-\t\tRTE_LOG(ERR, EAL, \"A minimum of three cores are required to run \"\n-\t\t\t\t\"application\\n\");\n+\t\tfprintf(stderr, \"A minimum of three cores are required to run application\\n\");\n \t\treturn 0;\n \t}\n \tif (power_manager_init() < 0) {\n-\t\tprintf(\"Unable to initialize power manager\\n\");\n+\t\tfprintf(stderr, \"Unable to initialize power manager\\n\");\n \t\treturn -1;\n \t}\n \tif (channel_manager_init(CHANNEL_MGR_DEFAULT_HV_PATH) < 0) {\n-\t\tprintf(\"Unable to initialize channel manager\\n\");\n+\t\tfprintf(stderr, \"Unable to initialize channel manager\\n\");\n \t\treturn -1;\n \t}\n \n", "prefixes": [ "v3", "2/3" ] }