Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138130/?format=api
{ "id": 138130, "url": "http://patches.dpdk.org/api/patches/138130/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240308181137.69855-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240308181137.69855-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240308181137.69855-2-stephen@networkplumber.org", "date": "2024-03-08T18:10:24", "name": "[v3,1/3] examples/l2fwd-keepalive: don't use EAL logtype", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fe3000cdf630a5e3095e38c7f94817e26571fc1a", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240308181137.69855-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 31443, "url": "http://patches.dpdk.org/api/series/31443/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31443", "date": "2024-03-08T18:10:23", "name": "replace use of EAL logtype in applications", "version": 3, "mbox": "http://patches.dpdk.org/series/31443/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138130/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/138130/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B0ACE43C27;\n\tFri, 8 Mar 2024 19:11:56 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7061842FBD;\n\tFri, 8 Mar 2024 19:11:51 +0100 (CET)", "from mail-pf1-f180.google.com (mail-pf1-f180.google.com\n [209.85.210.180])\n by mails.dpdk.org (Postfix) with ESMTP id 0A2A140274\n for <dev@dpdk.org>; Fri, 8 Mar 2024 19:11:49 +0100 (CET)", "by mail-pf1-f180.google.com with SMTP id\n d2e1a72fcca58-6e64647af39so2259122b3a.1\n for <dev@dpdk.org>; Fri, 08 Mar 2024 10:11:48 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n fn17-20020a056a002fd100b006e2301e702fsm14376020pfb.125.2024.03.08.10.11.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 08 Mar 2024 10:11:47 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709921508;\n x=1710526308; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ouf2tLM2rmIfd8fhlG+D3i1UvTfrSWV6CufHtPdxR6M=;\n b=Q8Up4MUB7FhfKPN6MazMOAgG+PKZZCiDf0WYDpxZvLggTBpvJ5gtVwtyqe+rftCNKn\n rJ7w0phV0VGguCkn+QDeAnO7VxPPqMKXXM7Y9Ik7EZSBqg/cAB+Rapm/yl0RgAwu5f10\n Y4fMjd3e712i3Yrm8w9TTsDcvpeaSfAACgleaBNuMTZqvQYuUZwXeLWbFvq7EyJtWFsv\n ITeVaY5Jl6yDW64y4opkSir8mVpXz2Wg1zLiZTKBb7KY0XhKPU2qDHde+qcDeSda+QoN\n Cjpatey/XZyj4pnd9U61BYApeAoSK/57WS/1h2AU3lpp6z6ZHunqBFNQ16488ogYe4iu\n FLTA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1709921508; x=1710526308;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=ouf2tLM2rmIfd8fhlG+D3i1UvTfrSWV6CufHtPdxR6M=;\n b=A5/DsJ3if8Qi27TZMs2KmEI4Rqks9Q0aRnKocx22nVjlOPOcbnhlvjjTQA16Vqbizn\n ypwlcyC1hwhjX9dI8OlDE2jtIC3+Uxq7icEy8vCETQ6NRbKRq45QM4bQRZgMIRZONiV3\n iM5mhm7Su0x2YELGg+aqJalEVcXnXwMDlDQpyMhurTwVxXpMMinYbuTGu8T2vs32Smhe\n Nk8jOd0y2USuFxkc4G3NUTJ3uc6VGv6bfFDGkx5spIHtPBdOTR98CSx2bSIqGkSaG9Wo\n rQT4AKDfLg5mFN1Lqj/VZe5jQsTJGIBrArByCpqy/3wvn0gJRkVye4R8ZF3YfR0Dqu8I\n gC5w==", "X-Gm-Message-State": "AOJu0YxDRu3921mXJow5FKHehLUUmvi9vO1esAKPwHqA3RfgHb4Gc8H+\n sr/a2ipizolRBcXpZvX8ohkZD6wGcMHvstywkOBRyYIGgw8lazmv0pVTTEEuLVzuOYk4NvjYu/D\n TsNU=", "X-Google-Smtp-Source": "\n AGHT+IEt7ANOS8QssI+ISTmoj5zLtLVcd/GEtw6wUjCUz4lUGBYJ8zxVccknOdZp4Yh6Kn2E1iHHTA==", "X-Received": "by 2002:a05:6a20:431e:b0:1a1:6d5e:3293 with SMTP id\n h30-20020a056a20431e00b001a16d5e3293mr8401158pzk.47.1709921508254;\n Fri, 08 Mar 2024 10:11:48 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Huisong Li <lihuisong@huawei.com>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>", "Subject": "[PATCH v3 1/3] examples/l2fwd-keepalive: don't use EAL logtype", "Date": "Fri, 8 Mar 2024 10:10:24 -0800", "Message-ID": "<20240308181137.69855-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240308181137.69855-1-stephen@networkplumber.org>", "References": "<20231211172437.61958-1-stephen@networkplumber.org>\n <20240308181137.69855-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "EAL logtype should be reserved for EAL library.\nThis example is already has a log wrapper so use it.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Huisong Li <lihuisong@huawei.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n examples/l2fwd-keepalive/main.c | 2 --\n examples/l2fwd-keepalive/shm.c | 29 ++++++++++++-----------------\n examples/l2fwd-keepalive/shm.h | 5 +++++\n 3 files changed, 17 insertions(+), 19 deletions(-)", "diff": "diff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd-keepalive/main.c\nindex 1463cef0fc2e..dca944fc173f 100644\n--- a/examples/l2fwd-keepalive/main.c\n+++ b/examples/l2fwd-keepalive/main.c\n@@ -41,8 +41,6 @@\n \n #include \"shm.h\"\n \n-#define RTE_LOGTYPE_L2FWD RTE_LOGTYPE_USER1\n-\n #define NB_MBUF_PER_PORT 3000\n \n #define MAX_PKT_BURST 32\ndiff --git a/examples/l2fwd-keepalive/shm.c b/examples/l2fwd-keepalive/shm.c\nindex 7c7a9ea8ea3c..8e8c9c9c4e83 100644\n--- a/examples/l2fwd-keepalive/shm.c\n+++ b/examples/l2fwd-keepalive/shm.c\n@@ -5,7 +5,6 @@\n #include <time.h>\n \n #include <rte_common.h>\n-#include <rte_log.h>\n #include <rte_keepalive.h>\n \n #include \"shm.h\"\n@@ -22,34 +21,30 @@ struct rte_keepalive_shm *rte_keepalive_shm_create(void)\n \t * will get the new block mapped below.\n \t */\n \tif (shm_unlink(RTE_KEEPALIVE_SHM_NAME) == -1 && errno != ENOENT)\n-\t\tprintf(\"Warning: Error unlinking stale %s (%s)\\n\",\n+\t\tRTE_LOG(NOTICE, L2FWD,\n+\t\t\t\"Warning: Error unlinking stale %s (%s)\\n\",\n \t\t\tRTE_KEEPALIVE_SHM_NAME, strerror(errno));\n \n \tfd = shm_open(RTE_KEEPALIVE_SHM_NAME,\n \t\tO_CREAT | O_TRUNC | O_RDWR, 0666);\n \tif (fd < 0)\n-\t\tRTE_LOG(INFO, EAL,\n-\t\t\t\"Failed to open %s as SHM (%s)\\n\",\n-\t\t\tRTE_KEEPALIVE_SHM_NAME,\n-\t\t\tstrerror(errno));\n+\t\tRTE_LOG(ERR, L2FWD, \"Failed to open %s as SHM (%s)\\n\",\n+\t\t\tRTE_KEEPALIVE_SHM_NAME, strerror(errno));\n \telse if (ftruncate(fd, sizeof(struct rte_keepalive_shm)) != 0)\n-\t\tRTE_LOG(INFO, EAL,\n-\t\t\t\"Failed to resize SHM (%s)\\n\", strerror(errno));\n+\t\tRTE_LOG(ERR, L2FWD, \"Failed to resize SHM (%s)\\n\", strerror(errno));\n \telse {\n \t\tka_shm = (struct rte_keepalive_shm *) mmap(\n \t\t\t0, sizeof(struct rte_keepalive_shm),\n \t\t\tPROT_READ | PROT_WRITE,\tMAP_SHARED, fd, 0);\n \t\tclose(fd);\n \t\tif (ka_shm == MAP_FAILED)\n-\t\t\tRTE_LOG(INFO, EAL,\n-\t\t\t\t\"Failed to mmap SHM (%s)\\n\", strerror(errno));\n+\t\t\tRTE_LOG(ERR, L2FWD, \"Failed to mmap SHM (%s)\\n\", strerror(errno));\n \t\telse {\n \t\t\tmemset(ka_shm, 0, sizeof(struct rte_keepalive_shm));\n \n \t\t\t/* Initialize the semaphores for IPC/SHM use */\n \t\t\tif (sem_init(&ka_shm->core_died, 1, 0) != 0) {\n-\t\t\t\tRTE_LOG(INFO, EAL,\n-\t\t\t\t\t\"Failed to setup SHM semaphore (%s)\\n\",\n+\t\t\t\tRTE_LOG(ERR, L2FWD, \"Failed to setup SHM semaphore (%s)\\n\",\n \t\t\t\t\tstrerror(errno));\n \t\t\t\tmunmap(ka_shm,\n \t\t\t\t\tsizeof(struct rte_keepalive_shm));\n@@ -87,7 +82,7 @@ void rte_keepalive_relayed_state(struct rte_keepalive_shm *shm,\n \t\t * ka_agent is not active.\n \t\t */\n \t\tif (sem_getvalue(&shm->core_died, &count) == -1) {\n-\t\t\tRTE_LOG(INFO, EAL, \"Semaphore check failed(%s)\\n\",\n+\t\t\tRTE_LOG(ERR, L2FWD, \"Semaphore check failed(%s)\\n\",\n \t\t\t\tstrerror(errno));\n \t\t\treturn;\n \t\t}\n@@ -95,8 +90,7 @@ void rte_keepalive_relayed_state(struct rte_keepalive_shm *shm,\n \t\t\treturn;\n \n \t\tif (sem_post(&shm->core_died) != 0)\n-\t\t\tRTE_LOG(INFO, EAL,\n-\t\t\t\t\"Failed to increment semaphore (%s)\\n\",\n+\t\t\tRTE_LOG(ERR, L2FWD, \"Failed to increment semaphore (%s)\\n\",\n \t\t\t\tstrerror(errno));\n \t}\n }\n@@ -104,9 +98,10 @@ void rte_keepalive_relayed_state(struct rte_keepalive_shm *shm,\n void rte_keepalive_shm_cleanup(struct rte_keepalive_shm *ka_shm)\n {\n \tif (shm_unlink(RTE_KEEPALIVE_SHM_NAME) == -1 && errno != ENOENT)\n-\t\tprintf(\"Warning: Error unlinking %s (%s)\\n\",\n+\t\tRTE_LOG(NOTICE, L2FWD, \"Warning: Error unlinking %s (%s)\\n\",\n \t\t\tRTE_KEEPALIVE_SHM_NAME, strerror(errno));\n \n \tif (ka_shm && munmap(ka_shm, sizeof(struct rte_keepalive_shm)) != 0)\n-\t\tprintf(\"Warning: munmap() failed\\n\");\n+\t\tRTE_LOG(ERR, L2FWD, \"Warning: munmap() failed: %s \\n\",\n+\t\t\tstrerror(errno));\n }\ndiff --git a/examples/l2fwd-keepalive/shm.h b/examples/l2fwd-keepalive/shm.h\nindex 7a9d597295e0..d6941e25b3d7 100644\n--- a/examples/l2fwd-keepalive/shm.h\n+++ b/examples/l2fwd-keepalive/shm.h\n@@ -7,13 +7,18 @@\n #define RTE_KEEPALIVE_SHM_ALIVE 1\n #define RTE_KEEPALIVE_SHM_DEAD 2\n \n+\n #include <fcntl.h>\n #include <string.h>\n #include <unistd.h>\n #include <sys/mman.h>\n #include <sys/stat.h>\n #include <semaphore.h>\n+\n #include <rte_keepalive.h>\n+#include <rte_log.h>\n+\n+#define RTE_LOGTYPE_L2FWD RTE_LOGTYPE_USER1\n \n /**\n * Keepalive SHM structure.\n", "prefixes": [ "v3", "1/3" ] }