Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138094/?format=api
{ "id": 138094, "url": "http://patches.dpdk.org/api/patches/138094/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240307101910.1135720-2-getelson@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240307101910.1135720-2-getelson@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240307101910.1135720-2-getelson@nvidia.com", "date": "2024-03-07T10:19:08", "name": "[v2,1/3] net/mlx5: fix HWS meter actions availability", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "83af0f5e4a12b5a486ba0555e72bb624c184f7a3", "submitter": { "id": 1882, "url": "http://patches.dpdk.org/api/people/1882/?format=api", "name": "Gregory Etelson", "email": "getelson@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240307101910.1135720-2-getelson@nvidia.com/mbox/", "series": [ { "id": 31419, "url": "http://patches.dpdk.org/api/series/31419/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31419", "date": "2024-03-07T10:19:08", "name": "net/mlx5: fix sync meter processing in HWS setup", "version": 2, "mbox": "http://patches.dpdk.org/series/31419/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138094/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138094/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E6F7E43BA7;\n\tThu, 7 Mar 2024 11:19:48 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B2E2442D26;\n\tThu, 7 Mar 2024 11:19:48 +0100 (CET)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2084.outbound.protection.outlook.com [40.107.223.84])\n by mails.dpdk.org (Postfix) with ESMTP id D16E940E50;\n Thu, 7 Mar 2024 11:19:47 +0100 (CET)", "from CH0PR08CA0007.namprd08.prod.outlook.com (2603:10b6:610:33::12)\n by CYXPR12MB9337.namprd12.prod.outlook.com (2603:10b6:930:d8::20)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.26; Thu, 7 Mar\n 2024 10:19:45 +0000", "from CH2PEPF0000009A.namprd02.prod.outlook.com\n (2603:10b6:610:33:cafe::60) by CH0PR08CA0007.outlook.office365.com\n (2603:10b6:610:33::12) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.26 via Frontend\n Transport; Thu, 7 Mar 2024 10:19:45 +0000", "from mail.nvidia.com (216.228.117.160) by\n CH2PEPF0000009A.mail.protection.outlook.com (10.167.244.22) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7362.11 via Frontend Transport; Thu, 7 Mar 2024 10:19:45 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 7 Mar 2024\n 02:19:30 -0800", "from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 7 Mar\n 2024 02:19:26 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=CkXd2BjRc1WAI8nd6/UrBdQo3v1algs6d8zAIihq5WJeC2BZolIAqCOSeZVnSazIMVKqHq5CRBmf7NCFWryDmZTgjcKK9AKeyBLBfyM0rbTZ85IasLJY2wzfb3j/Ai9iVaH3ZOrZrIEmOVPofmKwEe18KNmfutFvsyl7dOuQqFnCWI3+T7WIc24+A/D/710EN447SZuW5GB36n5M0NirtfyxyRIV27Vp73JtGY9FYkdwplgN2g1S3rer8KtseK+S/TgLrezCj+rXZ0v4Q0BE25xMVnO9uidGqmdAyFzESGB+ROqoMwCC2slRo5g9uBreqCm0yIzy7nOe1ZEUO05P1Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=FQ6COwgA7EDugiDitjOB2+j6se8K2sbrNMBNWEv1Kd0=;\n b=TK6xdGJl6DkSi3TgwAguy67gX1eDN/zOyyublYYPNkP2+uZ+6vFrE6wBetzFfFYqSQU0Xr1ii73I5YxxFjOIB/nBzOfBhDa6kaOEgBjq7uMZgYsskOmAhxIIzukBjo1UPUEpXgslCHJz1+vzGHom8TyZCBHgdeWFLfLDy9Sn2PYJ/67wVWCxwe5k8/STDkTz9PlusjXOi9OLqYrI5OoiHDf2ydDiA00GtaOs8ExAxzYvW8fnFqpaa6YBC7YRxxbhVJxZBt/CPRM7BKMLCJC1FEkYxQW7nWWu1S+SjDXvU+N0zYDxeFSq3Xc/DlvRsc+q1YmVCJ5+h8cuGL7ZnXvf1Q==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=FQ6COwgA7EDugiDitjOB2+j6se8K2sbrNMBNWEv1Kd0=;\n b=sCCrYMrgnTI/SJIZps0c9X7bR+69igGEIg1PB/xqDs5Ry4SzLQTeqOjJ4s45vMG/Clkzucaqu70sHWrO0GyGnQn4j8/9STaD00TMMcvuUTBrEbhmFLDS1E3PLulcA9Kr9Q7c18vJW2ptqDKCBvwQlL999eriFQ5sBBKaUp74FTd4KrV32+MosBpnvwjV0SSjkc0OmuShqmSba9J6t+9Rc8q6b0+JoyfDk17RTt+6LIr2+kSQtWySQyZEqETPBbc0Jjoan7geMMDWi4NCQN380Ym4QZX29Z3UmzRhhu+jg2kvvDe3WiWZGe8HAq//h7vL380JOdeYQaKZSQXeKrJaLQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Gregory Etelson <getelson@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<getelson@nvidia.com>, <mkashani@nvidia.com>, <rasland@nvidia.com>,\n <stable@dpdk.org>, Dariusz Sosnowski <dsosnowski@nvidia.com>, \"Viacheslav\n Ovsiienko\" <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>, Suanming Mou\n <suanmingm@nvidia.com>, Matan Azrad <matan@nvidia.com>, Alexander Kozyrev\n <akozyrev@nvidia.com>", "Subject": "[PATCH v2 1/3] net/mlx5: fix HWS meter actions availability", "Date": "Thu, 7 Mar 2024 12:19:08 +0200", "Message-ID": "<20240307101910.1135720-2-getelson@nvidia.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20240307101910.1135720-1-getelson@nvidia.com>", "References": "<20240229105614.593391-1-getelson@nvidia.com>\n <20240307101910.1135720-1-getelson@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.231.35]", "X-ClientProxiedBy": "rnnvmail202.nvidia.com (10.129.68.7) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CH2PEPF0000009A:EE_|CYXPR12MB9337:EE_", "X-MS-Office365-Filtering-Correlation-Id": "0441a003-9c00-4f7c-9a6e-08dc3e901c94", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n aaG82xtkg5d4v7ZnQU+8Q77dZ+fVIJDVtjM/uhlwxUOoUXLDApulEDb7Xbnph6FuQ2pibkhrSylmEFcrLg9PLLdCmiVPBUoPhRdxmrWKoOTL0yacpQHoLLPEcUBtNl1h4Ocf872jTyPCvaEORBaQOk3xUiAfUm5h22g3zwoStTTmj9kDsZ91ncGElscXP7re8/oPPP38E0xOh6FvJgU5M9S/Trrp161Mjm+OXKuZ+yk0DqaGiPQgWuJN+NLHlhzUyHGNkfPCdNQ7qRM7b0EBvOOowVTybNgTT9y/PRsi6u6fUkaDAH54QMRYROQSY8KJ9T9hF5GoLPBjaqmxJ9UMzFGQpnGexfqA1ebGyww8E9idx80y8qtIesEgfebtfTXCbCVCxkLhCbmlS6Olrbh9n+xpuPfRoU1vANdrPHY/iieMVm9qgkrBvQxmze0tNzIsqw2MHRrgh/1eVm+aJuCcZEsDMncrcvifSQA95lVbZXbIvO0O9PzA2G6qVnuaNQn3c7BMJ6e9cjSaPsssOZPBU042s4isZOZU8BwnPjLkO9ytMkYwYfFtApC9EtjpVuMG5Hsw4HFn3WXzLm0RIefotMDSpZuHAybaV9WgMv2kgznzJEnpr4NXRcHchdrGatLV1FGXZtwBBTEQxuObLl0oaC669NRTrLFMUEbanoz28IGqXmkFwvL/tf7bzCaj79uEDervn+ffeYoVudLXP0tv/cWfq5lT/J4hAxjNxnTVpAsd69izB+7mLAamoH/V0tXN", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(376005)(82310400014)(36860700004); DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 Mar 2024 10:19:45.3762 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 0441a003-9c00-4f7c-9a6e-08dc3e901c94", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CH2PEPF0000009A.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CYXPR12MB9337", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Allow compilation of HWS meter code only on platforms\nthat support HWS.\n\nFixes: 24865366e495 (\"net/mlx5: support flow meter action for HWS\")\n\nCc: stable@dpdk.org\n\nSigned-off-by: Gregory Etelson <getelson@nvidia.com>\nAcked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_meter.c | 28 ++++++++++++++++++++++++----\n 1 file changed, 24 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_meter.c b/drivers/net/mlx5/mlx5_flow_meter.c\nindex c0578ce6e9..57de95b4b9 100644\n--- a/drivers/net/mlx5/mlx5_flow_meter.c\n+++ b/drivers/net/mlx5/mlx5_flow_meter.c\n@@ -896,6 +896,7 @@ mlx5_flow_meter_profile_get(struct rte_eth_dev *dev,\n \t\t\t\t\t\t\tmeter_profile_id);\n }\n \n+#if defined(HAVE_MLX5_HWS_SUPPORT)\n /**\n * Callback to add MTR profile with HWS.\n *\n@@ -981,6 +982,7 @@ mlx5_flow_meter_profile_hws_delete(struct rte_eth_dev *dev,\n \tmemset(fmp, 0, sizeof(struct mlx5_flow_meter_profile));\n \treturn 0;\n }\n+#endif\n \n /**\n * Find policy by id.\n@@ -1123,6 +1125,7 @@ mlx5_flow_meter_policy_validate(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+#if defined(HAVE_MLX5_HWS_SUPPORT)\n /**\n * Callback to check MTR policy action validate for HWS\n *\n@@ -1159,6 +1162,7 @@ mlx5_flow_meter_policy_hws_validate(struct rte_eth_dev *dev,\n \t}\n \treturn 0;\n }\n+#endif\n \n static int\n __mlx5_flow_meter_policy_delete(struct rte_eth_dev *dev,\n@@ -1485,6 +1489,7 @@ mlx5_flow_meter_policy_get(struct rte_eth_dev *dev,\n \t\t\t\t\t\t\t &policy_idx);\n }\n \n+#if defined(HAVE_MLX5_HWS_SUPPORT)\n /**\n * Callback to delete MTR policy for HWS.\n *\n@@ -1807,7 +1812,7 @@ mlx5_flow_meter_policy_hws_add(struct rte_eth_dev *dev,\n \t\t\t\t RTE_MTR_ERROR_TYPE_UNSPECIFIED,\n \t\t\t\t NULL, \"Failed to create meter policy.\");\n }\n-\n+#endif\n /**\n * Check meter validation.\n *\n@@ -2177,6 +2182,7 @@ mlx5_flow_meter_create(struct rte_eth_dev *dev, uint32_t meter_id,\n \t\tNULL, \"Failed to create devx meter.\");\n }\n \n+#if defined(HAVE_MLX5_HWS_SUPPORT)\n /**\n * Create meter rules.\n *\n@@ -2260,6 +2266,7 @@ mlx5_flow_meter_hws_create(struct rte_eth_dev *dev, uint32_t meter_id,\n \t__atomic_fetch_add(&policy->ref_cnt, 1, __ATOMIC_RELAXED);\n \treturn 0;\n }\n+#endif\n \n static int\n mlx5_flow_meter_params_flush(struct rte_eth_dev *dev,\n@@ -2744,6 +2751,7 @@ static const struct rte_mtr_ops mlx5_flow_mtr_ops = {\n \t.stats_read = mlx5_flow_meter_stats_read,\n };\n \n+#if defined(HAVE_MLX5_HWS_SUPPORT)\n static const struct rte_mtr_ops mlx5_flow_mtr_hws_ops = {\n \t.capabilities_get = mlx5_flow_mtr_cap_get,\n \t.meter_profile_add = mlx5_flow_meter_profile_hws_add,\n@@ -2762,6 +2770,7 @@ static const struct rte_mtr_ops mlx5_flow_mtr_hws_ops = {\n \t.stats_update = NULL,\n \t.stats_read = NULL,\n };\n+#endif\n \n /**\n * Get meter operations.\n@@ -2777,12 +2786,16 @@ static const struct rte_mtr_ops mlx5_flow_mtr_hws_ops = {\n int\n mlx5_flow_meter_ops_get(struct rte_eth_dev *dev __rte_unused, void *arg)\n {\n+#if defined(HAVE_MLX5_HWS_SUPPORT)\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \n \tif (priv->sh->config.dv_flow_en == 2)\n \t\t*(const struct rte_mtr_ops **)arg = &mlx5_flow_mtr_hws_ops;\n \telse\n \t\t*(const struct rte_mtr_ops **)arg = &mlx5_flow_mtr_ops;\n+#else\n+\t*(const struct rte_mtr_ops **)arg = &mlx5_flow_mtr_ops;\n+#endif\n \treturn 0;\n }\n \n@@ -3161,7 +3174,6 @@ mlx5_flow_meter_flush(struct rte_eth_dev *dev, struct rte_mtr_error *error)\n \tstruct mlx5_flow_meter_profile *fmp;\n \tstruct mlx5_legacy_flow_meter *legacy_fm;\n \tstruct mlx5_flow_meter_info *fm;\n-\tstruct mlx5_flow_meter_policy *policy;\n \tstruct mlx5_flow_meter_sub_policy *sub_policy;\n \tvoid *tmp;\n \tuint32_t i, mtr_idx, policy_idx;\n@@ -3229,15 +3241,20 @@ mlx5_flow_meter_flush(struct rte_eth_dev *dev, struct rte_mtr_error *error)\n \t\tmlx5_l3t_destroy(priv->policy_idx_tbl);\n \t\tpriv->policy_idx_tbl = NULL;\n \t}\n+#if defined(HAVE_MLX5_HWS_SUPPORT)\n \tif (priv->mtr_policy_arr) {\n+\t\tstruct mlx5_flow_meter_policy *policy;\n+\n \t\tfor (i = 0; i < priv->mtr_config.nb_meter_policies; i++) {\n \t\t\tpolicy = mlx5_flow_meter_policy_find(dev, i,\n \t\t\t\t\t\t\t &policy_idx);\n-\t\t\tif (policy->initialized)\n+\t\t\tif (policy->initialized) {\n \t\t\t\tmlx5_flow_meter_policy_hws_delete(dev, i,\n \t\t\t\t\t\t\t\t error);\n+\t\t\t}\n \t\t}\n \t}\n+#endif\n \tif (priv->mtr_profile_tbl) {\n \t\tMLX5_L3T_FOREACH(priv->mtr_profile_tbl, i, entry) {\n \t\t\tfmp = entry;\n@@ -3251,14 +3268,17 @@ mlx5_flow_meter_flush(struct rte_eth_dev *dev, struct rte_mtr_error *error)\n \t\tmlx5_l3t_destroy(priv->mtr_profile_tbl);\n \t\tpriv->mtr_profile_tbl = NULL;\n \t}\n+#if defined(HAVE_MLX5_HWS_SUPPORT)\n \tif (priv->mtr_profile_arr) {\n \t\tfor (i = 0; i < priv->mtr_config.nb_meter_profiles; i++) {\n \t\t\tfmp = mlx5_flow_meter_profile_find(priv, i);\n-\t\t\tif (fmp->initialized)\n+\t\t\tif (fmp->initialized) {\n \t\t\t\tmlx5_flow_meter_profile_hws_delete(dev, i,\n \t\t\t\t\t\t\t\t error);\n+\t\t\t}\n \t\t}\n \t}\n+#endif\n \t/* Delete default policy table. */\n \tmlx5_flow_destroy_def_policy(dev);\n \tif (priv->sh->refcnt == 1)\n", "prefixes": [ "v2", "1/3" ] }