Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138038/?format=api
{ "id": 138038, "url": "http://patches.dpdk.org/api/patches/138038/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240306122445.4350-28-shaibran@amazon.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240306122445.4350-28-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240306122445.4350-28-shaibran@amazon.com", "date": "2024-03-06T12:24:39", "name": "[v3,27/33] net/ena/hal: modify customer metrics memory management", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a1b5d41f0f8df25d2de17d77edfa26ebf09528c6", "submitter": { "id": 2930, "url": "http://patches.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240306122445.4350-28-shaibran@amazon.com/mbox/", "series": [ { "id": 31397, "url": "http://patches.dpdk.org/api/series/31397/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31397", "date": "2024-03-06T12:24:13", "name": "net/ena: v2.9.0 driver release", "version": 3, "mbox": "http://patches.dpdk.org/series/31397/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138038/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138038/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A216943C5B;\n\tWed, 6 Mar 2024 13:28:15 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2844C42E63;\n\tWed, 6 Mar 2024 13:25:55 +0100 (CET)", "from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com\n [207.171.190.10])\n by mails.dpdk.org (Postfix) with ESMTP id B97CF42E1B\n for <dev@dpdk.org>; Wed, 6 Mar 2024 13:25:52 +0100 (CET)", "from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO\n smtpout.prod.us-east-1.prod.farcaster.email.amazon.dev) ([10.43.8.6])\n by smtp-border-fw-33001.sea14.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2024 12:25:52 +0000", "from EX19MTAEUA001.ant.amazon.com [10.0.43.254:50706]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.16.96:2525]\n with esmtp (Farcaster)\n id cc6b8b47-6bc5-4b1b-a449-b51974a8a2b8; Wed, 6 Mar 2024 12:25:50 +0000 (UTC)", "from EX19D007EUA004.ant.amazon.com (10.252.50.76) by\n EX19MTAEUA001.ant.amazon.com (10.252.50.192) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Wed, 6 Mar 2024 12:25:46 +0000", "from EX19MTAUWA001.ant.amazon.com (10.250.64.204) by\n EX19D007EUA004.ant.amazon.com (10.252.50.76) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Wed, 6 Mar 2024 12:25:45 +0000", "from HFA15-CG15235BS.amazon.com (10.1.213.21) by\n mail-relay.amazon.com (10.250.64.204) with Microsoft SMTP Server id\n 15.2.1258.28 via Frontend Transport; Wed, 6 Mar 2024 12:25:44 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1709727953; x=1741263953;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=Lgx6T8GaiUd+pGKdHCph8iOQWujbjxgXPslj7DIoynY=;\n b=Didg1/7PS840xL8huTmU0f9v6zgE2X/C/z1eLgiq2r8zjg7U3dXistjG\n FmfeVjrbn7HRl3buKLqgzDQRcfezLPNCap1AQzBYcUhZWl7+DVzTUs8xH\n 3fwBrKIIM7BqxOS42GINJ2T53as7pmIONBH6m1//XNwZK7ykno0ZEYudm I=;", "X-IronPort-AV": "E=Sophos;i=\"6.06,208,1705363200\"; d=\"scan'208\";a=\"331160194\"", "X-Farcaster-Flow-ID": "cc6b8b47-6bc5-4b1b-a449-b51974a8a2b8", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>", "Subject": "[PATCH v3 27/33] net/ena/hal: modify customer metrics memory\n management", "Date": "Wed, 6 Mar 2024 14:24:39 +0200", "Message-ID": "<20240306122445.4350-28-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240306122445.4350-1-shaibran@amazon.com>", "References": "<20240306122445.4350-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\n1. Set buffer length to zero in case memory allocation failed\n and after memory is released.\n2. The driver checks buffer_virt_addr for customer allocation\n success. In case the allocation fails, buffer_virt_addr\n may not necessarily be NULL.\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\n drivers/net/ena/hal/ena_com.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ena/hal/ena_com.c b/drivers/net/ena/hal/ena_com.c\nindex 2db21e7895..24756e5e76 100644\n--- a/drivers/net/ena/hal/ena_com.c\n+++ b/drivers/net/ena/hal/ena_com.c\n@@ -3233,13 +3233,17 @@ int ena_com_allocate_customer_metrics_buffer(struct ena_com_dev *ena_dev)\n \tstruct ena_customer_metrics *customer_metrics = &ena_dev->customer_metrics;\n \n \tcustomer_metrics->buffer_len = ENA_CUSTOMER_METRICS_BUFFER_SIZE;\n+\tcustomer_metrics->buffer_virt_addr = NULL;\n+\n \tENA_MEM_ALLOC_COHERENT(ena_dev->dmadev,\n \t\t\t customer_metrics->buffer_len,\n \t\t\t customer_metrics->buffer_virt_addr,\n \t\t\t customer_metrics->buffer_dma_addr,\n \t\t\t customer_metrics->buffer_dma_handle);\n-\tif (unlikely(!customer_metrics->buffer_virt_addr))\n+\tif (unlikely(!customer_metrics->buffer_virt_addr)) {\n+\t\tcustomer_metrics->buffer_len = 0;\n \t\treturn ENA_COM_NO_MEM;\n+\t}\n \n \treturn 0;\n }\n@@ -3283,6 +3287,7 @@ void ena_com_delete_customer_metrics_buffer(struct ena_com_dev *ena_dev)\n \t\t\t\t customer_metrics->buffer_dma_addr,\n \t\t\t\t customer_metrics->buffer_dma_handle);\n \t\tcustomer_metrics->buffer_virt_addr = NULL;\n+\t\tcustomer_metrics->buffer_len = 0;\n \t}\n }\n \n", "prefixes": [ "v3", "27/33" ] }