Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 138,
    "url": "http://patches.dpdk.org/api/patches/138/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1407789890-17355-9-git-send-email-bruce.richardson@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1407789890-17355-9-git-send-email-bruce.richardson@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1407789890-17355-9-git-send-email-bruce.richardson@intel.com",
    "date": "2014-08-11T20:44:44",
    "name": "[dpdk-dev,RFC,08/14] mbuf: split mbuf across two cache lines.",
    "commit_ref": "",
    "pull_url": "",
    "state": "rfc",
    "archived": true,
    "hash": "48ad311f590765cfb4f2327305f863a658671475",
    "submitter": {
        "id": 20,
        "url": "http://patches.dpdk.org/api/people/20/?format=api",
        "name": "Bruce Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1407789890-17355-9-git-send-email-bruce.richardson@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/138/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/138/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<bricha3@ecsmtp.ir.intel.com>",
        "Received": [
            "from mga03.intel.com (mga03.intel.com [143.182.124.21])\r\n\tby dpdk.org (Postfix) with ESMTP id CADC6B392\r\n\tfor <dev@dpdk.org>; Mon, 11 Aug 2014 22:42:20 +0200 (CEST)",
            "from azsmga001.ch.intel.com ([10.2.17.19])\r\n\tby azsmga101.ch.intel.com with ESMTP; 11 Aug 2014 13:45:09 -0700",
            "from irvmail001.ir.intel.com ([163.33.26.43])\r\n\tby azsmga001.ch.intel.com with ESMTP; 11 Aug 2014 13:44:52 -0700",
            "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\r\n\t[10.237.217.46])\r\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\r\n\ts7BKiqbq020957; Mon, 11 Aug 2014 21:44:52 +0100",
            "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\r\n\tby sivswdev02.ir.intel.com with ESMTP id s7BKiqx3017695;\r\n\tMon, 11 Aug 2014 21:44:52 +0100",
            "(from bricha3@localhost)\r\n\tby sivswdev02.ir.intel.com with  id s7BKiq17017691;\r\n\tMon, 11 Aug 2014 21:44:52 +0100"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.01,844,1400050800\"; d=\"scan'208\";a=\"467575643\"",
        "From": "Bruce Richardson <bruce.richardson@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon, 11 Aug 2014 21:44:44 +0100",
        "Message-Id": "<1407789890-17355-9-git-send-email-bruce.richardson@intel.com>",
        "X-Mailer": "git-send-email 1.7.0.7",
        "In-Reply-To": "<1407789890-17355-1-git-send-email-bruce.richardson@intel.com>",
        "References": "<1407789890-17355-1-git-send-email-bruce.richardson@intel.com>",
        "Subject": "[dpdk-dev] [RFC PATCH 08/14] mbuf: split mbuf across two cache\r\n\tlines.",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\r\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\r\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "X-List-Received-Date": "Mon, 11 Aug 2014 20:42:21 -0000"
    },
    "content": "This change splits the mbuf in two to move the pool and next pointers to\nthe second cache line. This frees up 16 bytes in first cache line.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/test/test_mbuf.c       | 2 +-\n lib/librte_mbuf/rte_mbuf.h | 5 +++++\n 2 files changed, 6 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c\r\nindex 31ef9fa..65d62dc 100644\r\n--- a/app/test/test_mbuf.c\r\n+++ b/app/test/test_mbuf.c\r\n@@ -782,7 +782,7 @@ test_failing_mbuf_sanity_check(void)\r\n int\r\n test_mbuf(void)\r\n {\r\n-\tRTE_BUILD_BUG_ON(sizeof(struct rte_mbuf) != 64);\r\n+\tRTE_BUILD_BUG_ON(sizeof(struct rte_mbuf) != CACHE_LINE_SIZE * 2);\r\n \r\n \t/* create pktmbuf pool if it does not exist */\r\n \tif (pktmbuf_pool == NULL) {\r\ndiff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h\r\nindex 566bb7e..a3e3e4f 100644\r\n--- a/lib/librte_mbuf/rte_mbuf.h\r\n+++ b/lib/librte_mbuf/rte_mbuf.h\r\n@@ -137,6 +137,9 @@ union rte_vlan_macip {\r\n  * The generic rte_mbuf, containing a packet mbuf.\r\n  */\r\n struct rte_mbuf {\r\n+\t/** dummy field marking start of first cache line */\r\n+\tvoid *cache_line0[0];\r\n+\r\n \tvoid *buf_addr;           /**< Virtual address of segment buffer. */\r\n \tphys_addr_t buf_physaddr; /**< Physical address of segment buffer. */\r\n \r\n@@ -183,6 +186,8 @@ struct rte_mbuf {\r\n \t} hash;                 /**< hash information */\r\n \r\n \t/* second cache line, fields only used in slow path or on TX */\r\n+\t/** dummy field marking start of second cache line */\r\n+\tvoid *cache_line1[0] __rte_cache_aligned;\r\n \tstruct rte_mempool *pool; /**< Pool from which mbuf was allocated. */\r\n \tstruct rte_mbuf *next;    /**< Next segment of scattered packet. */\r\n \r\n",
    "prefixes": [
        "dpdk-dev",
        "RFC",
        "08/14"
    ]
}