Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 137946,
    "url": "http://patches.dpdk.org/api/patches/137946/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1709574764-9041-33-git-send-email-roretzla@linux.microsoft.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1709574764-9041-33-git-send-email-roretzla@linux.microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1709574764-9041-33-git-send-email-roretzla@linux.microsoft.com",
    "date": "2024-03-04T17:52:37",
    "name": "[v7,32/39] bpf: use C11 alignas",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "715b7c13910a40435251036c7ba71aef13ec8924",
    "submitter": {
        "id": 2077,
        "url": "http://patches.dpdk.org/api/people/2077/?format=api",
        "name": "Tyler Retzlaff",
        "email": "roretzla@linux.microsoft.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1709574764-9041-33-git-send-email-roretzla@linux.microsoft.com/mbox/",
    "series": [
        {
            "id": 31365,
            "url": "http://patches.dpdk.org/api/series/31365/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31365",
            "date": "2024-03-04T17:52:05",
            "name": "use C11 alignas",
            "version": 7,
            "mbox": "http://patches.dpdk.org/series/31365/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/137946/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/137946/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 794AA43B6A;\n\tMon,  4 Mar 2024 18:56:40 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DBF1942EA7;\n\tMon,  4 Mar 2024 18:53:30 +0100 (CET)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 24FA0410FA\n for <dev@dpdk.org>; Mon,  4 Mar 2024 18:52:53 +0100 (CET)",
            "by linux.microsoft.com (Postfix, from userid 1086)\n id E3E2620B74E0; Mon,  4 Mar 2024 09:52:50 -0800 (PST)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com E3E2620B74E0",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1709574771;\n bh=oEHaJH8Nt06CTeDdT99jeumwTC9Q22cdpaf+qYBHKGo=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=RtXoWI/HqAnWihOa+cmaJXUXerXtaS9OJAsrmmc0VECf/sHYHyyUSeVP6ZYWcII1a\n HlXFUqMgYTznynVMxIMNRvo2hSUshA3RznC8JDwV/BS+TBczYq4OUveC/s0Oi3GDlC\n GLqSH2b9xVglL5Op8NoWoAlrPa7nOdZCCQu3JZSE=",
        "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "To": "dev@dpdk.org",
        "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "Subject": "[PATCH v7 32/39] bpf: use C11 alignas",
        "Date": "Mon,  4 Mar 2024 09:52:37 -0800",
        "Message-Id": "<1709574764-9041-33-git-send-email-roretzla@linux.microsoft.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1709574764-9041-1-git-send-email-roretzla@linux.microsoft.com>",
        "References": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>\n <1709574764-9041-1-git-send-email-roretzla@linux.microsoft.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "The current location used for __rte_aligned(a) for alignment of types\nand variables is not compatible with MSVC. There is only a single\nlocation accepted by both toolchains.\n\nFor variables standard C11 offers alignas(a) supported by conformant\ncompilers i.e. both MSVC and GCC.\n\nFor types the standard offers no alignment facility that compatibly\ninteroperates with C and C++ but may be achieved by relocating the\nplacement of __rte_aligned(a) to the aforementioned location accepted\nby all currently supported toolchains.\n\nTo allow alignment for both compilers do the following:\n\n* Move __rte_aligned from the end of {struct,union} definitions to\n  be between {struct,union} and tag.\n\n  The placement between {struct,union} and the tag allows the desired\n  alignment to be imparted on the type regardless of the toolchain being\n  used for all of GCC, LLVM, MSVC compilers building both C and C++.\n\n* Replace use of __rte_aligned(a) on variables/fields with alignas(a).\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/bpf/bpf_pkt.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/bpf/bpf_pkt.c b/lib/bpf/bpf_pkt.c\nindex 793a75d..aaca935 100644\n--- a/lib/bpf/bpf_pkt.c\n+++ b/lib/bpf/bpf_pkt.c\n@@ -23,7 +23,7 @@\n  * information about installed BPF rx/tx callback\n  */\n \n-struct bpf_eth_cbi {\n+struct __rte_cache_aligned bpf_eth_cbi {\n \t/* used by both data & control path */\n \tRTE_ATOMIC(uint32_t) use;    /*usage counter */\n \tconst struct rte_eth_rxtx_callback *cb;  /* callback handle */\n@@ -33,7 +33,7 @@ struct bpf_eth_cbi {\n \tLIST_ENTRY(bpf_eth_cbi) link;\n \tuint16_t port;\n \tuint16_t queue;\n-} __rte_cache_aligned;\n+};\n \n /*\n  * Odd number means that callback is used by datapath.\n",
    "prefixes": [
        "v7",
        "32/39"
    ]
}