Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137943/?format=api
http://patches.dpdk.org/api/patches/137943/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1709574764-9041-21-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1709574764-9041-21-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1709574764-9041-21-git-send-email-roretzla@linux.microsoft.com", "date": "2024-03-04T17:52:25", "name": "[v7,20/39] rcu: use C11 alignas", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5f02308461ccd1515e8f56f334abae0b8fb1201a", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1709574764-9041-21-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31365, "url": "http://patches.dpdk.org/api/series/31365/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31365", "date": "2024-03-04T17:52:05", "name": "use C11 alignas", "version": 7, "mbox": "http://patches.dpdk.org/series/31365/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137943/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137943/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 980AE43B9B;\n\tMon, 4 Mar 2024 18:56:19 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 777C542E96;\n\tMon, 4 Mar 2024 18:53:27 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id B89BB40EE7\n for <dev@dpdk.org>; Mon, 4 Mar 2024 18:52:52 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 3510320B74D4; Mon, 4 Mar 2024 09:52:50 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 3510320B74D4", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1709574771;\n bh=BOsYoBiSiydpWJVQvBucsvfcwGTbPz15D3f3gcRElGc=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=OysUUHvI/lBYvkldmxxMgjwgnbf/6xskknn4zjd2y7bEl56Sk8CNP7neuJowbnC+g\n jhHuzQL6FGJUcosva7sDCq8Oya+dXkUINq3yfywX6ezGhQR8xMAfmjAmzH0CbySJhL\n STa9iOUuS41FQtMtAIV2j0JRKfivexhruV2qcvoE=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v7 20/39] rcu: use C11 alignas", "Date": "Mon, 4 Mar 2024 09:52:25 -0800", "Message-Id": "<1709574764-9041-21-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1709574764-9041-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>\n <1709574764-9041-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The current location used for __rte_aligned(a) for alignment of types\nand variables is not compatible with MSVC. There is only a single\nlocation accepted by both toolchains.\n\nFor variables standard C11 offers alignas(a) supported by conformant\ncompilers i.e. both MSVC and GCC.\n\nFor types the standard offers no alignment facility that compatibly\ninteroperates with C and C++ but may be achieved by relocating the\nplacement of __rte_aligned(a) to the aforementioned location accepted\nby all currently supported toolchains.\n\nTo allow alignment for both compilers do the following:\n\n* Move __rte_aligned from the end of {struct,union} definitions to\n be between {struct,union} and tag.\n\n The placement between {struct,union} and the tag allows the desired\n alignment to be imparted on the type regardless of the toolchain being\n used for all of GCC, LLVM, MSVC compilers building both C and C++.\n\n* Replace use of __rte_aligned(a) on variables/fields with alignas(a).\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/rcu/rte_rcu_qsbr.h | 16 +++++++++-------\n 1 file changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h\nindex 7022b5a..5f180fb 100644\n--- a/lib/rcu/rte_rcu_qsbr.h\n+++ b/lib/rcu/rte_rcu_qsbr.h\n@@ -21,6 +21,8 @@\n * entered quiescent state.\n */\n \n+#include <stdalign.h>\n+\n #ifdef __cplusplus\n extern \"C\" {\n #endif\n@@ -69,7 +71,7 @@\n #define RTE_QSBR_THRID_INVALID 0xffffffff\n \n /* Worker thread counter */\n-struct rte_rcu_qsbr_cnt {\n+struct __rte_cache_aligned rte_rcu_qsbr_cnt {\n \tRTE_ATOMIC(uint64_t) cnt;\n \t/**< Quiescent state counter. Value 0 indicates the thread is offline\n \t * 64b counter is used to avoid adding more code to address\n@@ -78,7 +80,7 @@ struct rte_rcu_qsbr_cnt {\n \t */\n \tRTE_ATOMIC(uint32_t) lock_cnt;\n \t/**< Lock counter. Used when RTE_LIBRTE_RCU_DEBUG is enabled */\n-} __rte_cache_aligned;\n+};\n \n #define __RTE_QSBR_CNT_THR_OFFLINE 0\n #define __RTE_QSBR_CNT_INIT 1\n@@ -91,28 +93,28 @@ struct rte_rcu_qsbr_cnt {\n * 1) Quiescent state counter array\n * 2) Register thread ID array\n */\n-struct rte_rcu_qsbr {\n-\tRTE_ATOMIC(uint64_t) token __rte_cache_aligned;\n+struct __rte_cache_aligned rte_rcu_qsbr {\n+\talignas(RTE_CACHE_LINE_SIZE) RTE_ATOMIC(uint64_t) token;\n \t/**< Counter to allow for multiple concurrent quiescent state queries */\n \tRTE_ATOMIC(uint64_t) acked_token;\n \t/**< Least token acked by all the threads in the last call to\n \t * rte_rcu_qsbr_check API.\n \t */\n \n-\tuint32_t num_elems __rte_cache_aligned;\n+\talignas(RTE_CACHE_LINE_SIZE) uint32_t num_elems;\n \t/**< Number of elements in the thread ID array */\n \tRTE_ATOMIC(uint32_t) num_threads;\n \t/**< Number of threads currently using this QS variable */\n \tuint32_t max_threads;\n \t/**< Maximum number of threads using this QS variable */\n \n-\tstruct rte_rcu_qsbr_cnt qsbr_cnt[0] __rte_cache_aligned;\n+\talignas(RTE_CACHE_LINE_SIZE) struct rte_rcu_qsbr_cnt qsbr_cnt[0];\n \t/**< Quiescent state counter array of 'max_threads' elements */\n \n \t/**< Registered thread IDs are stored in a bitmap array,\n \t * after the quiescent state counter array.\n \t */\n-} __rte_cache_aligned;\n+};\n \n /**\n * Call back function called to free the resources.\n", "prefixes": [ "v7", "20/39" ] }{ "id": 137943, "url": "