Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137918/?format=api
{ "id": 137918, "url": "http://patches.dpdk.org/api/patches/137918/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1709574764-9041-5-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1709574764-9041-5-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1709574764-9041-5-git-send-email-roretzla@linux.microsoft.com", "date": "2024-03-04T17:52:09", "name": "[v7,04/39] sched: use C11 alignas", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a2bdabb9260e4e43949436892a919a3cf2ccfd42", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1709574764-9041-5-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31365, "url": "http://patches.dpdk.org/api/series/31365/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31365", "date": "2024-03-04T17:52:05", "name": "use C11 alignas", "version": 7, "mbox": "http://patches.dpdk.org/series/31365/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137918/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137918/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 60C8D43B9B;\n\tMon, 4 Mar 2024 18:53:18 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3B080410EE;\n\tMon, 4 Mar 2024 18:52:58 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 5E3B04027D\n for <dev@dpdk.org>; Mon, 4 Mar 2024 18:52:51 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 4013720B74C4; Mon, 4 Mar 2024 09:52:50 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 4013720B74C4", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1709574770;\n bh=1jMA5jb3VwjU8yRzclNh8nFK0T98faoSAoGCuc8jU3U=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=B54m0QUkhIvt7wYGqd7iVbdOlys6TvPD+x/xI77t20apXwSTpPNIZvBja8Ae90Lmh\n 5NvKN56gl47tf4or7CrY6DjlYBHBn80+TZSMSqgB1g4+jq4MUQMthuh8Y1GPBumv1G\n sMu6KiPFbdlqmmZNp4Ie7YgF822VzWVLwbl3aZFc=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v7 04/39] sched: use C11 alignas", "Date": "Mon, 4 Mar 2024 09:52:09 -0800", "Message-Id": "<1709574764-9041-5-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1709574764-9041-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>\n <1709574764-9041-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The current location used for __rte_aligned(a) for alignment of types\nand variables is not compatible with MSVC. There is only a single\nlocation accepted by both toolchains.\n\nFor variables standard C11 offers alignas(a) supported by conformant\ncompilers i.e. both MSVC and GCC.\n\nFor types the standard offers no alignment facility that compatibly\ninteroperates with C and C++ but may be achieved by relocating the\nplacement of __rte_aligned(a) to the aforementioned location accepted\nby all currently supported toolchains.\n\nTo allow alignment for both compilers do the following:\n\nReplace use of __rte_aligned_16 with C11 alignas(16) and garbage collect\nthe __rte_aligned_16 macro which was only used once.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/sched/rte_sched.c | 21 +++++++++++----------\n lib/sched/rte_sched_common.h | 2 --\n 2 files changed, 11 insertions(+), 12 deletions(-)", "diff": "diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c\nindex d90aa53..bbdb5d1 100644\n--- a/lib/sched/rte_sched.c\n+++ b/lib/sched/rte_sched.c\n@@ -2,6 +2,7 @@\n * Copyright(c) 2010-2014 Intel Corporation\n */\n \n+#include <stdalign.h>\n #include <stdio.h>\n #include <string.h>\n \n@@ -57,7 +58,7 @@ struct rte_sched_pipe_profile {\n \tuint8_t wrr_cost[RTE_SCHED_BE_QUEUES_PER_PIPE];\n };\n \n-struct rte_sched_pipe {\n+struct __rte_cache_aligned rte_sched_pipe {\n \t/* Token bucket (TB) */\n \tuint64_t tb_time; /* time of last update */\n \tuint64_t tb_credits;\n@@ -75,7 +76,7 @@ struct rte_sched_pipe {\n \t/* TC oversubscription */\n \tuint64_t tc_ov_credits;\n \tuint8_t tc_ov_period_id;\n-} __rte_cache_aligned;\n+};\n \n struct rte_sched_queue {\n \tuint16_t qw;\n@@ -145,7 +146,7 @@ struct rte_sched_grinder {\n \tuint8_t wrr_cost[RTE_SCHED_BE_QUEUES_PER_PIPE];\n };\n \n-struct rte_sched_subport {\n+struct __rte_cache_aligned rte_sched_subport {\n \t/* Token bucket (TB) */\n \tuint64_t tb_time; /* time of last update */\n \tuint64_t tb_credits;\n@@ -164,7 +165,7 @@ struct rte_sched_subport {\n \tdouble tc_ov_rate;\n \n \t/* Statistics */\n-\tstruct rte_sched_subport_stats stats __rte_cache_aligned;\n+\talignas(RTE_CACHE_LINE_SIZE) struct rte_sched_subport_stats stats;\n \n \t/* subport profile */\n \tuint32_t profile;\n@@ -193,7 +194,7 @@ struct rte_sched_subport {\n \n \t/* Bitmap */\n \tstruct rte_bitmap *bmp;\n-\tuint32_t grinder_base_bmp_pos[RTE_SCHED_PORT_N_GRINDERS] __rte_aligned_16;\n+\talignas(16) uint32_t grinder_base_bmp_pos[RTE_SCHED_PORT_N_GRINDERS];\n \n \t/* Grinders */\n \tstruct rte_sched_grinder grinder[RTE_SCHED_PORT_N_GRINDERS];\n@@ -212,10 +213,10 @@ struct rte_sched_subport {\n \tstruct rte_sched_pipe_profile *pipe_profiles;\n \tuint8_t *bmp_array;\n \tstruct rte_mbuf **queue_array;\n-\tuint8_t memory[0] __rte_cache_aligned;\n-} __rte_cache_aligned;\n+\talignas(RTE_CACHE_LINE_SIZE) uint8_t memory[0];\n+};\n \n-struct rte_sched_port {\n+struct __rte_cache_aligned rte_sched_port {\n \t/* User parameters */\n \tuint32_t n_subports_per_port;\n \tuint32_t n_pipes_per_subport;\n@@ -244,8 +245,8 @@ struct rte_sched_port {\n \n \t/* Large data structures */\n \tstruct rte_sched_subport_profile *subport_profiles;\n-\tstruct rte_sched_subport *subports[0] __rte_cache_aligned;\n-} __rte_cache_aligned;\n+\talignas(RTE_CACHE_LINE_SIZE) struct rte_sched_subport *subports[0];\n+};\n \n enum rte_sched_subport_array {\n \te_RTE_SCHED_SUBPORT_ARRAY_PIPE = 0,\ndiff --git a/lib/sched/rte_sched_common.h b/lib/sched/rte_sched_common.h\nindex 419700b..573d164 100644\n--- a/lib/sched/rte_sched_common.h\n+++ b/lib/sched/rte_sched_common.h\n@@ -12,8 +12,6 @@\n #include <stdint.h>\n #include <sys/types.h>\n \n-#define __rte_aligned_16 __rte_aligned(16)\n-\n #if 0\n static inline uint32_t\n rte_min_pos_4_u16(uint16_t *x)\n", "prefixes": [ "v7", "04/39" ] }