Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137903/?format=api
{ "id": 137903, "url": "http://patches.dpdk.org/api/patches/137903/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240304122942.3496-27-shaibran@amazon.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240304122942.3496-27-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240304122942.3496-27-shaibran@amazon.com", "date": "2024-03-04T12:29:35", "name": "[v2,26/33] net/ena: cosmetic changes", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "deeac7ec56a0b7c8995137ddec29606b1da23a41", "submitter": { "id": 2930, "url": "http://patches.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240304122942.3496-27-shaibran@amazon.com/mbox/", "series": [ { "id": 31362, "url": "http://patches.dpdk.org/api/series/31362/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31362", "date": "2024-03-04T12:29:09", "name": "net/ena: v2.9.0 driver release", "version": 2, "mbox": "http://patches.dpdk.org/series/31362/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137903/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/137903/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3A65243B9B;\n\tMon, 4 Mar 2024 13:33:07 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 504EA410D0;\n\tMon, 4 Mar 2024 13:30:54 +0100 (CET)", "from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com\n [207.171.190.10])\n by mails.dpdk.org (Postfix) with ESMTP id 066D042E36\n for <dev@dpdk.org>; Mon, 4 Mar 2024 13:30:51 +0100 (CET)", "from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO\n smtpout.prod.us-east-1.prod.farcaster.email.amazon.dev) ([10.43.8.6])\n by smtp-border-fw-33001.sea14.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 12:30:51 +0000", "from EX19MTAEUC001.ant.amazon.com [10.0.43.254:40747]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.42.123:2525]\n with esmtp (Farcaster)\n id fb5b85a3-2d45-4aca-954c-f15688868aca; Mon, 4 Mar 2024 12:30:50 +0000 (UTC)", "from EX19D007EUA002.ant.amazon.com (10.252.50.68) by\n EX19MTAEUC001.ant.amazon.com (10.252.51.155) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Mon, 4 Mar 2024 12:30:46 +0000", "from EX19MTAUWA001.ant.amazon.com (10.250.64.204) by\n EX19D007EUA002.ant.amazon.com (10.252.50.68) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Mon, 4 Mar 2024 12:30:45 +0000", "from HFA15-CG15235BS.amazon.com (10.1.212.49) by\n mail-relay.amazon.com (10.250.64.204) with Microsoft SMTP Server id\n 15.2.1258.28 via Frontend Transport; Mon, 4 Mar 2024 12:30:44 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1709555452; x=1741091452;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=dlm6VTopozRTtgsRxyisTZw4RPfugWax+gsYpfrByuM=;\n b=rUNUdzAnMAOhJGep3Z2VJw7RTwvqUbyJgg57DxnSizXgc75hBMDdG8ME\n RE+6rmiBgyueql98IF8fy4NUYTn9vOSXpUz/fGYcQi0GcnBZsNS+vTbC8\n zp0B29ggc0utyEip1yxaeHB44tmnEPuQEzOvC7ug7y+M/XNzqJ8X7+PzA g=;", "X-IronPort-AV": "E=Sophos;i=\"6.06,203,1705363200\"; d=\"scan'208\";a=\"330650664\"", "X-Farcaster-Flow-ID": "fb5b85a3-2d45-4aca-954c-f15688868aca", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>", "Subject": "[PATCH v2 26/33] net/ena: cosmetic changes", "Date": "Mon, 4 Mar 2024 14:29:35 +0200", "Message-ID": "<20240304122942.3496-27-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240304122942.3496-1-shaibran@amazon.com>", "References": "<20240304122942.3496-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\nThis patch makes several changes to improve\nthe style and readability of the code.\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\n drivers/net/ena/hal/ena_com.c | 13 +++++--------\n 1 file changed, 5 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ena/hal/ena_com.c b/drivers/net/ena/hal/ena_com.c\nindex b98540ba63..2db21e7895 100644\n--- a/drivers/net/ena/hal/ena_com.c\n+++ b/drivers/net/ena/hal/ena_com.c\n@@ -1914,15 +1914,14 @@ int ena_com_phc_get_timestamp(struct ena_com_dev *ena_dev, u64 *timestamp)\n \n \t\t/* PHC is in active state, update statistics according to req_id and error_flags */\n \t\tif ((READ_ONCE16(read_resp->req_id) != phc->req_id) ||\n-\t\t (read_resp->error_flags & ENA_PHC_ERROR_FLAGS)) {\n+\t\t (read_resp->error_flags & ENA_PHC_ERROR_FLAGS))\n \t\t\t/* Device didn't update req_id during blocking time or timestamp is invalid,\n \t\t\t * this indicates on a device error\n \t\t\t */\n \t\t\tphc->stats.phc_err++;\n-\t\t} else {\n+\t\telse\n \t\t\t/* Device updated req_id during blocking time with valid timestamp */\n \t\t\tphc->stats.phc_exp++;\n-\t\t}\n \t}\n \n \t/* Setting relative timeouts */\n@@ -2431,7 +2430,7 @@ void ena_com_aenq_intr_handler(struct ena_com_dev *ena_dev, void *data)\n \t\ttimestamp = (u64)aenq_common->timestamp_low |\n \t\t\t((u64)aenq_common->timestamp_high << 32);\n \n-\t\tena_trc_dbg(ena_dev, \"AENQ! Group[%x] Syndrome[%x] timestamp: [%\" ENA_PRIU64 \"s]\\n\",\n+\t\tena_trc_dbg(ena_dev, \"AENQ! Group[%x] Syndrome[%x] timestamp: [%\" ENA_PRIu64 \"s]\\n\",\n \t\t\t aenq_common->group,\n \t\t\t aenq_common->syndrome,\n \t\t\t timestamp);\n@@ -3233,16 +3232,15 @@ int ena_com_allocate_customer_metrics_buffer(struct ena_com_dev *ena_dev)\n {\n \tstruct ena_customer_metrics *customer_metrics = &ena_dev->customer_metrics;\n \n+\tcustomer_metrics->buffer_len = ENA_CUSTOMER_METRICS_BUFFER_SIZE;\n \tENA_MEM_ALLOC_COHERENT(ena_dev->dmadev,\n \t\t\t customer_metrics->buffer_len,\n \t\t\t customer_metrics->buffer_virt_addr,\n \t\t\t customer_metrics->buffer_dma_addr,\n \t\t\t customer_metrics->buffer_dma_handle);\n-\tif (unlikely(customer_metrics->buffer_virt_addr == NULL))\n+\tif (unlikely(!customer_metrics->buffer_virt_addr))\n \t\treturn ENA_COM_NO_MEM;\n \n-\tcustomer_metrics->buffer_len = ENA_CUSTOMER_METRICS_BUFFER_SIZE;\n-\n \treturn 0;\n }\n \n@@ -3285,7 +3283,6 @@ void ena_com_delete_customer_metrics_buffer(struct ena_com_dev *ena_dev)\n \t\t\t\t customer_metrics->buffer_dma_addr,\n \t\t\t\t customer_metrics->buffer_dma_handle);\n \t\tcustomer_metrics->buffer_virt_addr = NULL;\n-\t\tcustomer_metrics->buffer_len = 0;\n \t}\n }\n \n", "prefixes": [ "v2", "26/33" ] }