Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137891/?format=api
{ "id": 137891, "url": "http://patches.dpdk.org/api/patches/137891/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240304122942.3496-15-shaibran@amazon.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240304122942.3496-15-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240304122942.3496-15-shaibran@amazon.com", "date": "2024-03-04T12:29:23", "name": "[v2,14/33] net/ena/hal: add completion descriptor corruption check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "aa2fc9fb06157265cd64a86acf9ac2b95a724a1f", "submitter": { "id": 2930, "url": "http://patches.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240304122942.3496-15-shaibran@amazon.com/mbox/", "series": [ { "id": 31362, "url": "http://patches.dpdk.org/api/series/31362/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31362", "date": "2024-03-04T12:29:09", "name": "net/ena: v2.9.0 driver release", "version": 2, "mbox": "http://patches.dpdk.org/series/31362/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137891/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137891/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9D2EB43B9B;\n\tMon, 4 Mar 2024 13:31:29 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3260142DA7;\n\tMon, 4 Mar 2024 13:30:25 +0100 (CET)", "from smtp-fw-80008.amazon.com (smtp-fw-80008.amazon.com\n [99.78.197.219]) by mails.dpdk.org (Postfix) with ESMTP id 1AE8342DD9\n for <dev@dpdk.org>; Mon, 4 Mar 2024 13:30:22 +0100 (CET)", "from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO\n smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.25.36.214])\n by smtp-border-fw-80008.pdx80.corp.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 12:30:22 +0000", "from EX19MTAEUB001.ant.amazon.com [10.0.17.79:18299]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.0.36:2525]\n with\n esmtp (Farcaster)\n id f3514171-5a80-47da-89f6-387c263efb28; Mon, 4 Mar 2024 12:30:21 +0000 (UTC)", "from EX19D007EUA003.ant.amazon.com (10.252.50.8) by\n EX19MTAEUB001.ant.amazon.com (10.252.51.26) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Mon, 4 Mar 2024 12:30:20 +0000", "from EX19MTAUWA001.ant.amazon.com (10.250.64.204) by\n EX19D007EUA003.ant.amazon.com (10.252.50.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Mon, 4 Mar 2024 12:30:19 +0000", "from HFA15-CG15235BS.amazon.com (10.1.212.49) by\n mail-relay.amazon.com (10.250.64.204) with Microsoft SMTP Server id\n 15.2.1258.28 via Frontend Transport; Mon, 4 Mar 2024 12:30:18 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1709555423; x=1741091423;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=vT9uLUa6L4PATln0gi7ELKwa4TTMi+RHT6LRmHl0bBY=;\n b=RHWRRwAlol5Mhwa9/5i5aGOrg1kqDTfsUSKulspXg7NKYiiXrkyfpl5f\n qaWgc+nmf6woYdVbVJJvyXxgDP7SoD5+qOAM7MV7CVtZgXTKGwsRNWPR9\n ESD/RdffgHswYdWN7A36oho06YWN1HDpqtgi16ucNdxNE/a52iurVILq8 Y=;", "X-IronPort-AV": "E=Sophos;i=\"6.06,203,1705363200\"; d=\"scan'208\";a=\"70480721\"", "X-Farcaster-Flow-ID": "f3514171-5a80-47da-89f6-387c263efb28", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>", "Subject": "[PATCH v2 14/33] net/ena/hal: add completion descriptor corruption\n check", "Date": "Mon, 4 Mar 2024 14:29:23 +0200", "Message-ID": "<20240304122942.3496-15-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240304122942.3496-1-shaibran@amazon.com>", "References": "<20240304122942.3496-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\nAdding a check of the MBZ (Must Be Zero) fields in the\nincoming tx and rx completion descriptors in order to\nidentify corrupted descriptors.\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\n drivers/net/ena/hal/ena_eth_com.c | 13 +++++++++++--\n drivers/net/ena/hal/ena_eth_com.h | 14 +++++++++++++-\n 2 files changed, 24 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ena/hal/ena_eth_com.c b/drivers/net/ena/hal/ena_eth_com.c\nindex dc2935a53e..988fa013a7 100644\n--- a/drivers/net/ena/hal/ena_eth_com.c\n+++ b/drivers/net/ena/hal/ena_eth_com.c\n@@ -237,6 +237,7 @@ static int ena_com_cdesc_rx_pkt_get(struct ena_com_io_cq *io_cq,\n \t\t\t\t u16 *first_cdesc_idx,\n \t\t\t\t u16 *num_descs)\n {\n+\tstruct ena_com_dev *dev = ena_com_io_cq_to_ena_dev(io_cq);\n \tu16 count = io_cq->cur_rx_pkt_cdesc_count, head_masked;\n \tstruct ena_eth_io_rx_cdesc_base *cdesc;\n \tu32 last = 0;\n@@ -252,13 +253,21 @@ static int ena_com_cdesc_rx_pkt_get(struct ena_com_io_cq *io_cq,\n \t\tena_com_cq_inc_head(io_cq);\n \t\tif (unlikely((status & ENA_ETH_IO_RX_CDESC_BASE_FIRST_MASK) >>\n \t\t ENA_ETH_IO_RX_CDESC_BASE_FIRST_SHIFT && count != 0)) {\n-\t\t\tstruct ena_com_dev *dev = ena_com_io_cq_to_ena_dev(io_cq);\n-\n \t\t\tena_trc_err(dev,\n \t\t\t\t \"First bit is on in descriptor #%d on q_id: %d, req_id: %u\\n\",\n \t\t\t\t count, io_cq->qid, cdesc->req_id);\n \t\t\treturn ENA_COM_FAULT;\n \t\t}\n+\n+\t\tif (unlikely((status & (ENA_ETH_IO_RX_CDESC_BASE_MBZ7_MASK |\n+\t\t\t\t\tENA_ETH_IO_RX_CDESC_BASE_MBZ17_MASK)) &&\n+\t\t\t ena_com_get_cap(dev, ENA_ADMIN_CDESC_MBZ))) {\n+\t\t\tena_trc_err(dev,\n+\t\t\t\t \"Corrupted RX descriptor #%d on q_id: %d, req_id: %u\\n\",\n+\t\t\t\t count, io_cq->qid, cdesc->req_id);\n+\t\t\treturn ENA_COM_FAULT;\n+\t\t}\n+\n \t\tcount++;\n \t\tlast = (status & ENA_ETH_IO_RX_CDESC_BASE_LAST_MASK) >>\n \t\t\tENA_ETH_IO_RX_CDESC_BASE_LAST_SHIFT;\ndiff --git a/drivers/net/ena/hal/ena_eth_com.h b/drivers/net/ena/hal/ena_eth_com.h\nindex 6a7c17f84f..2fac10e678 100644\n--- a/drivers/net/ena/hal/ena_eth_com.h\n+++ b/drivers/net/ena/hal/ena_eth_com.h\n@@ -204,9 +204,11 @@ static inline void ena_com_cq_inc_head(struct ena_com_io_cq *io_cq)\n static inline int ena_com_tx_comp_req_id_get(struct ena_com_io_cq *io_cq,\n \t\t\t\t\t u16 *req_id)\n {\n+\tstruct ena_com_dev *dev = ena_com_io_cq_to_ena_dev(io_cq);\n \tu8 expected_phase, cdesc_phase;\n \tstruct ena_eth_io_tx_cdesc *cdesc;\n \tu16 masked_head;\n+\tu8 flags;\n \n \tmasked_head = io_cq->head & (io_cq->q_depth - 1);\n \texpected_phase = io_cq->phase;\n@@ -215,14 +217,24 @@ static inline int ena_com_tx_comp_req_id_get(struct ena_com_io_cq *io_cq,\n \t\t((uintptr_t)io_cq->cdesc_addr.virt_addr +\n \t\t(masked_head * io_cq->cdesc_entry_size_in_bytes));\n \n+\tflags = READ_ONCE8(cdesc->flags);\n+\n \t/* When the current completion descriptor phase isn't the same as the\n \t * expected, it mean that the device still didn't update\n \t * this completion.\n \t */\n-\tcdesc_phase = READ_ONCE8(cdesc->flags) & ENA_ETH_IO_TX_CDESC_PHASE_MASK;\n+\tcdesc_phase = flags & ENA_ETH_IO_TX_CDESC_PHASE_MASK;\n \tif (cdesc_phase != expected_phase)\n \t\treturn ENA_COM_TRY_AGAIN;\n \n+\tif (unlikely((flags & ENA_ETH_IO_TX_CDESC_MBZ6_MASK) &&\n+\t\t ena_com_get_cap(dev, ENA_ADMIN_CDESC_MBZ))) {\n+\t\tena_trc_err(dev,\n+\t\t\t \"Corrupted TX descriptor on q_id: %d, req_id: %u\\n\",\n+\t\t\t io_cq->qid, cdesc->req_id);\n+\t\treturn ENA_COM_FAULT;\n+\t}\n+\n \tdma_rmb();\n \n \t*req_id = READ_ONCE16(cdesc->req_id);\n", "prefixes": [ "v2", "14/33" ] }