Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137881/?format=api
{ "id": 137881, "url": "http://patches.dpdk.org/api/patches/137881/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240304122942.3496-4-shaibran@amazon.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240304122942.3496-4-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240304122942.3496-4-shaibran@amazon.com", "date": "2024-03-04T12:29:12", "name": "[v2,03/33] net/ena: update imissed stat with Rx overruns", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2b20f0d69fecb7fef33844b8b967ce6d26fec337", "submitter": { "id": 2930, "url": "http://patches.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240304122942.3496-4-shaibran@amazon.com/mbox/", "series": [ { "id": 31362, "url": "http://patches.dpdk.org/api/series/31362/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31362", "date": "2024-03-04T12:29:09", "name": "net/ena: v2.9.0 driver release", "version": 2, "mbox": "http://patches.dpdk.org/series/31362/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137881/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137881/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 68B0243B9B;\n\tMon, 4 Mar 2024 13:30:13 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 33BC0406B6;\n\tMon, 4 Mar 2024 13:30:05 +0100 (CET)", "from smtp-fw-52004.amazon.com (smtp-fw-52004.amazon.com\n [52.119.213.154])\n by mails.dpdk.org (Postfix) with ESMTP id F28DF40262\n for <dev@dpdk.org>; Mon, 4 Mar 2024 13:30:00 +0100 (CET)", "from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO\n smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.43.8.2])\n by smtp-border-fw-52004.iad7.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 12:29:59 +0000", "from EX19MTAEUA002.ant.amazon.com [10.0.10.100:47462]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.23.38:2525]\n with esmtp (Farcaster)\n id 12030fff-3e8a-48d6-a5e9-0ed8dfcab03c; Mon, 4 Mar 2024 12:29:57 +0000 (UTC)", "from EX19D007EUA001.ant.amazon.com (10.252.50.133) by\n EX19MTAEUA002.ant.amazon.com (10.252.50.126) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Mon, 4 Mar 2024 12:29:57 +0000", "from EX19MTAUWA001.ant.amazon.com (10.250.64.204) by\n EX19D007EUA001.ant.amazon.com (10.252.50.133) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Mon, 4 Mar 2024 12:29:57 +0000", "from HFA15-CG15235BS.amazon.com (10.1.212.49) by\n mail-relay.amazon.com (10.250.64.204) with Microsoft SMTP Server id\n 15.2.1258.28 via Frontend Transport; Mon, 4 Mar 2024 12:29:55 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1709555402; x=1741091402;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=4dZAtYkiE6lhOaDbHE5ce8hRE0FEhRd8KKXOL80impg=;\n b=IF8jLBiv7NBGLV4g4EKJpIZpN90Jb1Xz5Ena/M8ZvFKre1CXid44HOcE\n U/4L4WSTDqET1dNQDPfu9vBZtmHpVUNXAuMlbU8RWOOp/GD1VH/8PRDW7\n KYTm0wMmxWEDORUIjdtC7N0lmmspfte8gkyfc4goElt3iQGgFWZ8VUFTv A=;", "X-IronPort-AV": "E=Sophos;i=\"6.06,203,1705363200\"; d=\"scan'208\";a=\"189025510\"", "X-Farcaster-Flow-ID": "12030fff-3e8a-48d6-a5e9-0ed8dfcab03c", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>", "Subject": "[PATCH v2 03/33] net/ena: update imissed stat with Rx overruns", "Date": "Mon, 4 Mar 2024 14:29:12 +0200", "Message-ID": "<20240304122942.3496-4-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240304122942.3496-1-shaibran@amazon.com>", "References": "<20240304122942.3496-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\nDepending on its acceleration support, the device updates\na different statistic when an ingress packet is dropped\nbecause no buffers are available to hold it.\n- In AWS instance types from later generations\n'rx_overruns' is updated.\n- Otherwise, in legacy instance types,\n'rx_dropped_cnt' is updated.\n\nThat is, there is no need to report rx_overruns separately\nas an xstat and the driver can simply sum up the two\nself-contained counters as the 'imissed' statistic.\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\n doc/guides/rel_notes/release_24_03.rst | 4 ++++\n drivers/net/ena/ena_ethdev.c | 8 +++++---\n drivers/net/ena/ena_ethdev.h | 1 -\n 3 files changed, 9 insertions(+), 4 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst\nindex 879bb4944c..fb66d67d32 100644\n--- a/doc/guides/rel_notes/release_24_03.rst\n+++ b/doc/guides/rel_notes/release_24_03.rst\n@@ -101,6 +101,10 @@ New Features\n * ``rte_flow_template_table_resize_complete()``.\n Complete table resize.\n \n+* **Updated Amazon ena (Elastic Network Adapter) net driver.**\n+\n+ * Removed the reporting of `rx_overruns` errors from xstats and instead updated `imissed` stat with its value.\n+\n * **Updated Atomic Rules' Arkville driver.**\n \n * Added support for Atomic Rules' TK242 packet-capture family of devices\ndiff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex b1e7de0541..d3f395a832 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -93,7 +93,6 @@ static const struct ena_stats ena_stats_global_strings[] = {\n \tENA_STAT_GLOBAL_ENTRY(dev_start),\n \tENA_STAT_GLOBAL_ENTRY(dev_stop),\n \tENA_STAT_GLOBAL_ENTRY(tx_drops),\n-\tENA_STAT_GLOBAL_ENTRY(rx_overruns),\n };\n \n /*\n@@ -4014,9 +4013,12 @@ static void ena_keep_alive(void *adapter_data,\n \ttx_drops = ((uint64_t)desc->tx_drops_high << 32) | desc->tx_drops_low;\n \trx_overruns = ((uint64_t)desc->rx_overruns_high << 32) | desc->rx_overruns_low;\n \n-\tadapter->drv_stats->rx_drops = rx_drops;\n+\t/*\n+\t * Depending on its acceleration support, the device updates a different statistic when\n+\t * Rx packet is dropped because there are no available buffers to accommodate it.\n+\t */\n+\tadapter->drv_stats->rx_drops = rx_drops + rx_overruns;\n \tadapter->dev_stats.tx_drops = tx_drops;\n-\tadapter->dev_stats.rx_overruns = rx_overruns;\n }\n \n /**\ndiff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h\nindex 4988fbffb5..20b8307836 100644\n--- a/drivers/net/ena/ena_ethdev.h\n+++ b/drivers/net/ena/ena_ethdev.h\n@@ -219,7 +219,6 @@ struct ena_stats_dev {\n \t * As a workaround it is being published as an extended statistic.\n \t */\n \tu64 tx_drops;\n-\tu64 rx_overruns;\n };\n \n struct ena_stats_metrics {\n", "prefixes": [ "v2", "03/33" ] }