Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137850/?format=api
{ "id": 137850, "url": "http://patches.dpdk.org/api/patches/137850/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240304090136.861-12-shaibran@amazon.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240304090136.861-12-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240304090136.861-12-shaibran@amazon.com", "date": "2024-03-04T09:01:14", "name": "[11/33] net/ena/hal: optimize Rx ring submission queue", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "232a2e31b480a9c9334d1bb3389d0d9672933388", "submitter": { "id": 2930, "url": "http://patches.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240304090136.861-12-shaibran@amazon.com/mbox/", "series": [ { "id": 31356, "url": "http://patches.dpdk.org/api/series/31356/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31356", "date": "2024-03-04T09:01:07", "name": "net/ena: v2.9.0 driver release", "version": 1, "mbox": "http://patches.dpdk.org/series/31356/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137850/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137850/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 67C3243B9B;\n\tMon, 4 Mar 2024 10:03:10 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AFEA340E68;\n\tMon, 4 Mar 2024 10:02:05 +0100 (CET)", "from smtp-fw-52005.amazon.com (smtp-fw-52005.amazon.com\n [52.119.213.156])\n by mails.dpdk.org (Postfix) with ESMTP id DEBDD40698\n for <dev@dpdk.org>; Mon, 4 Mar 2024 10:01:57 +0100 (CET)", "from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO\n smtpout.prod.us-east-1.prod.farcaster.email.amazon.dev) ([10.43.8.6])\n by smtp-border-fw-52005.iad7.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 09:01:58 +0000", "from EX19MTAEUA002.ant.amazon.com [10.0.43.254:24685]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.11.111:2525]\n with esmtp (Farcaster)\n id e18047fd-a900-4d3c-9747-c3e0335288bd; Mon, 4 Mar 2024 09:01:56 +0000 (UTC)", "from EX19D007EUA002.ant.amazon.com (10.252.50.68) by\n EX19MTAEUA002.ant.amazon.com (10.252.50.126) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Mon, 4 Mar 2024 09:01:56 +0000", "from EX19MTAUEC001.ant.amazon.com (10.252.135.222) by\n EX19D007EUA002.ant.amazon.com (10.252.50.68) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Mon, 4 Mar 2024 09:01:56 +0000", "from HFA15-CG15235BS.amazon.com (10.1.212.49) by\n mail-relay.amazon.com (10.252.135.200) with Microsoft SMTP Server id\n 15.2.1258.28 via Frontend Transport; Mon, 4 Mar 2024 09:01:55 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1709542918; x=1741078918;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=esilZkeoYx3BW4n7Z8Lk/G/rK4AxwqZp+CW/Ijc+K9g=;\n b=tMQ9FPU+Db0vITPNg0m4KnvjGcaqb7wStANfbUI1vIxty01HFFMmbE3M\n mDiu6ePHt/mpnkf/i86gXCrbBZNsvdtNKQvFecCxjuepCSblEH/js6jqc\n 3zHA9y1NbgEItEgR/xfhrKdFmtfoE8HoJVNQWKDuGWRIqfhmLVwUX0CQ+ I=;", "X-IronPort-AV": "E=Sophos;i=\"6.06,203,1705363200\"; d=\"scan'208\";a=\"638336067\"", "X-Farcaster-Flow-ID": "e18047fd-a900-4d3c-9747-c3e0335288bd", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>", "Subject": "[PATCH 11/33] net/ena/hal: optimize Rx ring submission queue", "Date": "Mon, 4 Mar 2024 11:01:14 +0200", "Message-ID": "<20240304090136.861-12-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240304090136.861-1-shaibran@amazon.com>", "References": "<20240304090136.861-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\nRX ring submission queue descriptors are always located in host memory\nThis optimization replaces the generic descriptor retrieval method\nwith a tailored method for host memory type descriptors to avoid\nunnecessary if statement.\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\n drivers/net/ena/hal/ena_eth_com.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ena/hal/ena_eth_com.c b/drivers/net/ena/hal/ena_eth_com.c\nindex d6811c7b48..dc2935a53e 100644\n--- a/drivers/net/ena/hal/ena_eth_com.c\n+++ b/drivers/net/ena/hal/ena_eth_com.c\n@@ -631,9 +631,8 @@ int ena_com_add_single_rx_desc(struct ena_com_io_sq *io_sq,\n \tif (unlikely(!ena_com_sq_have_enough_space(io_sq, 1)))\n \t\treturn ENA_COM_NO_SPACE;\n \n-\tdesc = get_sq_desc(io_sq);\n-\tif (unlikely(!desc))\n-\t\treturn ENA_COM_FAULT;\n+\t/* virt_addr allocation success is checked before calling this function */\n+\tdesc = get_sq_desc_regular_queue(io_sq);\n \n \tmemset(desc, 0x0, sizeof(struct ena_eth_io_rx_desc));\n \n", "prefixes": [ "11/33" ] }