Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137842/?format=api
{ "id": 137842, "url": "http://patches.dpdk.org/api/patches/137842/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240304090136.861-5-shaibran@amazon.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240304090136.861-5-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240304090136.861-5-shaibran@amazon.com", "date": "2024-03-04T09:01:07", "name": "[04/33] net/ena: sub-optimal configuration notifications support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fbf87baa3785d1977bd755de51742850f8dfc288", "submitter": { "id": 2930, "url": "http://patches.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240304090136.861-5-shaibran@amazon.com/mbox/", "series": [ { "id": 31356, "url": "http://patches.dpdk.org/api/series/31356/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31356", "date": "2024-03-04T09:01:07", "name": "net/ena: v2.9.0 driver release", "version": 1, "mbox": "http://patches.dpdk.org/series/31356/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137842/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137842/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 799E543B9B;\n\tMon, 4 Mar 2024 10:01:58 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F25F7402DA;\n\tMon, 4 Mar 2024 10:01:53 +0100 (CET)", "from smtp-fw-52004.amazon.com (smtp-fw-52004.amazon.com\n [52.119.213.154])\n by mails.dpdk.org (Postfix) with ESMTP id E0BA140041\n for <dev@dpdk.org>; Mon, 4 Mar 2024 10:01:51 +0100 (CET)", "from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO\n smtpout.prod.us-east-1.prod.farcaster.email.amazon.dev) ([10.43.8.2])\n by smtp-border-fw-52004.iad7.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 09:01:50 +0000", "from EX19MTAEUA002.ant.amazon.com [10.0.43.254:63738]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.20.189:2525]\n with esmtp (Farcaster)\n id 5840a029-af6e-4fac-964f-fb4a4fcf34b3; Mon, 4 Mar 2024 09:01:49 +0000 (UTC)", "from EX19D007EUA002.ant.amazon.com (10.252.50.68) by\n EX19MTAEUA002.ant.amazon.com (10.252.50.126) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Mon, 4 Mar 2024 09:01:46 +0000", "from EX19MTAUEC001.ant.amazon.com (10.252.135.222) by\n EX19D007EUA002.ant.amazon.com (10.252.50.68) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Mon, 4 Mar 2024 09:01:46 +0000", "from HFA15-CG15235BS.amazon.com (10.1.212.49) by\n mail-relay.amazon.com (10.252.135.200) with Microsoft SMTP Server id\n 15.2.1258.28 via Frontend Transport; Mon, 4 Mar 2024 09:01:45 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1709542912; x=1741078912;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=yptce/OFr2/7WPbgq5E3PmVZ26eQ0UlKUoff1IDDeN0=;\n b=QRLUgVt7Mr88GB1yDf10s/O5x8fNCUHeaQnmopXu4QfIpOtL1NI9J1af\n ezLdnuzFiFIFsPVzDv34EbRg8W/Yu7JT1PiIw1X8Y9RSHU0XZ2/vV0Mo8\n wkdj+yaefv1+LUtPKnZZoQBe/CR9j51hkLTkbUmJw59U3D7Fwxyx7SnJC 0=;", "X-IronPort-AV": "E=Sophos;i=\"6.06,203,1705363200\"; d=\"scan'208\";a=\"188980949\"", "X-Farcaster-Flow-ID": "5840a029-af6e-4fac-964f-fb4a4fcf34b3", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>", "Subject": "[PATCH 04/33] net/ena: sub-optimal configuration notifications\n support", "Date": "Mon, 4 Mar 2024 11:01:07 +0200", "Message-ID": "<20240304090136.861-5-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240304090136.861-1-shaibran@amazon.com>", "References": "<20240304090136.861-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\nENA device will send asynchronous notifications to the\ndriver in order to notify users about sub-optimal configurations\nand refer them to public AWS documentation for further action.\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\n doc/guides/rel_notes/release_24_03.rst | 1 +\n .../net/ena/base/ena_defs/ena_admin_defs.h | 11 +++++++-\n drivers/net/ena/ena_ethdev.c | 26 +++++++++++++++++--\n 3 files changed, 35 insertions(+), 3 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst\nindex fb66d67d32..f47073c7dc 100644\n--- a/doc/guides/rel_notes/release_24_03.rst\n+++ b/doc/guides/rel_notes/release_24_03.rst\n@@ -104,6 +104,7 @@ New Features\n * **Updated Amazon ena (Elastic Network Adapter) net driver.**\n \n * Removed the reporting of `rx_overruns` errors from xstats and instead updated `imissed` stat with its value.\n+ * Added support for sub-optimal configuration notifications from the device.\n \n * **Updated Atomic Rules' Arkville driver.**\n \ndiff --git a/drivers/net/ena/base/ena_defs/ena_admin_defs.h b/drivers/net/ena/base/ena_defs/ena_admin_defs.h\nindex fa43e22918..4172916551 100644\n--- a/drivers/net/ena/base/ena_defs/ena_admin_defs.h\n+++ b/drivers/net/ena/base/ena_defs/ena_admin_defs.h\n@@ -1214,7 +1214,8 @@ enum ena_admin_aenq_group {\n \tENA_ADMIN_NOTIFICATION = 3,\n \tENA_ADMIN_KEEP_ALIVE = 4,\n \tENA_ADMIN_REFRESH_CAPABILITIES = 5,\n-\tENA_ADMIN_AENQ_GROUPS_NUM = 6,\n+\tENA_ADMIN_CONF_NOTIFICATIONS = 6,\n+\tENA_ADMIN_AENQ_GROUPS_NUM = 7,\n };\n \n enum ena_admin_aenq_notification_syndrome {\n@@ -1251,6 +1252,14 @@ struct ena_admin_aenq_keep_alive_desc {\n \tuint32_t rx_overruns_high;\n };\n \n+struct ena_admin_aenq_conf_notifications_desc {\n+\tstruct ena_admin_aenq_common_desc aenq_common_desc;\n+\n+\tuint64_t notifications_bitmap;\n+\n+\tuint64_t reserved;\n+};\n+\n struct ena_admin_ena_mmio_req_read_less_resp {\n \tuint16_t req_id;\n \ndiff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex d3f395a832..3157237c0d 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -36,6 +36,10 @@\n \n #define ENA_MIN_RING_DESC\t128\n \n+#define BITS_PER_BYTE 8\n+\n+#define BITS_PER_TYPE(type) (sizeof(type) * BITS_PER_BYTE)\n+\n /*\n * We should try to keep ENA_CLEANUP_BUF_SIZE lower than\n * RTE_MEMPOOL_CACHE_MAX_SIZE, so we can fit this in mempool local cache.\n@@ -1842,7 +1846,8 @@ static int ena_device_init(struct ena_adapter *adapter,\n \t\t BIT(ENA_ADMIN_NOTIFICATION) |\n \t\t BIT(ENA_ADMIN_KEEP_ALIVE) |\n \t\t BIT(ENA_ADMIN_FATAL_ERROR) |\n-\t\t BIT(ENA_ADMIN_WARNING);\n+\t\t BIT(ENA_ADMIN_WARNING) |\n+\t\t BIT(ENA_ADMIN_CONF_NOTIFICATIONS);\n \n \taenq_groups &= get_feat_ctx->aenq.supported_groups;\n \n@@ -4021,6 +4026,22 @@ static void ena_keep_alive(void *adapter_data,\n \tadapter->dev_stats.tx_drops = tx_drops;\n }\n \n+static void ena_suboptimal_configuration(__rte_unused void *adapter_data,\n+\t\t\t\t\t struct ena_admin_aenq_entry *aenq_e)\n+{\n+\tstruct ena_admin_aenq_conf_notifications_desc *desc;\n+\tint bit, num_bits;\n+\n+\tdesc = (struct ena_admin_aenq_conf_notifications_desc *)aenq_e;\n+\tnum_bits = BITS_PER_TYPE(desc->notifications_bitmap);\n+\tfor (bit = 0; bit < num_bits; bit++) {\n+\t\tif (desc->notifications_bitmap & RTE_BIT64(bit)) {\n+\t\t\tPMD_DRV_LOG(WARNING,\n+\t\t\t\t\"Sub-optimal configuration notification code: %d\\n\", bit + 1);\n+\t\t}\n+\t}\n+}\n+\n /**\n * This handler will called for unknown event group or unimplemented handlers\n **/\n@@ -4035,7 +4056,8 @@ static struct ena_aenq_handlers aenq_handlers = {\n \t.handlers = {\n \t\t[ENA_ADMIN_LINK_CHANGE] = ena_update_on_link_change,\n \t\t[ENA_ADMIN_NOTIFICATION] = ena_notification,\n-\t\t[ENA_ADMIN_KEEP_ALIVE] = ena_keep_alive\n+\t\t[ENA_ADMIN_KEEP_ALIVE] = ena_keep_alive,\n+\t\t[ENA_ADMIN_CONF_NOTIFICATIONS] = ena_suboptimal_configuration\n \t},\n \t.unimplemented_handler = unimplemented_aenq_handler\n };\n", "prefixes": [ "04/33" ] }